[linux-lvm] lv_on_disk_size

[linux-lvm] lv_on_disk_size

[Jan Niehusmann]

In the BUGS file, one mentioned bug fix is the following:

> Please change the macro LVM_LV_DISK_OFFSET as below:
> 
> #define LVM_LV_DISK_OFFSET(a, b) ( (a)->lv_on_disk.base + \
>                                    sizeof ( lv_disk_t) * b)
> 

Without really understanding what's going on (all these lv_, pe_, ...
prefixes are really confusing me ;-)) I wonder if the following line
in vg_setup_for_create.c is correct:

(Line 94)
      vg->pv[p]->lv_on_disk.size = ( max_lv + 1) * sizeof ( lv_t);

Or should it be sizeof( lv_disk_t), too?


Jan

Re: [linux-lvm] lv_on_disk_size

[Jan Niehusmann]

Finally, I'm starting to reply to my own posts. I knew this would happen
one day ;-)

On Sat, Aug 19, 2000 at 05:27:39PM +0200, Jan Niehusmann wrote:
> In the BUGS file, one mentioned bug fix is the following:
> 
> > Please change the macro LVM_LV_DISK_OFFSET as below:
> > 
> > #define LVM_LV_DISK_OFFSET(a, b) ( (a)->lv_on_disk.base + \
> >                                    sizeof ( lv_disk_t) * b)
> > 

Additionally, I found that linux/lvm.h of linux-2.4-testX does contain 
the same line. In fact, linux/lvm.h is nearly identical to tools/lib/lvm.h.
I wonder if this code duplication is needed. Now that lvm is included with
the (development) kernel, linux/lvm.h should contain only things needed for
kernel compilation (IMHO).

Jan

[linux-lvm] Re: lv_on_disk_size

[Heinz J. Mauelshagen]

On Sat, Aug 19, 2000 at 05:27:39PM +0200, Jan Niehusmann wrote:
> In the BUGS file, one mentioned bug fix is the following:
> 
> > Please change the macro LVM_LV_DISK_OFFSET as below:
> > 
> > #define LVM_LV_DISK_OFFSET(a, b) ( (a)->lv_on_disk.base + \
> >                                    sizeof ( lv_disk_t) * b)
> > 
> 
> Without really understanding what's going on (all these lv_, pe_, ...
> prefixes are really confusing me ;-)) I wonder if the following line
> in vg_setup_for_create.c is correct:
> 
> (Line 94)
>       vg->pv[p]->lv_on_disk.size = ( max_lv + 1) * sizeof ( lv_t);
> 
> Or should it be sizeof( lv_disk_t), too?

Yes, it should.
THX for pinting this out.

Regards,
Heinz      -- The LVM guy --

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Bartningstr. 12
                                                  64289 Darmstadt
                                                  Germany
Mauelshagen@Sistina.com                           +49 6151 7103 86
                                                       FAX 7103 96
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-