[linux-lvm] Problems building on RedHat 7.2 with 2.4.9-21 kernel

[linux-lvm] Problems building on RedHat 7.2 with 2.4.9-21 kernel

[John DeFranco]

Hi,

I'm having some problems building lvm (1.0 or 1.0.3) on a redhat7.2 system 
with kernel 2.4.9-21. I'm getting the following errors:

drivers/md/mddev.o: In function `lvm_snapshot_alloc':
drivers/md/mddev.o(.text+0xa881): undefined reference to `alloc_kiovec'
drivers/md/mddev.o(.text+0xa8b4): undefined reference to `alloc_kiovec'
drivers/md/mddev.o(.text+0xa8f3): undefined reference to `free_kiovec'
drivers/md/mddev.o(.text+0xa91a): undefined reference to `free_kiovec'
drivers/md/mddev.o: In function `lvm_snapshot_release':
drivers/md/mddev.o(.text+0xa9b5): undefined reference to `free_kiovec'
drivers/md/mddev.o(.text+0xa9ea): undefined reference to `free_kiovec'
make[1]: *** [kallsyms] Error 1
make[1]: Leaving directory `/usr/src/linux-2.4.9-21'

After doing some research it looks to me like the problem is in file 
fs/iobuf.c which now uses alloc_kiovec_sz and free_kiovec_sz instead of the 
above:

/*
 * iobuf.c
 *
 * Keep track of the general-purpose IO-buffer structures used to track
 * abstract kernel-space io buffers.
 *
 * 07/20/01 Rohit Seth <rohit.seth@intel.com> Made the iobuf come from
 * kiobuf cache instead of vmalloc (that is a killer for most of archs.)  
These
 * changes are specifically targeted for increasing raw IO performance.
 * Introducing the new *_sz functions that take the number of bhs actually
 * required by kiovec.
 */
.
.
.
void free_kiovec_sz(int nr, struct kiobuf **bufp, int *szp)
{
.
.
.
int alloc_kiovec_sz(int nr, struct kiobuf **bufp, int *szp)
{


This file is different from what is in rh kernel 2.4.7-10 (which lvm builds 
find on) and apparently in the vanilla kernels from kernels.org which don't 
seem to have the problem either.

I've seen emails on this list saying that lvm only really works/qualified on 
vanilla kernel sources and not distro specific. I guess this is a good 
example as to why. However there has to be some easy solution to this I would 
think/hope. At this point I need to use the redhat 2.4.9-21 kernel and lvm 
1.0 since the version that is in this kernel is 0.9_beta1. So I don't have 
the option of going to 2.4.18 for example.

Any thoughts?

Thanks!
-- 
==========
John DeFranco			Hewlett-Packard Company
john_defranco@hp.com		Availability Clusters Solution Division
phone: 408-447-7543		19111 Pruneridge Ave, M/S 4101
fax: 408-447-0056		Cupertino, CA 95014 

Re: [linux-lvm] Problems building on RedHat 7.2 with 2.4.9-21 kernel

[Luca Berra]

On Mon, Mar 04, 2002 at 06:32:13PM -0800, John DeFranco wrote:
> Hi,
> 
> I'm having some problems building lvm (1.0 or 1.0.3) on a redhat7.2 system 
> with kernel 2.4.9-21. I'm getting the following errors:
> 
> drivers/md/mddev.o: In function `lvm_snapshot_alloc':
> drivers/md/mddev.o(.text+0xa881): undefined reference to `alloc_kiovec'
<snip>

> I've seen emails on this list saying that lvm only really works/qualified on 
> vanilla kernel sources and not distro specific. I guess this is a good 
well, in this case the problem seems related to 2.4.9-ac10 patch not specifically
to red hat so we might be willing to help you.
(just kidding, i am glad you are testing a better kernel than 2.4.2
for MC/SG)

> example as to why. However there has to be some easy solution to this I would 
> think/hope. At this point I need to use the redhat 2.4.9-21 kernel and lvm 
> 1.0 since the version that is in this kernel is 0.9_beta1. So I don't have 
> the option of going to 2.4.18 for example.
i don't undestand this passage,
anyway:
looking at alan's patch yow will find the answer, besides from some fixes
taken from lvm cvs he adds:
	int nbhs = KIO_MAX_SECTORS;
to both lvm_snapshot_alloc() and lvm_snapshot_release()
and changes 
	err = alloc_kiovec(1, &lv_snap->lv_iobuf);
to
	ret = alloc_kiovec_sz(1, &lv_snap->lv_iobuf, &nbhs);

and so on for other calls to alloc_kiovec and free_kiovec

I don't have time and resources to actually produce a patch and test it atm,
but i believe it would work, please let us know how you fare

regards,
Luca
	

-- 
Luca Berra -- bluca@comedia.it
        Communication Media & Services S.r.l.
 /"\
 \ /     ASCII RIBBON CAMPAIGN
  X        AGAINST HTML MAIL
 / \

Re: [linux-lvm] Problems building on RedHat 7.2 with 2.4.9-21 kernel

[John DeFranco]

Hi,

Thanks for the input. I made the changes as described below and was able to 
get lvm to build.

On Tuesday 05 March 2002 12:08 am, Luca Berra wrote:
> On Mon, Mar 04, 2002 at 06:32:13PM -0800, John DeFranco wrote:
> > Hi,
> >
> > I'm having some problems building lvm (1.0 or 1.0.3) on a redhat7.2
> > system with kernel 2.4.9-21. I'm getting the following errors:
> >
> > drivers/md/mddev.o: In function `lvm_snapshot_alloc':
> > drivers/md/mddev.o(.text+0xa881): undefined reference to `alloc_kiovec'
>
> <snip>
>
> > I've seen emails on this list saying that lvm only really works/qualified
> > on vanilla kernel sources and not distro specific. I guess this is a good
>
> well, in this case the problem seems related to 2.4.9-ac10 patch not
> specifically to red hat so we might be willing to help you.
> (just kidding, i am glad you are testing a better kernel than 2.4.2
> for MC/SG)
>
> > example as to why. However there has to be some easy solution to this I
> > would think/hope. At this point I need to use the redhat 2.4.9-21 kernel
> > and lvm 1.0 since the version that is in this kernel is 0.9_beta1. So I
> > don't have the option of going to 2.4.18 for example.
>
> i don't undestand this passage,
> anyway:
> looking at alan's patch yow will find the answer, besides from some fixes
> taken from lvm cvs he adds:
> 	int nbhs = KIO_MAX_SECTORS;
> to both lvm_snapshot_alloc() and lvm_snapshot_release()
> and changes
> 	err = alloc_kiovec(1, &lv_snap->lv_iobuf);
> to
> 	ret = alloc_kiovec_sz(1, &lv_snap->lv_iobuf, &nbhs);
>
> and so on for other calls to alloc_kiovec and free_kiovec
>
> I don't have time and resources to actually produce a patch and test it
> atm, but i believe it would work, please let us know how you fare
>
> regards,
> Luca

-- 
==========
Cheers
   -jdf