From: Jens Axboe <axboe@suse.de>
To: Nick Piggin <piggin@cyberone.com.au>
Cc: Miquel van Smoorenburg <miquels@cistron.nl>,
Andrew Morton <akpm@osdl.org>,
linux-lvm@sistina.com, linux-kernel@vger.kernel.org,
thornber@redhat.com
Subject: [linux-lvm] Re: IO scheduler, queue depth, nr_requests
Date: Thu Feb 19 10:26:07 2004 [thread overview]
Message-ID: <20040219102108.GK27190@suse.de> (raw)
In-Reply-To: <403424A4.3090007@cyberone.com.au>
On Thu, Feb 19 2004, Nick Piggin wrote:
>
>
> Miquel van Smoorenburg wrote:
>
> >
> >No, I'm actually referring to a struct request. I'm logging this in the
> >SCSI layer, in scsi_request_fn(), just after elv_next_request(). I have
> >in fact logged all the bio's submitted to __make_request, and the output
> >of the elevator from elv_next_request(). The bio's are submitted
> >sequentially,
> >the resulting requests aren't. But this is because nr_requests is 128,
> >while
> >the 3ware device has a queue of 254 entries (no tagging though). Upping
> >nr_requests to 512 makes this go away ..
> >
> >That shouldn't be necessary though. I only see this with LVM over
> >3ware-raid5,
> >not on the 3ware-raid5 array directly (/dev/sda1). And it gets less
> >troublesome
> >with a lot of debugging (unless I set nr_requests lower again), which
> >points
> >to a timing issue.
> >
> >
>
> So the problem you are seeing is due to "unlucky" timing between
> two processes submitting IO. And the very efficient mechanisms
> (merging, sorting) we have to improve situations exactly like this
> is effectively disabled. And to make it worse, it appears that your
> controller shits itself on this trivially simple pattern.
>
> Your hack makes a baby step in the direction of per *process*
> request limits, which I happen to be an advocate of. As it stands
> though, I don't like it.
I'm very much an advocate for per process request limits as well. Would
be trivial to add... Miquels patch is horrible, I appreciate it being
posted as a cry for help.
--
Jens Axboe
next prev parent reply other threads:[~2004-02-19 10:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-16 9:11 [linux-lvm] IO scheduler, queue depth, nr_requests Miquel van Smoorenburg
2004-02-16 8:30 ` [linux-lvm] " Jens Axboe
2004-02-16 9:01 ` Joe Thornber
2004-02-16 19:32 ` Kevin P. Fleming
2004-02-17 1:46 ` Kevin P. Fleming
2004-02-18 10:29 ` Miquel van Smoorenburg
2004-02-19 8:51 ` Miquel van Smoorenburg
2004-02-19 8:50 ` Andrew Morton
2004-02-19 9:08 ` Miquel van Smoorenburg
2004-02-19 9:08 ` Andrew Morton
2004-02-19 10:23 ` Miquel van Smoorenburg
2004-02-19 10:26 ` Jens Axboe
2004-02-19 15:58 ` Miquel van Smoorenburg
2004-02-19 17:52 ` Nick Piggin
2004-02-19 18:52 ` Miquel van Smoorenburg
2004-02-19 19:15 ` Nick Piggin
2004-02-19 20:16 ` [linux-lvm] [PATCH] per process request limits (was Re: IO scheduler, queue depth, nr_requests) Nick Piggin
2004-02-19 20:25 ` [linux-lvm] " Andrew Morton
2004-02-19 20:40 ` Nick Piggin
2004-02-19 21:32 ` Andrew Morton
2004-02-23 8:41 ` [linux-lvm] [PATCH] bdi_congestion_funp (was: Re: [PATCH] per process request limits (was Re: IO scheduler, queue depth, nr_requests)) Miquel van Smoorenburg
2004-02-20 9:56 ` [linux-lvm] " Joe Thornber
2004-02-20 9:59 ` Jens Axboe
2004-02-23 8:45 ` Miquel van Smoorenburg
2004-02-22 14:55 ` Andrew Morton
2004-02-20 9:57 ` Jens Axboe
2004-02-24 12:54 ` [linux-lvm] Queue congestion: passing down vs passing up [PATCH] Miquel van Smoorenburg
2004-02-19 20:52 ` [linux-lvm] Re: [PATCH] per process request limits (was Re: IO scheduler, queue depth, nr_requests) Nick Piggin
2004-02-19 9:11 ` [linux-lvm] Re: IO scheduler, queue depth, nr_requests Nick Piggin
2004-02-19 10:26 ` Jens Axboe [this message]
2004-02-19 8:51 ` Nick Piggin
2004-02-19 9:00 ` Miquel van Smoorenburg
2004-02-19 9:00 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040219102108.GK27190@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lvm@redhat.com \
--cc=linux-lvm@sistina.com \
--cc=miquels@cistron.nl \
--cc=piggin@cyberone.com.au \
--cc=thornber@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox