From: Ben Hutchings <ben@decadent.org.uk>
To: Thorsten Glaser <tg@mirbsd.de>
Cc: linux-m68k@vger.kernel.org,
Debian Kernel Team <debian-kernel@lists.debian.org>
Subject: Re: aufs vs. m68k conflict, please advice
Date: Sat, 17 Dec 2011 16:29:35 +0000 [thread overview]
Message-ID: <1324139375.2825.330.camel@deadeye> (raw)
In-Reply-To: <Pine.BSM.4.64L.1112171426140.856@herc.mirbsd.org>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On Sat, 2011-12-17 at 14:28 +0000, Thorsten Glaser wrote:
> Ben Hutchings dixit:
>
> >why other architectures get away with it. Maybe they just don't use
> >pr_*() in headers.
>
> Maybe something like this?
>
> #define ack_bad_irq(irq) do { \
> pr_crit("unexpected IRQ trap at vector %02x\n", \
> (unsigned int)(irq)); \
> } while (/* CONSTCOND */ 0)
>
> This would defer pr_crit expansion to when the static inline
> function was actually used.
No, I don't think this is a bug in the header.
Ben.
--
Ben Hutchings
Computers are not intelligent. They only think they are.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-12-17 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 14:42 aufs vs. m68k conflict, please advice Thorsten Glaser
2011-12-16 16:48 ` Ben Hutchings
2011-12-16 17:15 ` Thorsten Glaser
2011-12-17 14:28 ` Thorsten Glaser
2011-12-17 16:24 ` Thorsten Glaser
2011-12-17 16:29 ` Ben Hutchings [this message]
2011-12-17 18:49 ` Uwe Kleine-König
2011-12-17 19:00 ` Thorsten Glaser
2011-12-17 19:57 ` Uwe Kleine-König
2011-12-17 20:09 ` [PATCH] m68k/irq: don't use pr_crit in an header Uwe Kleine-König
2011-12-17 21:19 ` Thorsten Glaser
2011-12-18 10:32 ` Geert Uytterhoeven
2011-12-18 10:42 ` Uwe Kleine-König
2011-12-18 17:06 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324139375.2825.330.camel@deadeye \
--to=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=linux-m68k@vger.kernel.org \
--cc=tg@mirbsd.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox