From: Ben Hutchings <ben@decadent.org.uk>
To: Thorsten Glaser <tg@debian.org>
Cc: linux-m68k@vger.kernel.org,
Debian Kernel Team <debian-kernel@lists.debian.org>
Subject: Re: aufs vs. m68k conflict, please advice
Date: Fri, 16 Dec 2011 16:48:13 +0000 [thread overview]
Message-ID: <1324054093.2825.282.camel@deadeye> (raw)
In-Reply-To: <Pine.BSM.4.64L.1112161437090.856@herc.mirbsd.org>
[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]
On Fri, 2011-12-16 at 14:42 +0000, Thorsten Glaser wrote:
> Hi,
>
> a build of linux-2.6 (3.2~rc4-1~experimental.1) with gcc-4.6 (to
> check whether we can switch to it for the kernel, too) fails:
[...]
> /tmp/buildd/linux-2.6-3.2~rc4/debian/build/source_m68k_none/arch/m68k/include/asm/hardirq.h: In function 'ack_bad_irq':
> /tmp/buildd/linux-2.6-3.2~rc4/debian/build/source_m68k_none/arch/m68k/include/asm/hardirq.h:23:2: error: expected ')' before 'AUFS_NAME'
> make[7]: *** [fs/aufs/module.o] Error 1
> […]
>
> The cause isn’t hard to figure out:
>
> I /tmp/buildd/linux-2.6-3.2~rc4/debian/build/source_m68k_none/arch/m68k R21 <40 C1 384 |180 115|73 14:39
> 21 static inline void ack_bad_irq(unsigned int irq)
> 22 {
> 23 pr_crit("unexpected IRQ trap at vector %02x\n", irq);
> 24 }
>
> (pbuild26252)root@ara5:/ # fgrep AUFS_NAME /tmp/buildd/linux-2.6-3.2~rc4/debian/build/source_m68k_none/fs/aufs/*
> /tmp/buildd/linux-2.6-3.2~rc4/debian/build/source_m68k_none/fs/aufs/Makefile:ccflags-y += -D'pr_fmt(fmt)=AUFS_NAME"\040%s:%d:%s[%d]:\040"fmt,__func__,__LINE__,current->comm,current->pid'
>
> This, to me, looks like cpp abuse in aufs, but I’m not a kernel
> programmer (Linux or otherwise).
Maybe, but it should work just as long as AUFS_NAME is also defined in
advance. Not sure why that's not also provided on the command line, or
why other architectures get away with it. Maybe they just don't use
pr_*() in headers.
Ben.
--
Ben Hutchings
Computers are not intelligent. They only think they are.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-12-16 16:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 14:42 aufs vs. m68k conflict, please advice Thorsten Glaser
2011-12-16 16:48 ` Ben Hutchings [this message]
2011-12-16 17:15 ` Thorsten Glaser
2011-12-17 14:28 ` Thorsten Glaser
2011-12-17 16:24 ` Thorsten Glaser
2011-12-17 16:29 ` Ben Hutchings
2011-12-17 18:49 ` Uwe Kleine-König
2011-12-17 19:00 ` Thorsten Glaser
2011-12-17 19:57 ` Uwe Kleine-König
2011-12-17 20:09 ` [PATCH] m68k/irq: don't use pr_crit in an header Uwe Kleine-König
2011-12-17 21:19 ` Thorsten Glaser
2011-12-18 10:32 ` Geert Uytterhoeven
2011-12-18 10:42 ` Uwe Kleine-König
2011-12-18 17:06 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324054093.2825.282.camel@deadeye \
--to=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=linux-m68k@vger.kernel.org \
--cc=tg@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox