[PATCH] m68k: make syscall_trace_enter/leave exist for non-MMU classic m68k types

[PATCH] m68k: make syscall_trace_enter/leave exist for non-MMU classic m68k types

[gerg]

From: Greg Ungerer <gerg@uclinux.org>

The assembler entry code calls directly to the syscall_trace_enter() and
syscall_trace_leave() functions. But currently they are conditionaly
compiled out for the non-MMU classic m68k CPU types (so 68328 for example),
resulting in a link error:

      LD      vmlinux
    arch/m68k/platform/68328/built-in.o: In function `do_trace':
    (.text+0x1c): undefined reference to `syscall_trace_enter'
    arch/m68k/platform/68328/built-in.o: In function `do_trace':
    (.text+0x4c): undefined reference to `syscall_trace_leave'

Change the conditional check that includes these functions to be true for
the !defined(CONFIG_MMU) case as well.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/kernel/ptrace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/m68k/kernel/ptrace.c b/arch/m68k/kernel/ptrace.c
index 8b4a222..1bc10e6 100644
--- a/arch/m68k/kernel/ptrace.c
+++ b/arch/m68k/kernel/ptrace.c
@@ -286,7 +286,7 @@ asmlinkage void syscall_trace(void)
 	}
 }
 
-#ifdef CONFIG_COLDFIRE
+#if defined(CONFIG_COLDFIRE) || !defined(CONFIG_MMU)
 asmlinkage int syscall_trace_enter(void)
 {
 	int ret = 0;
-- 
1.7.0.4

_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Re: [PATCH] m68k: make syscall_trace_enter/leave exist for non-MMU classic m68k types

[Geert Uytterhoeven]

On Fri, Jun 8, 2012 at 7:28 AM,  <gerg@snapgear.com> wrote:
> From: Greg Ungerer <gerg@uclinux.org>
>
> The assembler entry code calls directly to the syscall_trace_enter() and
> syscall_trace_leave() functions. But currently they are conditionaly
> compiled out for the non-MMU classic m68k CPU types (so 68328 for example),
> resulting in a link error:
>
>      LD      vmlinux
>    arch/m68k/platform/68328/built-in.o: In function `do_trace':
>    (.text+0x1c): undefined reference to `syscall_trace_enter'
>    arch/m68k/platform/68328/built-in.o: In function `do_trace':
>    (.text+0x4c): undefined reference to `syscall_trace_leave'
>
> Change the conditional check that includes these functions to be true for
> the !defined(CONFIG_MMU) case as well.
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Hmm, should add syscall_trace support to M68KCLASSIC/MMU...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] m68k: make syscall_trace_enter/leave exist for non-MMU classic m68k types

[Greg Ungerer]

Hi Geert,

On 06/08/2012 05:16 PM, Geert Uytterhoeven wrote:
> On Fri, Jun 8, 2012 at 7:28 AM,<gerg@snapgear.com>  wrote:
>> From: Greg Ungerer<gerg@uclinux.org>
>>
>> The assembler entry code calls directly to the syscall_trace_enter() and
>> syscall_trace_leave() functions. But currently they are conditionaly
>> compiled out for the non-MMU classic m68k CPU types (so 68328 for example),
>> resulting in a link error:
>>
>>       LD      vmlinux
>>     arch/m68k/platform/68328/built-in.o: In function `do_trace':
>>     (.text+0x1c): undefined reference to `syscall_trace_enter'
>>     arch/m68k/platform/68328/built-in.o: In function `do_trace':
>>     (.text+0x4c): undefined reference to `syscall_trace_leave'
>>
>> Change the conditional check that includes these functions to be true for
>> the !defined(CONFIG_MMU) case as well.
>>
>> Signed-off-by: Greg Ungerer<gerg@uclinux.org>
>
> Acked-by: Geert Uytterhoeven<geert@linux-m68k.org>
>
> Hmm, should add syscall_trace support to M68KCLASSIC/MMU...

That would be nice :-)

Regards
Greg



> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>