From: Joe Perches <joe@perches.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k/setup: Use pr_*() instead of plain printk()
Date: Sun, 30 Jun 2013 15:22:28 -0700 [thread overview]
Message-ID: <1372630948.2083.3.camel@joe-AO722> (raw)
In-Reply-To: <1372585689-29492-1-git-send-email-geert@linux-m68k.org>
On Sun, 2013-06-30 at 11:48 +0200, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Hi Geert, just trivial comments...
> diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c
> @@ -161,7 +161,7 @@ static void __init m68k_parse_bootinfo(const struct bi_record *record)
[]
> - printk("m68k_parse_bootinfo: too many memory chunks\n");
> + pr_warn("m68k_parse_bootinfo: too many memory chunks\n");
These are generally better written by
removing the hand-written function name
and using "%s: ", __func__
pr_warn("%s: too many memory chunks\n",
__func__);
> @@ -197,8 +197,8 @@ static void __init m68k_parse_bootinfo(const struct bi_record *record)
> - printk("m68k_parse_bootinfo: unknown tag 0x%04x ignored\n",
> - record->tag);
> + pr_warn("m68k_parse_bootinfo: unknown tag 0x%04x ignored\n",
> + record->tag);
etc.
> @@ -538,9 +538,9 @@ void check_bugs(void)
> {
> #ifndef CONFIG_M68KFPU_EMU
> if (m68k_fputype == 0) {
> - printk(KERN_EMERG "*** YOU DO NOT HAVE A FLOATING POINT UNIT, "
> + pr_emerg("*** YOU DO NOT HAVE A FLOATING POINT UNIT, "
> "WHICH IS REQUIRED BY LINUX/M68K ***\n");
> - printk(KERN_EMERG "Upgrade your hardware or join the FPU "
> + pr_emerg("Upgrade your hardware or join the FPU "
> "emulation project\n");
It would be nicer to coalesce the formats
into a single line.
next parent reply other threads:[~2013-06-30 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1372585689-29492-1-git-send-email-geert@linux-m68k.org>
2013-06-30 22:22 ` Joe Perches [this message]
2013-07-01 21:02 ` [PATCH] m68k/setup: Use pr_*() instead of plain printk() Geert Uytterhoeven
2013-07-01 21:07 ` Joe Perches
2013-06-30 9:48 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372630948.2083.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox