public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
* [PATCH 1/3] rtc: rtc-cmos: Remove superfluous name cast
@ 2013-12-08  9:49 Geert Uytterhoeven
  2013-12-08  9:49 ` [PATCH 2/3] m68k/atari: Hide RTC_PORT() macro from rtc-cmos Geert Uytterhoeven
  2013-12-08  9:49 ` [PATCH 3/3] rtc: Disable RTC_DRV_CMOS on Atari Geert Uytterhoeven
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2013-12-08  9:49 UTC (permalink / raw)
  To: linux-m68k; +Cc: rtc-linux, linux-kernel, Geert Uytterhoeven, Alessandro Zummo

device_driver.name is "const char *"

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>
---
 drivers/rtc/rtc-cmos.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index f14876256a4a..ed5540d78a80 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -1127,7 +1127,7 @@ static struct platform_driver cmos_platform_driver = {
 	.remove		= __exit_p(cmos_platform_remove),
 	.shutdown	= cmos_platform_shutdown,
 	.driver = {
-		.name		= (char *) driver_name,
+		.name		= driver_name,
 #ifdef CONFIG_PM
 		.pm		= &cmos_pm_ops,
 #endif
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/3] m68k/atari: Hide RTC_PORT() macro from rtc-cmos
  2013-12-08  9:49 [PATCH 1/3] rtc: rtc-cmos: Remove superfluous name cast Geert Uytterhoeven
@ 2013-12-08  9:49 ` Geert Uytterhoeven
  2013-12-08  9:49 ` [PATCH 3/3] rtc: Disable RTC_DRV_CMOS on Atari Geert Uytterhoeven
  1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2013-12-08  9:49 UTC (permalink / raw)
  To: linux-m68k; +Cc: rtc-linux, linux-kernel, Geert Uytterhoeven

Rename RTC_PORT() to ATARI_RTC_PORT(), as the rtc-cmos RTC driver uses the
presence of this macro to enable support for the second NVRAM bank, which
Atari doesn't have ("Unable to handle kernel access at virtual address
00ff8965").

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 arch/m68k/include/asm/mc146818rtc.h |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/m68k/include/asm/mc146818rtc.h b/arch/m68k/include/asm/mc146818rtc.h
index 9f70a01f73dc..05b43bf5cdf3 100644
--- a/arch/m68k/include/asm/mc146818rtc.h
+++ b/arch/m68k/include/asm/mc146818rtc.h
@@ -10,16 +10,16 @@
 
 #include <asm/atarihw.h>
 
-#define RTC_PORT(x)	(TT_RTC_BAS + 2*(x))
+#define ATARI_RTC_PORT(x)	(TT_RTC_BAS + 2*(x))
 #define RTC_ALWAYS_BCD	0
 
 #define CMOS_READ(addr) ({ \
-atari_outb_p((addr),RTC_PORT(0)); \
-atari_inb_p(RTC_PORT(1)); \
+atari_outb_p((addr), ATARI_RTC_PORT(0)); \
+atari_inb_p(ATARI_RTC_PORT(1)); \
 })
 #define CMOS_WRITE(val, addr) ({ \
-atari_outb_p((addr),RTC_PORT(0)); \
-atari_outb_p((val),RTC_PORT(1)); \
+atari_outb_p((addr), ATARI_RTC_PORT(0)); \
+atari_outb_p((val), ATARI_RTC_PORT(1)); \
 })
 #endif /* CONFIG_ATARI */
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 3/3] rtc: Disable RTC_DRV_CMOS on Atari
  2013-12-08  9:49 [PATCH 1/3] rtc: rtc-cmos: Remove superfluous name cast Geert Uytterhoeven
  2013-12-08  9:49 ` [PATCH 2/3] m68k/atari: Hide RTC_PORT() macro from rtc-cmos Geert Uytterhoeven
@ 2013-12-08  9:49 ` Geert Uytterhoeven
  1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2013-12-08  9:49 UTC (permalink / raw)
  To: linux-m68k; +Cc: rtc-linux, linux-kernel, Geert Uytterhoeven, Alessandro Zummo

On ARAnyM (emulating an Atari Falcon, which doesn't have an RTC IRQ, as the
Second Multi Function Peripheral MFP 68901 is available on Atari TT only),
rtc-cmos doesn't work well:
  - The date is of by 32 years (2045 instead of 2013):

    rtc_cmos rtc_cmos: setting system clock to 2045-12-02 10:56:17 UTC (2395824977)

  - The hwclock utility doesn't work:

    hwclock: ioctl() to /dev/rtc to turn on update interrupts failed unexpectedly, errno=5: Input/output error.

As rtc-generic works fine for the RTC part, and nvram works for the NVRAM
part, we'll continue on using that.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>
---
 drivers/rtc/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 007730222116..f1d7e974a700 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -626,7 +626,7 @@ comment "Platform RTC drivers"
 
 config RTC_DRV_CMOS
 	tristate "PC-style 'CMOS'"
-	depends on X86 || ARM || M32R || ATARI || PPC || MIPS || SPARC64
+	depends on X86 || ARM || M32R || PPC || MIPS || SPARC64
 	default y if X86
 	help
 	  Say "yes" here to get direct support for the real time clock
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-12-08  9:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-08  9:49 [PATCH 1/3] rtc: rtc-cmos: Remove superfluous name cast Geert Uytterhoeven
2013-12-08  9:49 ` [PATCH 2/3] m68k/atari: Hide RTC_PORT() macro from rtc-cmos Geert Uytterhoeven
2013-12-08  9:49 ` [PATCH 3/3] rtc: Disable RTC_DRV_CMOS on Atari Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox