[PATCH] m68k: fix recursive dependency in Kconfig

[PATCH] m68k: fix recursive dependency in Kconfig

[Sam Ravnborg]

We had a recursive dependency between MMU_MOTOROLA and MMU_SUN3
Fix it by dropping the unused dependencies on MMU_MOTOROLA.

MMU_MOTOROLA is set to y only using select so any dependencies
are anyway ignored.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
---

I hit this recursive dependency with a patched version
of kconfig so you may not see it today.
The fix is obvious - please apply.

	Sam


 arch/m68k/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
index 836fb66..c825bde 100644
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -280,7 +280,6 @@ config M68060
 
 config MMU_MOTOROLA
 	bool
-	depends on MMU && !MMU_SUN3
 
 config MMU_SUN3
 	bool
-- 
1.6.0.2.GIT

Re: [PATCH] m68k: fix recursive dependency in Kconfig

[Geert Uytterhoeven]

On Fri, 26 Dec 2008, Sam Ravnborg wrote:
> We had a recursive dependency between MMU_MOTOROLA and MMU_SUN3
> Fix it by dropping the unused dependencies on MMU_MOTOROLA.
> 
> MMU_MOTOROLA is set to y only using select so any dependencies
> are anyway ignored.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Roman Zippel <zippel@linux-m68k.org>
> ---
> 
> I hit this recursive dependency with a patched version
> of kconfig so you may not see it today.
> The fix is obvious - please apply.

Queued in for-next.

I guess you want this in Linus' tree for 2.6.29?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] m68k: fix recursive dependency in Kconfig

[Sam Ravnborg]

On Sun, Dec 28, 2008 at 08:12:27PM +0100, Geert Uytterhoeven wrote:
> On Fri, 26 Dec 2008, Sam Ravnborg wrote:
> > We had a recursive dependency between MMU_MOTOROLA and MMU_SUN3
> > Fix it by dropping the unused dependencies on MMU_MOTOROLA.
> > 
> > MMU_MOTOROLA is set to y only using select so any dependencies
> > are anyway ignored.
> > 
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: Roman Zippel <zippel@linux-m68k.org>
> > ---
> > 
> > I hit this recursive dependency with a patched version
> > of kconfig so you may not see it today.
> > The fix is obvious - please apply.
> 
> Queued in for-next.
> 
> I guess you want this in Linus' tree for 2.6.29?

Yes please. I plan to submit the improved dependency check in my second
kbuild update if Roman do not nack it.

	Sam

Re: [PATCH] m68k: fix recursive dependency in Kconfig

[Geert Uytterhoeven]

On Sun, 28 Dec 2008, Sam Ravnborg wrote:
> On Sun, Dec 28, 2008 at 08:12:27PM +0100, Geert Uytterhoeven wrote:
> > On Fri, 26 Dec 2008, Sam Ravnborg wrote:
> > > We had a recursive dependency between MMU_MOTOROLA and MMU_SUN3
> > > Fix it by dropping the unused dependencies on MMU_MOTOROLA.
> > > 
> > > MMU_MOTOROLA is set to y only using select so any dependencies
> > > are anyway ignored.
> > > 
> > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Cc: Roman Zippel <zippel@linux-m68k.org>
> > > ---
> > > 
> > > I hit this recursive dependency with a patched version
> > > of kconfig so you may not see it today.
> > > The fix is obvious - please apply.
> > 
> > Queued in for-next.
> > 
> > I guess you want this in Linus' tree for 2.6.29?
> 
> Yes please. I plan to submit the improved dependency check in my second
> kbuild update if Roman do not nack it.

As Linus just pulled from the m68k tree, it may take a while before I have
some more stuff ready. So please feel free to add it to the kbuild tree
before submitting the improved dependency check.

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks!

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] m68k: fix recursive dependency in Kconfig

[Sam Ravnborg]

On Mon, Dec 29, 2008 at 11:18:45AM +0100, Geert Uytterhoeven wrote:
> On Sun, 28 Dec 2008, Sam Ravnborg wrote:
> > On Sun, Dec 28, 2008 at 08:12:27PM +0100, Geert Uytterhoeven wrote:
> > > On Fri, 26 Dec 2008, Sam Ravnborg wrote:
> > > > We had a recursive dependency between MMU_MOTOROLA and MMU_SUN3
> > > > Fix it by dropping the unused dependencies on MMU_MOTOROLA.
> > > > 
> > > > MMU_MOTOROLA is set to y only using select so any dependencies
> > > > are anyway ignored.
> > > > 
> > > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > > > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > Cc: Roman Zippel <zippel@linux-m68k.org>
> > > > ---
> > > > 
> > > > I hit this recursive dependency with a patched version
> > > > of kconfig so you may not see it today.
> > > > The fix is obvious - please apply.
> > > 
> > > Queued in for-next.
> > > 
> > > I guess you want this in Linus' tree for 2.6.29?
> > 
> > Yes please. I plan to submit the improved dependency check in my second
> > kbuild update if Roman do not nack it.
> 
> As Linus just pulled from the m68k tree, it may take a while before I have
> some more stuff ready. So please feel free to add it to the kbuild tree
> before submitting the improved dependency check.
> 
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

OK - I added it to kbuild with your ack - thanks.

	Sam