public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: "David S. Miller" <davem@davemloft.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Roman Zippel <zippel@linux-m68k.org>,
	Greg Ungerer <gerg@uclinux.org>,
	linux-m68k@lists.linux-m68k
Cc: kosaki.motohiro@jp.fujitsu.com
Subject: [PATCH for 2.6.28 stable] m68knommu: fix m68knommu defconfig can't build
Date: Tue, 30 Dec 2008 19:44:20 +0900 (JST)	[thread overview]
Message-ID: <20081230193943.1281.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)


I guess nobody don't test m68knommu at all last three month.
Do we still need to maintain this architecture?


==
Currently, m68knommu defconfig can't build. it cause following error.

net/built-in.o: In function `skb_dma_map':
: undefined reference to `dma_mapping_error'
net/built-in.o: In function `skb_dma_unmap':
: undefined reference to `dma_unmap_single'
net/built-in.o: In function `skb_dma_unmap':
: undefined reference to `dma_unmap_page'
net/built-in.o: In function `skb_dma_map':
: undefined reference to `dma_map_single'
net/built-in.o: In function `skb_dma_map':
: undefined reference to `dma_map_page'
net/built-in.o: In function `skb_dma_map':
: undefined reference to `dma_unmap_page'
net/built-in.o: In function `skb_dma_map':
: undefined reference to `dma_unmap_single'

because
 - CONFIG_DMA depend on !NO_DMA
 - m68knommu always doesn't turn on NO_DMA
 - if CONFIG_PCI=n, m68knommu/include/asm/dma-magging.h include
    asm-generic/dma-mapping-broken.h
 - dma-mapping-broken.h generate link time error.
 - m68knommu defconfig doesn't have CONFIG_PCI
 - On the other hand, net/core/skb_dma_map.c assume CONFIG_DMA=y mean
   dma related function is callable

So, we want to turn on CONFIG_DMA if CONFIG_PCI=y only.


CC: David S. Miller <davem@davemloft.net>
CC: Geert Uytterhoeven <geert@linux-m68k.org>
CC: Roman Zippel <zippel@linux-m68k.org>
CC: Greg Ungerer <gerg@uclinux.org>
CC: linux-m68k@lists.linux-m68k.org
---
 arch/m68knommu/Kconfig |    3 +++
 1 file changed, 3 insertions(+)

Index: b/arch/m68knommu/Kconfig
===================================================================
--- a/arch/m68knommu/Kconfig	2008-12-25 08:26:37.000000000 +0900
+++ b/arch/m68knommu/Kconfig	2008-12-28 21:09:58.000000000 +0900
@@ -73,6 +73,9 @@ config GENERIC_CLOCKEVENTS
 config NO_IOPORT
 	def_bool y
 
+config NO_DMA
+	def_bool !PCI
+
 source "init/Kconfig"
 
 source "kernel/Kconfig.freezer"



             reply	other threads:[~2008-12-30 10:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-30 10:44 KOSAKI Motohiro [this message]
2008-10-06  6:20 ` [PATCH for 2.6.28 stable] m68knommu: fix m68knommu defconfig can't build Greg Ungerer
2009-01-12 10:35   ` KOSAKI Motohiro
2009-01-12 10:44   ` Paul Mundt
2009-01-12 10:59     ` Sam Ravnborg
     [not found]     ` <20090112105942.GA10936@uranus.ravnborg.org>
2009-01-12 11:07       ` Ingo Molnar
2009-01-12 11:12       ` Paul Mundt
2009-01-12 13:06     ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081230193943.1281.KOSAKI.MOTOHIRO@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=gerg@uclinux.org \
    --cc=linux-m68k@lists.linux-m68k \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox