Re: Falcon IDE breakage [patch]

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Sunday 18 January 2009, Michael Schmitz wrote:
> Hi,
> 
> > > your commit 5b31f855f10d0053e738baa6d91fb6a3fad35119 (introduction of IDE lock 
> > > helpers) breaks Atari Falcon IDE on the first request going out to the drive, if 
> > > I remove the request_irq() call from ide-probe.c (as it should be).
> > 
> > I assume this is on real hardware, as I didn't notice on ARAnyM?
> 
> Followup: never mind, I found out that this patch fixes the problem for me:
> (NB: still on ARAnyM, having two IDE drivers didn't matter, and I still have to 
> test the interaction of new IDE locking with SCSI)

I applied your patch, thanks.

> Any other side effects of IDE_HFLAG_SERIALIZE ??

Nope.

> (Actually I realize I could have stuck the flag in 
> falconide_port_info.host_flags instead - works just as well. Pick whatever suits 
> the IDE guys best)

OK, I made this fixup while merging the patch:

From: Michael Schmitz <schmitz@biophys.uni-duesseldorf.de>
Subject: ide: fix Falcon IDE breakage

[m68k] Falcon IDE: always serialize, in order to force execution of
       ide_get_lock() and friends.

Signed-off-By: Michael Schmitz <schmitz@debian.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
[bart: set flag in falconide_port_info instead of falconide_init()]
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/falconide.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/ide/falconide.c
===================================================================
--- a/drivers/ide/falconide.c
+++ b/drivers/ide/falconide.c
@@ -82,7 +82,7 @@ static const struct ide_tp_ops falconide
 
 static const struct ide_port_info falconide_port_info = {
 	.tp_ops			= &falconide_tp_ops,
-	.host_flags		= IDE_HFLAG_NO_DMA,
+	.host_flags		= IDE_HFLAG_NO_DMA | IDE_HFLAG_SERIALIZE,
 };
 
 static void __init falconide_setup_ports(hw_regs_t *hw)
\0