Re: [PATCH 1/3] m68k: section mismatch fixes: EtherNAT

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Sun, 18 Jan 2009, Michael Schmitz wrote:
> commit 9418e1ee384d69065c5251d310be97f431668ddb
> Author: Michael Schmitz <schmitz@xplor.waratah.dyndns.org>
> Date:   Fri Jan 2 08:04:23 2009 +0100
> 
>     [m68k] section mismatch fixes: add __init annotation
>     
>     Signed-off-by: Michael Schmitz <schmitz@debian.org>
> ---
> diff --git a/drivers/net/atari_91C111.c b/drivers/net/atari_91C111.c
> index c441779..4d4bf61 100644
> --- a/drivers/net/atari_91C111.c
> +++ b/drivers/net/atari_91C111.c
> @@ -2161,7 +2161,7 @@ static void smc_release_datacs(struct platform_device *pdev, struct net_device *
>   *	0 --> there is a device
>   *	anything else, error
>   */
> -static int smc_drv_probe(struct platform_device *pdev)
> +static int __init smc_drv_probe(struct platform_device *pdev)
              ^^^^^^
>  {
>  	struct smc91x_platdata *pd = pdev->dev.platform_data;
>  	struct smc_local *lp;

smc_drv_probe() should be marked __devinit, not __init.
And smc_drv_remove() should be marked __devexit.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds