From: Roland McGrath <roland@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-m68k@vger.kernel.org
Subject: Re: m68k ptrace code
Date: Sun, 10 May 2009 16:18:26 -0700 (PDT) [thread overview]
Message-ID: <20090510231826.930C5FC35D@magilla.sf.frob.com> (raw)
In-Reply-To: Andreas Schwab's message of Sunday, 10 May 2009 21:32:29 +0200 <m2zldk7nzm.fsf@igel.home>
Looks good to me, except you also want to nix PTRACE_KILL from your switch
so the generic code handles it. Same goes for {PEEK,POKE}{DATA,TEXT} too.
Also note that you have to define a PTRACE_SINGLEBLOCK value in
asm/ptrace.h (new request code in your ptrace syscall ABI) to make
user_enable_block_step() get used by anything.
Thanks,
Roland
next prev parent reply other threads:[~2009-05-10 23:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090427191230.GA1657@lst.de>
2009-04-27 19:14 ` m68k ptrace code Christoph Hellwig
2009-05-10 19:32 ` Andreas Schwab
2009-05-10 23:18 ` Roland McGrath [this message]
2009-05-11 9:32 ` Andreas Schwab
2009-08-05 15:27 ` Christoph Hellwig
2009-08-05 21:12 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090510231826.930C5FC35D@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=hch@lst.de \
--cc=linux-m68k@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox