From: Philippe De Muyter <phdm@macqel.be>
To: Greg Ungerer <gerg@snapgear.com>
Cc: uClinux development list <uclinux-dev@uclinux.org>,
linux-m68k@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>
Subject: Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3
Date: Wed, 20 Apr 2011 11:55:29 +0200 [thread overview]
Message-ID: <20110420095529.GC3296@frolo.macqel> (raw)
In-Reply-To: <4DAEA7F5.6080603@snapgear.com>
On Wed, Apr 20, 2011 at 07:31:33PM +1000, Greg Ungerer wrote:
> On 20/04/11 19:12, Philippe De Muyter wrote:
>> On Wed, Apr 20, 2011 at 10:55:15AM +0200, Geert Uytterhoeven wrote:
>>> On Wed, Apr 20, 2011 at 10:06, Sam Ravnborg<sam@ravnborg.org> wrote:
>>>> Hi Greg.
>>>>
>>>>> +
>>>>> +#if defined(__mc68020__) || defined(__mc68030__) || \
>>>>> + á ádefined(__mc68040__) || defined(__mc68060__)
(*)
>>>>
>>>> Why use these to decide if this is MMU or not?
>>>> This code is not exposed to user-space so we can rely on CONFIG_*
>>>> symbols.
>>>> IMO the CONIFG_* symbols is easier to read/maintain.
>>>
>>> Because technically it doesn't depend on having a MMU or not, but on
>>> having
>>> the full 32-bit multiplication instruction or not.
>>>
>>> Does Coldfire-with-MMU (for which we haven't integrated the support
>>> yet) have that
>>> instruction?
>>
>> Actually, MCF547x& MCF548x (CFv4e family) are integrated but without
(*)
>> their
>> limited MMU functionality.
>>
>> freescale had even written an mmu port for 2.6.25 but has not pushed it
>> upstream. This port can be found on their site or in the openwrt
>> repository.
>
> Part of my plan with the merge of m68k and m68knommu is to make
> it easy to support the v4e parts with MMU enabled. And certainly as
> I work through cleaning the individual files up I am doing it
> with this in mind. Of course most of the code to support the v4e
> is the same no matter if you have the MMU enabled or not.
>
> I have Freescales 2.6.25 kernel, but it is really only a reference
> point for this work.
>
>> MCF547x& MCF548x do not have that instruction.
(*)
>
> Thats right. I believe the processors listed in the patch are
> the only ones that currently support the 64bit mul.
The 68340 has it also. (And I have an old linux port for this processor)
I surmise the 68360 has it also.
Philippe
(*) Greg, there must be something with your mail installation : it garbles
the messages. (or is it mine, but I noticed that only with replies from you ?)
next prev parent reply other threads:[~2011-04-20 9:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 5:54 [PATCH v2 0/6] m68knommu: merge and clean up of arch/m68k/lib files gerg
2011-04-20 5:54 ` gerg
2011-04-20 5:54 ` [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3 gerg
2011-04-20 5:54 ` [PATCH v2 2/6] m68k: merge mmu and non-mmu versions of lib/Makefile gerg
2011-04-20 5:54 ` [PATCH v2 3/6] m68k: remove duplicate memmove() implementation gerg
2011-04-20 5:54 ` [PATCH v2 4/6] m68k: remove duplicate memset() implementation gerg
2011-04-20 5:54 ` [PATCH v2 5/6] m68k: remove duplicate memcpy() implementation gerg
2011-04-20 5:54 ` [PATCH v2 6/6] m68k: let Makefile sort out compiling mmu and non-mmu lib/checksum.c gerg
2011-04-20 8:06 ` [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3 Sam Ravnborg
2011-04-20 8:55 ` [uClinux-dev] " Geert Uytterhoeven
2011-04-20 9:12 ` Philippe De Muyter
2011-04-20 9:31 ` [uClinux-dev] " Greg Ungerer
2011-04-20 9:55 ` Philippe De Muyter [this message]
2011-04-20 10:18 ` Greg Ungerer
2011-04-20 10:38 ` Andreas Schwab
2011-04-20 10:38 ` Philippe De Muyter
2011-04-20 11:01 ` Greg Ungerer
2011-04-20 11:23 ` Philippe De Muyter
2011-04-20 8:57 ` Philippe De Muyter
2011-04-20 9:08 ` Greg Ungerer
2011-04-20 6:04 ` [PATCH v2 0/6] m68knommu: merge and clean up of arch/m68k/lib files Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420095529.GC3296@frolo.macqel \
--to=phdm@macqel.be \
--cc=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox