From: Greg Ungerer <gerg@snapgear.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: uClinux development list <uclinux-dev@uclinux.org>,
linux-m68k@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>
Subject: Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3
Date: Wed, 20 Apr 2011 19:08:28 +1000 [thread overview]
Message-ID: <4DAEA28C.7020909@snapgear.com> (raw)
In-Reply-To: <20110420080609.GA24244@merkur.ravnborg.org>
Hi Sam,
On 20/04/11 18:06, Sam Ravnborg wrote:
> Hi Greg.
>
>> +
>> +#if defined(__mc68020__) || defined(__mc68030__) || \
>> + defined(__mc68040__) || defined(__mc68060__)
>
> Why use these to decide if this is MMU or not?
The asm code that is enclosed by this is not about having an MMU
or not. It is about the processor supporting the 64bit mul
instruction.
> This code is not exposed to user-space so we can rely on CONFIG_* symbols.
> IMO the CONIFG_* symbols is easier to read/maintain.
In general yes I agree. But in this specific case it really
is about a code generation option (what type of processor
instructions we can emit).
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2011-04-20 9:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 5:54 [PATCH v2 0/6] m68knommu: merge and clean up of arch/m68k/lib files gerg
2011-04-20 5:54 ` gerg
2011-04-20 5:54 ` [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3 gerg
2011-04-20 5:54 ` [PATCH v2 2/6] m68k: merge mmu and non-mmu versions of lib/Makefile gerg
2011-04-20 5:54 ` [PATCH v2 3/6] m68k: remove duplicate memmove() implementation gerg
2011-04-20 5:54 ` [PATCH v2 4/6] m68k: remove duplicate memset() implementation gerg
2011-04-20 5:54 ` [PATCH v2 5/6] m68k: remove duplicate memcpy() implementation gerg
2011-04-20 5:54 ` [PATCH v2 6/6] m68k: let Makefile sort out compiling mmu and non-mmu lib/checksum.c gerg
2011-04-20 8:06 ` [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3 Sam Ravnborg
2011-04-20 8:55 ` [uClinux-dev] " Geert Uytterhoeven
2011-04-20 9:12 ` Philippe De Muyter
2011-04-20 9:31 ` [uClinux-dev] " Greg Ungerer
2011-04-20 9:55 ` Philippe De Muyter
2011-04-20 10:18 ` Greg Ungerer
2011-04-20 10:38 ` Andreas Schwab
2011-04-20 10:38 ` Philippe De Muyter
2011-04-20 11:01 ` Greg Ungerer
2011-04-20 11:23 ` Philippe De Muyter
2011-04-20 8:57 ` Philippe De Muyter
2011-04-20 9:08 ` Greg Ungerer [this message]
2011-04-20 6:04 ` [PATCH v2 0/6] m68knommu: merge and clean up of arch/m68k/lib files Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAEA28C.7020909@snapgear.com \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox