[PATCH] m68k/atari: SCC - Move Atari serial driver to staging

[PATCH] m68k/atari: SCC - Move Atari serial driver to staging

[Geert Uytterhoeven]

Cfr. commit 4c37705877e74c02c968735c2eee0f84914cf557 ("tty: move obsolete and
broken generic_serial drivers to drivers/staging/generic_serial/")

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/char/Makefile                              |    1 -
 drivers/staging/generic_serial/Makefile            |    1 +
 .../{char => staging/generic_serial}/atari_scc.c   |    0
 drivers/{char => staging/generic_serial}/scc.h     |    0
 4 files changed, 1 insertions(+), 1 deletions(-)
 rename drivers/{char => staging/generic_serial}/atari_scc.c (100%)
 rename drivers/{char => staging/generic_serial}/scc.h (100%)

diff --git a/drivers/char/Makefile b/drivers/char/Makefile
index e2b5ac5..057f654 100644
--- a/drivers/char/Makefile
+++ b/drivers/char/Makefile
@@ -5,7 +5,6 @@
 obj-y				+= mem.o random.o
 obj-$(CONFIG_TTY_PRINTK)	+= ttyprintk.o
 obj-y				+= misc.o
-obj-$(CONFIG_ATARI_SCC)		+= atari_scc.o generic_serial.o
 obj-$(CONFIG_ATARI_DSP56K)	+= dsp56k.o
 obj-$(CONFIG_VIRTIO_CONSOLE)	+= virtio_console.o
 obj-$(CONFIG_RAW_DRIVER)	+= raw.o
diff --git a/drivers/staging/generic_serial/Makefile b/drivers/staging/generic_serial/Makefile
index ffc90c8..c327828 100644
--- a/drivers/staging/generic_serial/Makefile
+++ b/drivers/staging/generic_serial/Makefile
@@ -4,3 +4,4 @@ obj-$(CONFIG_BVME6000_SCC)	+= generic_serial.o vme_scc.o
 obj-$(CONFIG_A2232)		+= ser_a2232.o generic_serial.o
 obj-$(CONFIG_SX)		+= sx.o generic_serial.o
 obj-$(CONFIG_RIO)		+= rio/ generic_serial.o
+obj-$(CONFIG_ATARI_SCC)		+= atari_scc.o generic_serial.o
diff --git a/drivers/char/atari_scc.c b/drivers/staging/generic_serial/atari_scc.c
similarity index 100%
rename from drivers/char/atari_scc.c
rename to drivers/staging/generic_serial/atari_scc.c
diff --git a/drivers/char/scc.h b/drivers/staging/generic_serial/scc.h
similarity index 100%
rename from drivers/char/scc.h
rename to drivers/staging/generic_serial/scc.h
-- 
1.7.0.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] m68k/atari: SCC - Move Atari serial driver to staging

[Geert Uytterhoeven]

On Sun, Mar 20, 2011 at 10:11, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Cfr. commit 4c37705877e74c02c968735c2eee0f84914cf557 ("tty: move obsolete and
> broken generic_serial drivers to drivers/staging/generic_serial/")

As generic serial is gone too, cfr. commit
bb2a97e9ccd525dd9c3326988e8c676d15d3e12a ("Staging: delete generic_serial
drivers"), I'll remove the atari_scc driver. It has to be resurrected as a new
preferred-type-of-serial-driver-of-the-day driver anyway.

You can still get its core logic from the eternal git history, though.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] m68k/atari: SCC - Move Atari serial driver to staging

[Michael Schmitz]

Hi Geert,

On Tue, Nov 1, 2011 at 7:58 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Sun, Mar 20, 2011 at 10:11, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> Cfr. commit 4c37705877e74c02c968735c2eee0f84914cf557 ("tty: move obsolete and
>> broken generic_serial drivers to drivers/staging/generic_serial/")
>
> As generic serial is gone too, cfr. commit
> bb2a97e9ccd525dd9c3326988e8c676d15d3e12a ("Staging: delete generic_serial
> drivers"), I'll remove the atari_scc driver. It has to be resurrected as a new
> preferred-type-of-serial-driver-of-the-day driver anyway.

Guess I've seen that coming... I had looked at other existing SCC
drivers in the tree and Sun, SGI and Mac all had variants of it with
different quirks. Enough to base a clean restart on. What is today's
preferred-type-of-serial-driver-of-the-day driver framework, if I may
ask?

> You can still get its core logic from the eternal git history, though.

I've still kept a copy around somewhere, no worries. Go ahead.

Cheers,

  Michael

Re: [PATCH] m68k/atari: SCC - Move Atari serial driver to staging

[Geert Uytterhoeven]

On Tue, Nov 1, 2011 at 21:03, Michael Schmitz <schmitzmic@googlemail.com> wrote:
> On Tue, Nov 1, 2011 at 7:58 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> On Sun, Mar 20, 2011 at 10:11, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>> Cfr. commit 4c37705877e74c02c968735c2eee0f84914cf557 ("tty: move obsolete and
>>> broken generic_serial drivers to drivers/staging/generic_serial/")
>>
>> As generic serial is gone too, cfr. commit
>> bb2a97e9ccd525dd9c3326988e8c676d15d3e12a ("Staging: delete generic_serial
>> drivers"), I'll remove the atari_scc driver. It has to be resurrected as a new
>> preferred-type-of-serial-driver-of-the-day driver anyway.
>
> Guess I've seen that coming... I had looked at other existing SCC
> drivers in the tree and Sun, SGI and Mac all had variants of it with
> different quirks. Enough to base a clean restart on. What is today's
> preferred-type-of-serial-driver-of-the-day driver framework, if I may
> ask?

Good question! Last year it was _not_ drivers/serial...

On Thu, Sep 2, 2010 at 22:12, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, Aug 30, 2010 at 15:00, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>> Please don't convert stuff to serial_core - it's got some horrible
>> problems with adapting to the new locking model, its buffering model
>> pre-dates kfifo and all in all serial_core needs a rewrite not more users.
>
> Funny... so "fortunately" we never found time to move the m68k serial drivers
> to driver/serial/? Long live procrastination ;-)

So let's ask the experts: what will be the preferred serial driver framework
in 2012?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] m68k/atari: SCC - Move Atari serial driver to staging

[Alan Cox]

> So let's ask the experts: what will be the preferred serial driver
> framework in 2012?

The tty_port code should now handle all the nasty horrible
open/close/hangup logic for you. The serial midlayer uses that and is
gradually shrinking into a buffering/locking helper. The goal was to
*not* create yet another mid layer but to provide helpers that mid
layer and driver code alike can use sensibly.

So either ought to work out.

Alan