From: Jonathan Nieder <jrnieder@gmail.com>
To: Thorsten Glaser <tg@mirbsd.de>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>,
Greg Ungerer <gerg@uclinux.org>,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org,
target-devel@vger.kernel.org
Subject: Re: [m68k] in modpost: "strlen" [iscsi_target_mod.ko] undefined! (and others)
Date: Sun, 1 Jan 2012 17:39:31 -0600 [thread overview]
Message-ID: <20120101233931.GA25837@elie.hsd1.il.comcast.net> (raw)
In-Reply-To: <Pine.BSM.4.64L.1201012310590.20109@herc.mirbsd.org>
Thorsten Glaser wrote[1]:
> Dixi quod…
>> So, please, compile the Linux kernel with -ffreestanding, too.
>
> Just to keep this bugreport in the loop: that fixes the FTBFS error.
Yep, sounds like a reasonable idea, though these calls to
"strncat(buf, str, strlen(str))" in the iscsi driver are still a
little insane. Could you suggest a patch to arch/m68k/Makefile to do
that?
Thanks,
Jonathan
[1] http://bugs.debian.org/648996
Background:
commit 6edfba1b33c7
Author: Andi Kleen <ak@suse.de>
Date: Sat Mar 25 16:29:49 2006 +0100
[PATCH] x86_64: Don't define string functions to builtin
gcc should handle this anyways, and it causes problems when
sprintf is turned into strcpy by gcc behind our backs and
the C fallback version of strcpy is actually defining __builtin_strcpy
Then drop -ffreestanding from the main Makefile because it isn't
needed anymore and implies -fno-builtin, which is wrong now.
(it was only added for x86-64, so dropping it should be safe)
next parent reply other threads:[~2012-01-01 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111116181424.14920.7730.reportbug@ara5.mirbsd.org>
[not found] ` <Pine.BSM.4.64L.1111301751500.12725@herc.mirbsd.org>
[not found] ` <CAMuHMdW8t8Q7OqxJM602iLG4aSv1KMTY-fhiGS7hyy8xBReh1A@mail.gmail.com>
[not found] ` <Pine.BSM.4.64L.1112181741430.856@herc.mirbsd.org>
[not found] ` <Pine.BSM.4.64L.1112181929380.856@herc.mirbsd.org>
[not found] ` <Pine.BSM.4.64L.1201012310590.20109@herc.mirbsd.org>
2012-01-01 23:39 ` Jonathan Nieder [this message]
2012-01-01 23:45 ` [m68k] in modpost: "strlen" [iscsi_target_mod.ko] undefined! (and others) Thorsten Glaser
2012-01-02 0:10 ` Jonathan Nieder
2012-01-02 0:19 ` Thorsten Glaser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120101233931.GA25837@elie.hsd1.il.comcast.net \
--to=jrnieder@gmail.com \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
--cc=tg@mirbsd.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox