* [fengguang.wu@intel.com: [pnfs:xfs-nfsd-clone] 57b7d25bf4c57ebe0fbd2d8c5b37edf503175e1f BUILD DONE]
@ 2016-02-18 13:32 Christoph Hellwig
2016-02-18 14:06 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2016-02-18 13:32 UTC (permalink / raw)
To: xfs; +Cc: Darrick J. Wong, linux-m68k
Looks like the structure size checker found it's first victim on m68k,
which doesn't seem to pad to 4 byte boundaries. I don't think it actually
matters in practice as we'll always the hacky appromiation of a variable
sized array behind it. I guess we should move this to a modern C99 VLA
and mark it as __packed?
----- Forwarded message from kbuild test robot <fengguang.wu@intel.com> -----
Date: Thu, 18 Feb 2016 21:26:23 +0800
From: kbuild test robot <fengguang.wu@intel.com>
Subject: [pnfs:xfs-nfsd-clone] 57b7d25bf4c57ebe0fbd2d8c5b37edf503175e1f
BUILD DONE
To: Christoph Hellwig <hch@lst.de>
git://git.infradead.org/users/hch/pnfs.git xfs-nfsd-clone
57b7d25bf4c57ebe0fbd2d8c5b37edf503175e1f nfs4: fix stateid handling for the NFS v4.2 operations
fs/xfs/xfs_ondisk.h:22:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
fs/xfs/xfs_ondisk.h:74:2: note: in expansion of macro 'XFS_CHECK_STRUCT_SIZE'
include/linux/compiler.h:502:38: error: call to '__compiletime_assert_74' declared with attribute error: XFS: sizeof(xfs_attr_leaf_name_remote_t) is wrong, expected 12
Error ids grouped by kconfigs:
recent_errors
├── m68k-multi_defconfig
│ ├── fs-xfs-xfs_ondisk.h:note:in-expansion-of-macro-BUILD_BUG_ON_MSG
│ ├── fs-xfs-xfs_ondisk.h:note:in-expansion-of-macro-XFS_CHECK_STRUCT_SIZE
│ └── include-linux-compiler.h:error:call-to-__compiletime_assert_NNN-declared-with-attribute-error:XFS:sizeof(xfs_attr_leaf_name_remote_t)-is-wrong-expected
└── m68k-sun3_defconfig
├── fs-xfs-xfs_ondisk.h:note:in-expansion-of-macro-BUILD_BUG_ON_MSG
├── fs-xfs-xfs_ondisk.h:note:in-expansion-of-macro-XFS_CHECK_STRUCT_SIZE
└── include-linux-compiler.h:error:call-to-__compiletime_assert_NNN-declared-with-attribute-error:XFS:sizeof(xfs_attr_leaf_name_remote_t)-is-wrong-expected
elapsed time: 66m
configs tested: 111
alpha defconfig
parisc allnoconfig
parisc c3000_defconfig
parisc defconfig
arm badge4_defconfig
arm cerfcube_defconfig
powerpc mpc834x_itxgp_defconfig
i386 randconfig-a0-201607
x86_64 acpi-redef
x86_64 allyesdebian
x86_64 nfsroot
blackfin BF526-EZBRD_defconfig
blackfin BF533-EZKIT_defconfig
blackfin BF561-EZKIT-SMP_defconfig
blackfin TCM-BF537_defconfig
cris etrax-100lx_v2_defconfig
sh allnoconfig
sh rsk7269_defconfig
sh sh7785lcr_32bit_defconfig
sh titan_defconfig
x86_64 allmodconfig
arm allnoconfig
arm at91_dt_defconfig
arm efm32_defconfig
arm exynos_defconfig
arm multi_v5_defconfig
arm multi_v7_defconfig
arm shmobile_defconfig
arm sunxi_defconfig
powerpc allnoconfig
powerpc defconfig
powerpc ppc64_defconfig
m32r m32104ut_defconfig
m32r mappi3.smp_defconfig
m32r opsput_defconfig
m32r usrv_defconfig
xtensa common_defconfig
xtensa iss_defconfig
parisc b180_defconfig
arm ebsa110_defconfig
arm h3600_defconfig
mips malta_qemu_32r6_defconfig
powerpc walnut_defconfig
x86_64 randconfig-x012-201607
x86_64 randconfig-x014-201607
x86_64 randconfig-x017-201607
x86_64 randconfig-x011-201607
x86_64 randconfig-x013-201607
x86_64 randconfig-x019-201607
x86_64 randconfig-x015-201607
x86_64 randconfig-x010-201607
x86_64 randconfig-x016-201607
x86_64 randconfig-x018-201607
i386 alldefconfig
i386 allnoconfig
i386 defconfig
i386 randconfig-s0-201607
i386 randconfig-s1-201607
avr32 atngw100_defconfig
avr32 atstk1006_defconfig
frv defconfig
mn10300 asb2364_defconfig
openrisc or1ksim_defconfig
tile tilegx_defconfig
um i386_defconfig
um x86_64_defconfig
i386 tinyconfig
x86_64 randconfig-i0-201607
microblaze mmu_defconfig
microblaze nommu_defconfig
i386 randconfig-i0-201607
i386 randconfig-i1-201607
sparc defconfig
sparc64 allnoconfig
sparc64 defconfig
x86_64 lkp
x86_64 rhel
x86_64 rhel+CONFIG_DEBUG_INFO_REDUCED
i386 randconfig-n0-201607
ia64 alldefconfig
ia64 allnoconfig
ia64 defconfig
m68k m5475evb_defconfig
m68k multi_defconfig
m68k sun3_defconfig
x86_64 randconfig-x004-201607
x86_64 randconfig-x002-201607
x86_64 randconfig-x000-201607
x86_64 randconfig-x009-201607
x86_64 randconfig-x006-201607
x86_64 randconfig-x003-201607
x86_64 randconfig-x005-201607
x86_64 randconfig-x001-201607
x86_64 randconfig-x007-201607
x86_64 randconfig-x008-201607
i386 randconfig-r0-201607
i386 allmodconfig
i386 randconfig-x001-201607
i386 randconfig-x007-201607
i386 randconfig-x004-201607
i386 randconfig-x002-201607
i386 randconfig-x008-201607
i386 randconfig-x003-201607
i386 randconfig-x006-201607
i386 randconfig-x005-201607
i386 randconfig-x009-201607
i386 randconfig-x000-201607
mips allnoconfig
mips fuloong2e_defconfig
mips jz4740
mips txx9
Thanks,
Fengguang
----- End forwarded message -----
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [fengguang.wu@intel.com: [pnfs:xfs-nfsd-clone] 57b7d25bf4c57ebe0fbd2d8c5b37edf503175e1f BUILD DONE]
2016-02-18 13:32 [fengguang.wu@intel.com: [pnfs:xfs-nfsd-clone] 57b7d25bf4c57ebe0fbd2d8c5b37edf503175e1f BUILD DONE] Christoph Hellwig
@ 2016-02-18 14:06 ` Geert Uytterhoeven
2016-02-22 9:05 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2016-02-18 14:06 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs, Darrick J. Wong, linux-m68k
Hi Christoph,
On Thu, Feb 18, 2016 at 2:32 PM, Christoph Hellwig <hch@lst.de> wrote:
> Looks like the structure size checker found it's first victim on m68k,
> which doesn't seem to pad to 4 byte boundaries. I don't think it actually
> matters in practice as we'll always the hacky appromiation of a variable
> sized array behind it. I guess we should move this to a modern C99 VLA
> and mark it as __packed?
Marking it __packed causes the compiler to assume that the other 32-bit
values may not be aligned.
You can add 2 padding bytes to struct xfs_attr_leaf_name_remote.
Or change name[1] to name[3].
> ----- Forwarded message from kbuild test robot <fengguang.wu@intel.com> -----
>
> Date: Thu, 18 Feb 2016 21:26:23 +0800
> From: kbuild test robot <fengguang.wu@intel.com>
> Subject: [pnfs:xfs-nfsd-clone] 57b7d25bf4c57ebe0fbd2d8c5b37edf503175e1f
> BUILD DONE
> To: Christoph Hellwig <hch@lst.de>
>
> git://git.infradead.org/users/hch/pnfs.git xfs-nfsd-clone
> 57b7d25bf4c57ebe0fbd2d8c5b37edf503175e1f nfs4: fix stateid handling for the NFS v4.2 operations
>
> fs/xfs/xfs_ondisk.h:22:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
> fs/xfs/xfs_ondisk.h:74:2: note: in expansion of macro 'XFS_CHECK_STRUCT_SIZE'
> include/linux/compiler.h:502:38: error: call to '__compiletime_assert_74' declared with attribute error: XFS: sizeof(xfs_attr_leaf_name_remote_t) is wrong, expected 12
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [fengguang.wu@intel.com: [pnfs:xfs-nfsd-clone] 57b7d25bf4c57ebe0fbd2d8c5b37edf503175e1f BUILD DONE]
2016-02-18 14:06 ` Geert Uytterhoeven
@ 2016-02-22 9:05 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2016-02-22 9:05 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Darrick J. Wong, linux-m68k
On Thu, Feb 18, 2016 at 03:06:14PM +0100, Geert Uytterhoeven wrote:
> Marking it __packed causes the compiler to assume that the other 32-bit
> values may not be aligned.
>
> You can add 2 padding bytes to struct xfs_attr_leaf_name_remote.
> Or change name[1] to name[3].
All not really exciting. Given that we never do a sizeof it might
make sense to simply not check the size of this structure as a band aid.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-22 9:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-18 13:32 [fengguang.wu@intel.com: [pnfs:xfs-nfsd-clone] 57b7d25bf4c57ebe0fbd2d8c5b37edf503175e1f BUILD DONE] Christoph Hellwig
2016-02-18 14:06 ` Geert Uytterhoeven
2016-02-22 9:05 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox