* Re: [PATCH 2/2] i2c: imx: remove id_table entry
[not found] ` <1603441103-17735-2-git-send-email-peng.fan@nxp.com>
@ 2020-10-23 15:28 ` Krzysztof Kozlowski
2020-10-24 7:47 ` Peng Fan
2020-10-26 23:53 ` Greg Ungerer
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-23 15:28 UTC (permalink / raw)
To: peng.fan
Cc: shawnguo, s.hauer, festevam, kernel, linux-imx, linux-i2c,
linux-arm-kernel, linux-kernel, Greg Ungerer, Geert Uytterhoeven,
linux-m68k, Angelo Dureghello
On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> The legacy platform device code has been removed under arch/arm/mach-imx,
> so we no need id_table entry here.
Cc: Greg, Geert, Angelo,
Aren't you breaking Coldfire platforms?
Best regards,
Krzysztof
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/i2c/busses/i2c-imx.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index ba9d639223ec..7ea36a78abb0 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = {
>
> };
>
> -static const struct platform_device_id imx_i2c_devtype[] = {
> - {
> - .name = "imx1-i2c",
> - .driver_data = (kernel_ulong_t)&imx1_i2c_hwdata,
> - }, {
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 2/2] i2c: imx: remove id_table entry
2020-10-23 15:28 ` [PATCH 2/2] i2c: imx: remove id_table entry Krzysztof Kozlowski
@ 2020-10-24 7:47 ` Peng Fan
2020-10-24 19:25 ` Krzysztof Kozlowski
2020-10-26 23:53 ` Greg Ungerer
1 sibling, 1 reply; 5+ messages in thread
From: Peng Fan @ 2020-10-24 7:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
kernel@pengutronix.de, dl-linux-imx, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Greg Ungerer, Geert Uytterhoeven,
linux-m68k@lists.linux-m68k.org, Angelo Dureghello
> Subject: Re: [PATCH 2/2] i2c: imx: remove id_table entry
>
> On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng.fan@nxp.com wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The legacy platform device code has been removed under
> > arch/arm/mach-imx, so we no need id_table entry here.
>
> Cc: Greg, Geert, Angelo,
>
> Aren't you breaking Coldfire platforms?
Ok, I see coldfire still use use imx1-i2c. Could we remove imx21-i2c or still
keep it?
Thanks
Peng.
>
> Best regards,
> Krzysztof
>
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > drivers/i2c/busses/i2c-imx.c | 14 --------------
> > 1 file changed, 14 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-imx.c
> > b/drivers/i2c/busses/i2c-imx.c index ba9d639223ec..7ea36a78abb0
> 100644
> > --- a/drivers/i2c/busses/i2c-imx.c
> > +++ b/drivers/i2c/busses/i2c-imx.c
> > @@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata =
> {
> >
> > };
> >
> > -static const struct platform_device_id imx_i2c_devtype[] = {
> > - {
> > - .name = "imx1-i2c",
> > - .driver_data = (kernel_ulong_t)&imx1_i2c_hwdata,
> > - }, {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] i2c: imx: remove id_table entry
2020-10-24 7:47 ` Peng Fan
@ 2020-10-24 19:25 ` Krzysztof Kozlowski
2020-10-26 1:41 ` Peng Fan
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-24 19:25 UTC (permalink / raw)
To: Peng Fan
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
kernel@pengutronix.de, dl-linux-imx, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Greg Ungerer, Geert Uytterhoeven,
linux-m68k@lists.linux-m68k.org, Angelo Dureghello
On Sat, Oct 24, 2020 at 07:47:13AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH 2/2] i2c: imx: remove id_table entry
> >
> > On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng.fan@nxp.com wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > The legacy platform device code has been removed under
> > > arch/arm/mach-imx, so we no need id_table entry here.
> >
> > Cc: Greg, Geert, Angelo,
> >
> > Aren't you breaking Coldfire platforms?
>
> Ok, I see coldfire still use use imx1-i2c. Could we remove imx21-i2c or still
> keep it?
Did you check if anything else uses it?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 2/2] i2c: imx: remove id_table entry
2020-10-24 19:25 ` Krzysztof Kozlowski
@ 2020-10-26 1:41 ` Peng Fan
0 siblings, 0 replies; 5+ messages in thread
From: Peng Fan @ 2020-10-26 1:41 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
kernel@pengutronix.de, dl-linux-imx, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Greg Ungerer, Geert Uytterhoeven,
linux-m68k@lists.linux-m68k.org, Angelo Dureghello
> Subject: Re: [PATCH 2/2] i2c: imx: remove id_table entry
>
> On Sat, Oct 24, 2020 at 07:47:13AM +0000, Peng Fan wrote:
> > > Subject: Re: [PATCH 2/2] i2c: imx: remove id_table entry
> > >
> > > On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng.fan@nxp.com wrote:
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > The legacy platform device code has been removed under
> > > > arch/arm/mach-imx, so we no need id_table entry here.
> > >
> > > Cc: Greg, Geert, Angelo,
> > >
> > > Aren't you breaking Coldfire platforms?
> >
> > Ok, I see coldfire still use use imx1-i2c. Could we remove imx21-i2c
> > or still keep it?
>
> Did you check if anything else uses it?
Not find anyone use imx21-i2c under arch/* except arch/arm/boot/*dtsi
Thanks,
Peng.
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] i2c: imx: remove id_table entry
2020-10-23 15:28 ` [PATCH 2/2] i2c: imx: remove id_table entry Krzysztof Kozlowski
2020-10-24 7:47 ` Peng Fan
@ 2020-10-26 23:53 ` Greg Ungerer
1 sibling, 0 replies; 5+ messages in thread
From: Greg Ungerer @ 2020-10-26 23:53 UTC (permalink / raw)
To: Krzysztof Kozlowski, peng.fan
Cc: shawnguo, s.hauer, festevam, kernel, linux-imx, linux-i2c,
linux-arm-kernel, linux-kernel, Geert Uytterhoeven, linux-m68k,
Angelo Dureghello
On 24/10/20 1:28 am, Krzysztof Kozlowski wrote:
> On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng.fan@nxp.com wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> The legacy platform device code has been removed under arch/arm/mach-imx,
>> so we no need id_table entry here.
>
> Cc: Greg, Geert, Angelo,
>
> Aren't you breaking Coldfire platforms?
Well spotted Krzysztof. It is used by quite a few of the ColdFire parts.
Regards
Greg
> Best regards,
> Krzysztof
>
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>> drivers/i2c/busses/i2c-imx.c | 14 --------------
>> 1 file changed, 14 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
>> index ba9d639223ec..7ea36a78abb0 100644
>> --- a/drivers/i2c/busses/i2c-imx.c
>> +++ b/drivers/i2c/busses/i2c-imx.c
>> @@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = {
>>
>> };
>>
>> -static const struct platform_device_id imx_i2c_devtype[] = {
>> - {
>> - .name = "imx1-i2c",
>> - .driver_data = (kernel_ulong_t)&imx1_i2c_hwdata,
>> - }, {
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-26 23:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1603441103-17735-1-git-send-email-peng.fan@nxp.com>
[not found] ` <1603441103-17735-2-git-send-email-peng.fan@nxp.com>
2020-10-23 15:28 ` [PATCH 2/2] i2c: imx: remove id_table entry Krzysztof Kozlowski
2020-10-24 7:47 ` Peng Fan
2020-10-24 19:25 ` Krzysztof Kozlowski
2020-10-26 1:41 ` Peng Fan
2020-10-26 23:53 ` Greg Ungerer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox