* [PATCH net-next 01/11] arch: use eth_hw_addr_set() [not found] <20211001213228.1735079-1-kuba@kernel.org> @ 2021-10-01 21:32 ` Jakub Kicinski 2021-10-01 22:59 ` Max Filippov 2021-10-02 9:19 ` Geert Uytterhoeven 0 siblings, 2 replies; 3+ messages in thread From: Jakub Kicinski @ 2021-10-01 21:32 UTC (permalink / raw) To: davem Cc: netdev, Jakub Kicinski, Geert Uytterhoeven, linux-m68k, Chris Zankel, Max Filippov, linux-xtensa Commit 406f42fa0d3c ("net-next: When a bond have a massive amount of VLANs...") introduced a rbtree for faster Ethernet address look up. To maintain netdev->dev_addr in this tree we need to make all the writes to it got through appropriate helpers. Convert misc arch drivers from memcpy(... ETH_ADDR) to eth_hw_addr_set(): @@ expression dev, np; @@ - memcpy(dev->dev_addr, np, ETH_ALEN) + eth_hw_addr_set(dev, np) Signed-off-by: Jakub Kicinski <kuba@kernel.org> -- CC: Geert Uytterhoeven <geert@linux-m68k.org> CC: linux-m68k@lists.linux-m68k.org CC: Chris Zankel <chris@zankel.net> CC: Max Filippov <jcmvbkbc@gmail.com> CC: linux-xtensa@linux-xtensa.org --- arch/m68k/emu/nfeth.c | 2 +- arch/xtensa/platforms/iss/network.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c index 79e55421cfb1..1a5d1e8eb4c8 100644 --- a/arch/m68k/emu/nfeth.c +++ b/arch/m68k/emu/nfeth.c @@ -200,7 +200,7 @@ static struct net_device * __init nfeth_probe(int unit) dev->irq = nfEtherIRQ; dev->netdev_ops = &nfeth_netdev_ops; - memcpy(dev->dev_addr, mac, ETH_ALEN); + eth_hw_addr_set(dev, mac); priv = netdev_priv(dev); priv->ethX = unit; diff --git a/arch/xtensa/platforms/iss/network.c b/arch/xtensa/platforms/iss/network.c index 4986226a5ab2..8b806d305948 100644 --- a/arch/xtensa/platforms/iss/network.c +++ b/arch/xtensa/platforms/iss/network.c @@ -467,7 +467,7 @@ static int iss_net_set_mac(struct net_device *dev, void *addr) if (!is_valid_ether_addr(hwaddr->sa_data)) return -EADDRNOTAVAIL; spin_lock_bh(&lp->lock); - memcpy(dev->dev_addr, hwaddr->sa_data, ETH_ALEN); + eth_hw_addr_set(dev, hwaddr->sa_data); spin_unlock_bh(&lp->lock); return 0; } -- 2.31.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 01/11] arch: use eth_hw_addr_set() 2021-10-01 21:32 ` [PATCH net-next 01/11] arch: use eth_hw_addr_set() Jakub Kicinski @ 2021-10-01 22:59 ` Max Filippov 2021-10-02 9:19 ` Geert Uytterhoeven 1 sibling, 0 replies; 3+ messages in thread From: Max Filippov @ 2021-10-01 22:59 UTC (permalink / raw) To: Jakub Kicinski Cc: David S. Miller, netdev, Geert Uytterhoeven, open list:M68K ARCHITECTURE, Chris Zankel, open list:TENSILICA XTENSA PORT (xtensa) On Fri, Oct 1, 2021 at 2:32 PM Jakub Kicinski <kuba@kernel.org> wrote: > > Commit 406f42fa0d3c ("net-next: When a bond have a massive amount > of VLANs...") introduced a rbtree for faster Ethernet address look > up. To maintain netdev->dev_addr in this tree we need to make all > the writes to it got through appropriate helpers. > > Convert misc arch drivers from memcpy(... ETH_ADDR) to eth_hw_addr_set(): > > @@ > expression dev, np; > @@ > - memcpy(dev->dev_addr, np, ETH_ALEN) > + eth_hw_addr_set(dev, np) > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > -- > CC: Geert Uytterhoeven <geert@linux-m68k.org> > CC: linux-m68k@lists.linux-m68k.org > CC: Chris Zankel <chris@zankel.net> > CC: Max Filippov <jcmvbkbc@gmail.com> > CC: linux-xtensa@linux-xtensa.org > --- > arch/m68k/emu/nfeth.c | 2 +- > arch/xtensa/platforms/iss/network.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) For xtensa: Acked-by: Max Filippov <jcmvbkbc@gmail.com> -- Thanks. -- Max ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 01/11] arch: use eth_hw_addr_set() 2021-10-01 21:32 ` [PATCH net-next 01/11] arch: use eth_hw_addr_set() Jakub Kicinski 2021-10-01 22:59 ` Max Filippov @ 2021-10-02 9:19 ` Geert Uytterhoeven 1 sibling, 0 replies; 3+ messages in thread From: Geert Uytterhoeven @ 2021-10-02 9:19 UTC (permalink / raw) To: Jakub Kicinski Cc: David S. Miller, netdev, linux-m68k, Chris Zankel, Max Filippov, open list:TENSILICA XTENSA PORT (xtensa) On Fri, Oct 1, 2021 at 11:32 PM Jakub Kicinski <kuba@kernel.org> wrote: > Commit 406f42fa0d3c ("net-next: When a bond have a massive amount > of VLANs...") introduced a rbtree for faster Ethernet address look > up. To maintain netdev->dev_addr in this tree we need to make all > the writes to it got through appropriate helpers. > > Convert misc arch drivers from memcpy(... ETH_ADDR) to eth_hw_addr_set(): > > @@ > expression dev, np; > @@ > - memcpy(dev->dev_addr, np, ETH_ALEN) > + eth_hw_addr_set(dev, np) > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > arch/m68k/emu/nfeth.c | 2 +- Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-02 9:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211001213228.1735079-1-kuba@kernel.org>
2021-10-01 21:32 ` [PATCH net-next 01/11] arch: use eth_hw_addr_set() Jakub Kicinski
2021-10-01 22:59 ` Max Filippov
2021-10-02 9:19 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox