[PATCH] m68k: mac_via: remove unused rbv_set_video_bpp()

[PATCH] m68k: mac_via: remove unused rbv_set_video_bpp()

[Jason A. Donenfeld]

In examining rbv_set_video_bpp()'s improper usage of a non-explictly
signed char type, it turns out that the function is actually unused. So
remove it.

Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 arch/m68k/include/asm/mac_via.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/m68k/include/asm/mac_via.h b/arch/m68k/include/asm/mac_via.h
index 1149251ea58d..a9ef1e9ba6c4 100644
--- a/arch/m68k/include/asm/mac_via.h
+++ b/arch/m68k/include/asm/mac_via.h
@@ -267,14 +267,6 @@ extern void via1_irq(struct irq_desc *desc);
 extern void via1_set_head(int);
 extern int via2_scsi_drq_pending(void);
 
-static inline int rbv_set_video_bpp(int bpp)
-{
-	char val = (bpp==1)?0:(bpp==2)?1:(bpp==4)?2:(bpp==8)?3:-1;
-	if (!rbv_present || val<0) return -1;
-	via2[rMonP] = (via2[rMonP] & ~RBV_DEPTH) | val;
-	return 0;
-}
-
 #endif /* __ASSEMBLY__ */
 
 #endif /* _ASM_MAC_VIA_H_ */
-- 
2.38.1

Re: [PATCH] m68k: mac_via: remove unused rbv_set_video_bpp()

[Geert Uytterhoeven]

On Wed, Oct 26, 2022 at 3:01 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> In examining rbv_set_video_bpp()'s improper usage of a non-explictly
> signed char type, it turns out that the function is actually unused. So
> remove it.
>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k for-v6.2 branch.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds