* [PATCH 5/7] arch: m68k: remove ReiserFS from defconfig
2023-09-18 17:56 [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig Peter Lafreniere
@ 2023-09-18 17:57 ` Peter Lafreniere
2023-09-19 7:19 ` Geert Uytterhoeven
2023-09-18 23:41 ` [PATCH 0/7] arch/*: config: Remove " Segher Boessenkool
2023-10-15 10:04 ` (subset) " Michael Ellerman
2 siblings, 1 reply; 13+ messages in thread
From: Peter Lafreniere @ 2023-09-18 17:57 UTC (permalink / raw)
To: linux-m68k; +Cc: Peter Lafreniere, jack, reiserfs-devel, linux-kernel, geert
ReiserFS has been deprecated for a year and a half, yet is still built
as part of a defconfig kernel.
According to commit eb103a51640e ("reiserfs: Deprecate reiserfs"), the
filesystem is slated to be removed in 2025. Remove it from the defconfig
profiles now, as part of its deprecation process.
Signed-off-by: Peter Lafreniere <peter@n8pjl.ca>
---
arch/m68k/configs/amiga_defconfig | 1 -
arch/m68k/configs/apollo_defconfig | 1 -
arch/m68k/configs/atari_defconfig | 1 -
arch/m68k/configs/bvme6000_defconfig | 1 -
arch/m68k/configs/hp300_defconfig | 1 -
arch/m68k/configs/mac_defconfig | 1 -
arch/m68k/configs/multi_defconfig | 1 -
arch/m68k/configs/mvme147_defconfig | 1 -
arch/m68k/configs/mvme16x_defconfig | 1 -
arch/m68k/configs/q40_defconfig | 1 -
arch/m68k/configs/sun3_defconfig | 1 -
arch/m68k/configs/sun3x_defconfig | 1 -
12 files changed, 12 deletions(-)
diff --git a/arch/m68k/configs/amiga_defconfig b/arch/m68k/configs/amiga_defconfig
index 6deb8faa564b..f89f57aedeed 100644
--- a/arch/m68k/configs/amiga_defconfig
+++ b/arch/m68k/configs/amiga_defconfig
@@ -448,7 +448,6 @@ CONFIG_RTC_DRV_RP5C01=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
diff --git a/arch/m68k/configs/apollo_defconfig b/arch/m68k/configs/apollo_defconfig
index 802c161827f4..ac18b21d4bf1 100644
--- a/arch/m68k/configs/apollo_defconfig
+++ b/arch/m68k/configs/apollo_defconfig
@@ -405,7 +405,6 @@ CONFIG_RTC_DRV_GENERIC=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
diff --git a/arch/m68k/configs/atari_defconfig b/arch/m68k/configs/atari_defconfig
index 2cb3d755873b..7cb3b643e57c 100644
--- a/arch/m68k/configs/atari_defconfig
+++ b/arch/m68k/configs/atari_defconfig
@@ -425,7 +425,6 @@ CONFIG_RTC_DRV_GENERIC=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
diff --git a/arch/m68k/configs/bvme6000_defconfig b/arch/m68k/configs/bvme6000_defconfig
index b13552caa6b3..359c51562db2 100644
--- a/arch/m68k/configs/bvme6000_defconfig
+++ b/arch/m68k/configs/bvme6000_defconfig
@@ -397,7 +397,6 @@ CONFIG_RTC_DRV_GENERIC=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
diff --git a/arch/m68k/configs/hp300_defconfig b/arch/m68k/configs/hp300_defconfig
index f88356c45440..41eb91c33eae 100644
--- a/arch/m68k/configs/hp300_defconfig
+++ b/arch/m68k/configs/hp300_defconfig
@@ -407,7 +407,6 @@ CONFIG_RTC_DRV_GENERIC=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
diff --git a/arch/m68k/configs/mac_defconfig b/arch/m68k/configs/mac_defconfig
index 7c2ebb616fba..cf384a98323f 100644
--- a/arch/m68k/configs/mac_defconfig
+++ b/arch/m68k/configs/mac_defconfig
@@ -427,7 +427,6 @@ CONFIG_RTC_DRV_GENERIC=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
diff --git a/arch/m68k/configs/multi_defconfig b/arch/m68k/configs/multi_defconfig
index d3b272910b38..7472b6d949fa 100644
--- a/arch/m68k/configs/multi_defconfig
+++ b/arch/m68k/configs/multi_defconfig
@@ -513,7 +513,6 @@ CONFIG_RTC_DRV_GENERIC=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
diff --git a/arch/m68k/configs/mvme147_defconfig b/arch/m68k/configs/mvme147_defconfig
index 4529bc4b843c..064a5906e8a6 100644
--- a/arch/m68k/configs/mvme147_defconfig
+++ b/arch/m68k/configs/mvme147_defconfig
@@ -396,7 +396,6 @@ CONFIG_RTC_DRV_GENERIC=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
diff --git a/arch/m68k/configs/mvme16x_defconfig b/arch/m68k/configs/mvme16x_defconfig
index 30824032e4d5..6ff79eae70ed 100644
--- a/arch/m68k/configs/mvme16x_defconfig
+++ b/arch/m68k/configs/mvme16x_defconfig
@@ -397,7 +397,6 @@ CONFIG_RTC_DRV_GENERIC=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
diff --git a/arch/m68k/configs/q40_defconfig b/arch/m68k/configs/q40_defconfig
index 3911211410ed..922804e0e2cd 100644
--- a/arch/m68k/configs/q40_defconfig
+++ b/arch/m68k/configs/q40_defconfig
@@ -414,7 +414,6 @@ CONFIG_RTC_DRV_GENERIC=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
diff --git a/arch/m68k/configs/sun3_defconfig b/arch/m68k/configs/sun3_defconfig
index 991730c50957..3583ac7c8986 100644
--- a/arch/m68k/configs/sun3_defconfig
+++ b/arch/m68k/configs/sun3_defconfig
@@ -395,7 +395,6 @@ CONFIG_RTC_DRV_GENERIC=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
diff --git a/arch/m68k/configs/sun3x_defconfig b/arch/m68k/configs/sun3x_defconfig
index e80d7509ab1d..a6df5013f915 100644
--- a/arch/m68k/configs/sun3x_defconfig
+++ b/arch/m68k/configs/sun3x_defconfig
@@ -395,7 +395,6 @@ CONFIG_RTC_DRV_GENERIC=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_DAX=m
CONFIG_EXT4_FS=y
-CONFIG_REISERFS_FS=m
CONFIG_JFS_FS=m
CONFIG_OCFS2_FS=m
# CONFIG_OCFS2_DEBUG_MASKLOG is not set
--
2.42.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 5/7] arch: m68k: remove ReiserFS from defconfig
2023-09-18 17:57 ` [PATCH 5/7] arch: m68k: remove " Peter Lafreniere
@ 2023-09-19 7:19 ` Geert Uytterhoeven
2023-09-19 13:32 ` Peter Lafreniere
0 siblings, 1 reply; 13+ messages in thread
From: Geert Uytterhoeven @ 2023-09-19 7:19 UTC (permalink / raw)
To: Peter Lafreniere; +Cc: linux-m68k, jack, reiserfs-devel, linux-kernel
Hi Peter,
On Mon, Sep 18, 2023 at 7:57 PM Peter Lafreniere <peter@n8pjl.ca> wrote:
> ReiserFS has been deprecated for a year and a half, yet is still built
> as part of a defconfig kernel.
>
> According to commit eb103a51640e ("reiserfs: Deprecate reiserfs"), the
> filesystem is slated to be removed in 2025. Remove it from the defconfig
> profiles now, as part of its deprecation process.
>
> Signed-off-by: Peter Lafreniere <peter@n8pjl.ca>
Thanks for your patch!
Given these defconfigs enable ReiserFS as a module (not built-in),
and that ReiserFS is still available upstream, and enabled by distros
like Debian, I would like to keep it that way.
The m68k defconfigs will be updated after the removal of ReiserFS,
as part of the regular defconfig resync.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 5/7] arch: m68k: remove ReiserFS from defconfig
2023-09-19 7:19 ` Geert Uytterhoeven
@ 2023-09-19 13:32 ` Peter Lafreniere
0 siblings, 0 replies; 13+ messages in thread
From: Peter Lafreniere @ 2023-09-19 13:32 UTC (permalink / raw)
To: geert; +Cc: jack, linux-kernel, linux-m68k, peter, reiserfs-devel
On Mon, Sep 19, 2023 at 03:19, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Peter,
>
> On Mon, Sep 18, 2023 at 7:57 PM Peter Lafreniere peter@n8pjl.ca wrote:
>
> > ReiserFS has been deprecated for a year and a half, yet is still built
> > as part of a defconfig kernel.
> >
> > According to commit eb103a51640e ("reiserfs: Deprecate reiserfs"), the
> > filesystem is slated to be removed in 2025. Remove it from the defconfig
> > profiles now, as part of its deprecation process.
> >
> > Signed-off-by: Peter Lafreniere peter@n8pjl.ca
>
>
> Thanks for your patch!
>
> Given these defconfigs enable ReiserFS as a module (not built-in),
> and that ReiserFS is still available upstream, and enabled by distros
> like Debian, I would like to keep it that way.
> The m68k defconfigs will be updated after the removal of ReiserFS,
> as part of the regular defconfig resync.
I still think that since ReiserFS is being removed soon enough and that there
are a negligible number of users, it should be left out of defconfig builds.
allmodconfig and custom configs (like Debian's) exist for a reason.
But yours is a reasonable approach anyhow. Especially for an arch that is in
the same position as some of the more exotic filesystems that you build as
modules. Thanks for taking a look.
Cheers,
Peter Lafreniere
<peter@n8pjl.ca>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig
2023-09-18 17:56 [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig Peter Lafreniere
2023-09-18 17:57 ` [PATCH 5/7] arch: m68k: remove " Peter Lafreniere
@ 2023-09-18 23:41 ` Segher Boessenkool
2023-09-19 0:00 ` Peter Lafreniere
2023-10-15 10:04 ` (subset) " Michael Ellerman
2 siblings, 1 reply; 13+ messages in thread
From: Segher Boessenkool @ 2023-09-18 23:41 UTC (permalink / raw)
To: Peter Lafreniere
Cc: reiserfs-devel, tsbogend, jack, linux-sh, ink, richard, linux-um,
linux-kernel, linux-mips, linux-m68k, geert, linux-alpha, linux,
johannes, richard.henderson, linuxppc-dev, linux-arm-kernel,
anton.ivanov
On Mon, Sep 18, 2023 at 05:56:09PM +0000, Peter Lafreniere wrote:
> ReiserFS has been considered deprecated for 19 months since commit
> eb103a51640e ("reiserfs: Deprecate reiserfs"). However, there are
> several architectures that still build it into their defconfig kernels.
>
> As ReiserFS will be removed in 2025, delete all ReiserFS-related options
> from defconfig files before the filesystem's removal.
This is essentially equivalent to deleting the filesystem now. Why do
this? Is there such a hurry?
Segher
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig
2023-09-18 23:41 ` [PATCH 0/7] arch/*: config: Remove " Segher Boessenkool
@ 2023-09-19 0:00 ` Peter Lafreniere
2023-09-19 15:16 ` Segher Boessenkool
0 siblings, 1 reply; 13+ messages in thread
From: Peter Lafreniere @ 2023-09-19 0:00 UTC (permalink / raw)
To: segher
Cc: anton.ivanov, geert, ink, jack, johannes, linux-alpha,
linux-arm-kernel, linux-kernel, linux-m68k, linux-mips, linux-sh,
linux-um, linux, linuxppc-dev, peter, reiserfs-devel,
richard.henderson, richard, tsbogend
On Monday, September 18th, 2023 at 19:41, Segher Boessenkool <segher@kernel.crashing.org> wrote:
> On Mon, Sep 18, 2023 at 05:56:09PM +0000, Peter Lafreniere wrote:
>
> > ReiserFS has been considered deprecated for 19 months since commit
> > eb103a51640e ("reiserfs: Deprecate reiserfs"). However, there are
> > several architectures that still build it into their defconfig kernels.
> >
> > As ReiserFS will be removed in 2025, delete all ReiserFS-related options
> > from defconfig files before the filesystem's removal.
>
>
> This is essentially equivalent to deleting the filesystem now. Why do
> this? Is there such a hurry?
This is not equivalent to deleting the filesystem. The filesystem can still
be configured into kernels, and few distros use a defconfig kernel anyway.
>
>
> Segher
Cheers,
Peter Lafreniere
<peter@n8pjl.ca>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig
2023-09-19 0:00 ` Peter Lafreniere
@ 2023-09-19 15:16 ` Segher Boessenkool
2023-09-19 15:58 ` Peter Lafreniere
0 siblings, 1 reply; 13+ messages in thread
From: Segher Boessenkool @ 2023-09-19 15:16 UTC (permalink / raw)
To: Peter Lafreniere
Cc: anton.ivanov, geert, ink, jack, johannes, linux-alpha,
linux-arm-kernel, linux-kernel, linux-m68k, linux-mips, linux-sh,
linux-um, linux, linuxppc-dev, reiserfs-devel, richard.henderson,
richard, tsbogend
On Tue, Sep 19, 2023 at 12:00:34AM +0000, Peter Lafreniere wrote:
> On Monday, September 18th, 2023 at 19:41, Segher Boessenkool <segher@kernel.crashing.org> wrote:
> > On Mon, Sep 18, 2023 at 05:56:09PM +0000, Peter Lafreniere wrote:
> >
> > > ReiserFS has been considered deprecated for 19 months since commit
> > > eb103a51640e ("reiserfs: Deprecate reiserfs"). However, there are
> > > several architectures that still build it into their defconfig kernels.
> > >
> > > As ReiserFS will be removed in 2025, delete all ReiserFS-related options
> > > from defconfig files before the filesystem's removal.
> >
> >
> > This is essentially equivalent to deleting the filesystem now. Why do
> > this? Is there such a hurry?
>
> This is not equivalent to deleting the filesystem. The filesystem can still
> be configured into kernels, and few distros use a defconfig kernel anyway.
Most people who compile kernels use defconfigs though. Distros are a
tiny minority if you look at builds.
Again: why do you want this?
Segher
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig
2023-09-19 15:16 ` Segher Boessenkool
@ 2023-09-19 15:58 ` Peter Lafreniere
2023-09-19 16:02 ` Geert Uytterhoeven
0 siblings, 1 reply; 13+ messages in thread
From: Peter Lafreniere @ 2023-09-19 15:58 UTC (permalink / raw)
To: segher
Cc: anton.ivanov, geert, ink, jack, johannes, linux-alpha,
linux-arm-kernel, linux-kernel, linux-m68k, linux-mips, linux-sh,
linux-um, linux, linuxppc-dev, peter, reiserfs-devel,
richard.henderson, richard, tsbogend
On Tue, Sep 19, 2023 at 11:16, Segher Boessenkool wrote:
>
> On Tue, Sep 19, 2023 at 12:00:34AM +0000, Peter Lafreniere wrote:
>
> > On Monday, September 18th, 2023 at 19:41, Segher Boessenkool segher@kernel.crashing.org wrote:
> >
> > > On Mon, Sep 18, 2023 at 05:56:09PM +0000, Peter Lafreniere wrote:
> > >
> > > > ReiserFS has been considered deprecated for 19 months since commit
> > > > eb103a51640e ("reiserfs: Deprecate reiserfs"). However, there are
> > > > several architectures that still build it into their defconfig kernels.
> > > >
> > > > As ReiserFS will be removed in 2025, delete all ReiserFS-related options
> > > > from defconfig files before the filesystem's removal.
> > >
> > > This is essentially equivalent to deleting the filesystem now. Why do
> > > this? Is there such a hurry?
> >
> > This is not equivalent to deleting the filesystem. The filesystem can still
> > be configured into kernels, and few distros use a defconfig kernel anyway.
>
>
> Most people who compile kernels use defconfigs though. Distros are a
> tiny minority if you look at builds.
>
> Again: why do you want this?
>
Because the filesystem is deprecated and rarely used. Those who do use ReiserFS
should migrate away from it or get ready to stop upgrading their kernels soon.
This removal from defconfig:
1) Serves as a reminder to those that use the fs that they should take the
above actions, but with the filesystem staying available should they need
it.
2) Stops building an obsolete and largely-unused filesystem unnecessarily.
Some hobbyist targets like m68k and alpha may prefer to keep all filesystems
available until total removal, but others like arm and UML have no need for
ReiserFS to be built unless specifically configured.
3) Arguably simplifies the removal of the filesystem when that takes place.
This point is admittedly quite weak.
4) Has to happen someday, unless someone steps up and volunteers to maintain
the fs. I don't find it worthwhile, but you can if you'd like. Perhaps work
towards removal will cause a user to step forward and keep their beloved
filesystem around?
5) Doesn't actually remove support for the filesystem whatsoever. I can't
emphasize this enough: users who build their own kernel and maintain a
niche filesystem like ReiserFS should know how to flip a Kconfig switch.
>
> Segher
Cheers,
Peter
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig
2023-09-19 15:58 ` Peter Lafreniere
@ 2023-09-19 16:02 ` Geert Uytterhoeven
2023-09-19 16:15 ` Peter Lafreniere
2023-09-20 16:56 ` Jan Kara
0 siblings, 2 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2023-09-19 16:02 UTC (permalink / raw)
To: Peter Lafreniere
Cc: segher, anton.ivanov, ink, jack, johannes, linux-alpha,
linux-arm-kernel, linux-kernel, linux-m68k, linux-mips, linux-sh,
linux-um, linux, linuxppc-dev, reiserfs-devel, richard.henderson,
richard, tsbogend
Hi Peter,
On Tue, Sep 19, 2023 at 5:58 PM Peter Lafreniere <peter@n8pjl.ca> wrote:
> 2) Stops building an obsolete and largely-unused filesystem unnecessarily.
> Some hobbyist targets like m68k and alpha may prefer to keep all filesystems
> available until total removal, but others like arm and UML have no need for
> ReiserFS to be built unless specifically configured.
As UML is used a lot for testing, isn't it actually counter-productive
to remove ReiserFS from the UML defconfig? The less testing it
receives, the higher the chance of introducing regressions.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig
2023-09-19 16:02 ` Geert Uytterhoeven
@ 2023-09-19 16:15 ` Peter Lafreniere
2023-09-20 9:30 ` Geert Uytterhoeven
2023-09-20 16:56 ` Jan Kara
1 sibling, 1 reply; 13+ messages in thread
From: Peter Lafreniere @ 2023-09-19 16:15 UTC (permalink / raw)
To: geert
Cc: anton.ivanov, ink, jack, johannes, linux-alpha, linux-arm-kernel,
linux-kernel, linux-m68k, linux-mips, linux-sh, linux-um, linux,
linuxppc-dev, peter, reiserfs-devel, richard.henderson, richard,
segher, tsbogend
Hi Geert,
On Tue, Sep 19, 2023 at 12:02, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Peter,
>
> On Tue, Sep 19, 2023 at 5:58 PM Peter Lafreniere peter@n8pjl.ca wrote:
>
> > 2) Stops building an obsolete and largely-unused filesystem unnecessarily.
> > Some hobbyist targets like m68k and alpha may prefer to keep all filesystems
> > available until total removal, but others like arm and UML have no need for
> > ReiserFS to be built unless specifically configured.
>
>
> As UML is used a lot for testing, isn't it actually counter-productive
> to remove ReiserFS from the UML defconfig? The less testing it
> receives, the higher the chance of introducing regressions.
UML is used for testing, but in my view that makes the inclusion of
ReiserFS in its defconfig even worse. Users of UML are trying to test a
particular function, and so tend to use ext[2-4], as those are included in
the defconfig and are well tested and stable. So there is no extra testing
being done on ReiserFS due to its inclusion in the defconfig.
Keeping UML's defconfig as slim as possible improves build times, which is
particularly important for kernel testing and development.
>
> Gr{oetje,eeting}s,
>
> Geert
>
Cheers,
Peter Lafreniere
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig
2023-09-19 16:15 ` Peter Lafreniere
@ 2023-09-20 9:30 ` Geert Uytterhoeven
0 siblings, 0 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2023-09-20 9:30 UTC (permalink / raw)
To: Peter Lafreniere
Cc: anton.ivanov, ink, jack, johannes, linux-alpha, linux-arm-kernel,
linux-kernel, linux-m68k, linux-mips, linux-sh, linux-um, linux,
linuxppc-dev, reiserfs-devel, richard.henderson, richard, segher,
tsbogend
Hi Peter,
On Tue, Sep 19, 2023 at 6:16 PM Peter Lafreniere <peter@n8pjl.ca> wrote:
> On Tue, Sep 19, 2023 at 12:02, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Tue, Sep 19, 2023 at 5:58 PM Peter Lafreniere peter@n8pjl.ca wrote:
> > > 2) Stops building an obsolete and largely-unused filesystem unnecessarily.
> > > Some hobbyist targets like m68k and alpha may prefer to keep all filesystems
> > > available until total removal, but others like arm and UML have no need for
> > > ReiserFS to be built unless specifically configured.
> >
> >
> > As UML is used a lot for testing, isn't it actually counter-productive
> > to remove ReiserFS from the UML defconfig? The less testing it
> > receives, the higher the chance of introducing regressions.
>
> UML is used for testing, but in my view that makes the inclusion of
> ReiserFS in its defconfig even worse. Users of UML are trying to test a
Why?
Because you want to avoid doing any testing at all on deprecated features?
> particular function, and so tend to use ext[2-4], as those are included in
> the defconfig and are well tested and stable. So there is no extra testing
> being done on ReiserFS due to its inclusion in the defconfig.
I'd expect global file system testers to use something along the line of:
for i in $(grep -v nodev /proc/filesystems ); do
echo --- Testing $i ---
dd if=/dev/zero of=testimage bs=1M count=1 seek=10000
mkfs.$i testimage
mount testimage /mnt -t $i
[run xfstests on testimage]
rm -f testimage
done
> Keeping UML's defconfig as slim as possible improves build times, which is
> particularly important for kernel testing and development.
Good luck testing all functionality using a "slim" kernel ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig
2023-09-19 16:02 ` Geert Uytterhoeven
2023-09-19 16:15 ` Peter Lafreniere
@ 2023-09-20 16:56 ` Jan Kara
1 sibling, 0 replies; 13+ messages in thread
From: Jan Kara @ 2023-09-20 16:56 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Peter Lafreniere, segher, anton.ivanov, ink, jack, johannes,
linux-alpha, linux-arm-kernel, linux-kernel, linux-m68k,
linux-mips, linux-sh, linux-um, linux, linuxppc-dev,
reiserfs-devel, richard.henderson, richard, tsbogend
On Tue 19-09-23 18:02:39, Geert Uytterhoeven wrote:
> Hi Peter,
>
> On Tue, Sep 19, 2023 at 5:58 PM Peter Lafreniere <peter@n8pjl.ca> wrote:
> > 2) Stops building an obsolete and largely-unused filesystem unnecessarily.
> > Some hobbyist targets like m68k and alpha may prefer to keep all filesystems
> > available until total removal, but others like arm and UML have no need for
> > ReiserFS to be built unless specifically configured.
>
> As UML is used a lot for testing, isn't it actually counter-productive
> to remove ReiserFS from the UML defconfig? The less testing it
> receives, the higher the chance of introducing regressions.
The only testing I know about for reiserfs (besides build testing) is
syzbot. And regarding the people / bots doing filesystem testing I know
none of them uses UML. Rather it is x86 VMs these days where reiserfs is
disabled in the defconfig for a *long* time (many years). Also when you do
filesystem testing, you usually just test the few filesystems you care
about and for which you have all the tools installed. So frankly I don't
see a good reason to leave reiserfs enabled in defconfigs. But sure if
m68k or other arch wants to keep reiserfs in it's defconfig for some
consistency reasons, I'm fine with it. I just suspect that for most archs
this is just a historical reason.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: (subset) [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig
2023-09-18 17:56 [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig Peter Lafreniere
2023-09-18 17:57 ` [PATCH 5/7] arch: m68k: remove " Peter Lafreniere
2023-09-18 23:41 ` [PATCH 0/7] arch/*: config: Remove " Segher Boessenkool
@ 2023-10-15 10:04 ` Michael Ellerman
2 siblings, 0 replies; 13+ messages in thread
From: Michael Ellerman @ 2023-10-15 10:04 UTC (permalink / raw)
To: reiserfs-devel, Peter Lafreniere
Cc: jack, linux-kernel, richard, anton.ivanov, johannes, linuxppc-dev,
linux-um, linux-sh, tsbogend, linux-mips, linux-m68k, geert,
linux-arm-kernel, linux, linux-alpha, richard.henderson, ink
On Mon, 18 Sep 2023 17:56:09 +0000, Peter Lafreniere wrote:
> ReiserFS has been considered deprecated for 19 months since commit
> eb103a51640e ("reiserfs: Deprecate reiserfs"). However, there are
> several architectures that still build it into their defconfig kernels.
>
> As ReiserFS will be removed in 2025, delete all ReiserFS-related options
> from defconfig files before the filesystem's removal.
>
> [...]
Applied to powerpc/next.
[2/7] arch: powerpc: remove ReiserFS from defconfig
https://git.kernel.org/powerpc/c/c945e6f453a361b0e9daddd2be9c099d1b80d6f8
cheers
^ permalink raw reply [flat|nested] 13+ messages in thread