public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux.dev
Cc: Robin Murphy <robin.murphy@arm.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
	Clark Wang <xiaoning.wang@nxp.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-m68k@lists.linux-m68k.org, netdev@vger.kernel.org,
	Jim Quinlan <james.quinlan@broadcom.com>
Subject: [PATCH 6/6] m68k: don't provide arch_dma_alloc for nommu/coldfire
Date: Mon,  9 Oct 2023 09:41:21 +0200	[thread overview]
Message-ID: <20231009074121.219686-7-hch@lst.de> (raw)
In-Reply-To: <20231009074121.219686-1-hch@lst.de>

m68knommu and coldfire can't provide coherent DMA allocations at all.
Currently they simply return normal kernel memory from
dma_alloc_coherent, which is broken and breaks the API contract.  Now
that the only DMA capable driver on these systems has been switched
to use explicitly non-coherent allocations we can drop this hack and
return NULL from dma_alloc_coherent.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/m68k/Kconfig      |  1 -
 arch/m68k/kernel/dma.c | 23 -----------------------
 2 files changed, 24 deletions(-)

diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
index 0430b8ba6b5cc6..3e318bf9504c5b 100644
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -3,7 +3,6 @@ config M68K
 	bool
 	default y
 	select ARCH_32BIT_OFF_T
-	select ARCH_DMA_ALLOC if !MMU || COLDFIRE
 	select ARCH_HAS_BINFMT_FLAT
 	select ARCH_HAS_CPU_FINALIZE_INIT if MMU
 	select ARCH_HAS_CURRENT_STACK_POINTER
diff --git a/arch/m68k/kernel/dma.c b/arch/m68k/kernel/dma.c
index 2e192a5df949bb..eb164ef1a45ebd 100644
--- a/arch/m68k/kernel/dma.c
+++ b/arch/m68k/kernel/dma.c
@@ -33,29 +33,6 @@ pgprot_t pgprot_dmacoherent(pgprot_t prot)
 	}
 	return prot;
 }
-#else
-void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle,
-		gfp_t gfp, unsigned long attrs)
-{
-	void *ret;
-
-	if (dev == NULL || (*dev->dma_mask < 0xffffffff))
-		gfp |= GFP_DMA;
-	ret = (void *)__get_free_pages(gfp, get_order(size));
-
-	if (ret != NULL) {
-		memset(ret, 0, size);
-		*dma_handle = virt_to_phys(ret);
-	}
-	return ret;
-}
-
-void arch_dma_free(struct device *dev, size_t size, void *vaddr,
-		dma_addr_t dma_handle, unsigned long attrs)
-{
-	free_pages((unsigned long)vaddr, get_order(size));
-}
-
 #endif /* CONFIG_MMU && !CONFIG_COLDFIRE */
 
 void arch_sync_dma_for_device(phys_addr_t handle, size_t size,
-- 
2.39.2


  parent reply	other threads:[~2023-10-09  7:41 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09  7:41 fix the non-coherent coldfire dma_alloc_coherent Christoph Hellwig
2023-10-09  7:41 ` [PATCH 1/6] dma-direct: add depdenencies to CONFIG_DMA_GLOBAL_POOL Christoph Hellwig
2023-10-09  8:43   ` Geert Uytterhoeven
2023-10-09  9:16     ` Christoph Hellwig
2023-10-09  9:34       ` Geert Uytterhoeven
2023-10-09  9:43         ` Christoph Hellwig
2023-10-09  9:51           ` Geert Uytterhoeven
2023-10-09 10:04             ` Robin Murphy
2023-10-09 11:10               ` Geert Uytterhoeven
2023-10-09 12:48                 ` Christoph Hellwig
2023-10-09 16:45                   ` Robin Murphy
2023-10-09  7:41 ` [PATCH 2/6] dma-direct: add a CONFIG_ARCH_DMA_ALLOC symbol Christoph Hellwig
2023-10-09  7:41 ` [PATCH 3/6] dma-direct: simplify the use atomic pool logic in dma_direct_alloc Christoph Hellwig
2023-10-09  7:41 ` [PATCH 4/6] dma-direct: warn when coherent allocations aren't supported Christoph Hellwig
2023-10-09  7:41 ` [PATCH 5/6] net: fec: use dma_alloc_noncoherent for m532x Christoph Hellwig
2023-10-09 10:29   ` Robin Murphy
2023-10-09 12:58     ` Christoph Hellwig
2023-10-10 14:44       ` Greg Ungerer
2023-10-16  9:12         ` Geert Uytterhoeven
2023-10-17  8:31           ` Geert Uytterhoeven
2023-10-10 14:20     ` Greg Ungerer
2023-10-11  5:52       ` Christoph Hellwig
2023-10-11 13:09         ` Greg Ungerer
2023-10-11 18:21           ` Michael Schmitz
2023-10-12 13:25             ` Greg Ungerer
2023-10-12 14:00               ` Christoph Hellwig
2023-10-13  1:48                 ` Greg Ungerer
2023-10-12 19:18               ` Michael Schmitz
2023-10-09  7:41 ` Christoph Hellwig [this message]
2023-10-09  8:39 ` fix the non-coherent coldfire dma_alloc_coherent Geert Uytterhoeven
2023-10-09  9:15   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231009074121.219686-7-hch@lst.de \
    --to=hch@lst.de \
    --cc=geert@linux-m68k.org \
    --cc=iommu@lists.linux.dev \
    --cc=james.quinlan@broadcom.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=m.szyprowski@samsung.com \
    --cc=netdev@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=shenwei.wang@nxp.com \
    --cc=wei.fang@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox