Linux M68K Architecture development
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@linux-m68k.org>
To: linux-m68k@lists.linux-m68k.org
Cc: Greg Ungerer <gerg@linux-m68k.org>
Subject: [PATCH 04/13] m68k: coldfire: enable common clock framework
Date: Tue, 18 Feb 2025 22:46:24 +1000	[thread overview]
Message-ID: <20250218125124.2692982-5-gerg@linux-m68k.org> (raw)
In-Reply-To: <20250218125124.2692982-1-gerg@linux-m68k.org>

Enable the ColdFire clock driver code to use the common clock framework.
This is not an actual conversion of the code proper. It is a work around
to allow defining clock bindings in a devicetree for ColdFire targets.
It is enough to allow the use of "fixed" clocks, which for many ColdFire
targets is enough for a simple devicetree setup.

A full conversion to the common clock framework and use of the generic
clk struct is still needed to complete this work.

Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
---
 arch/m68k/Kconfig.cpu    | 2 +-
 arch/m68k/coldfire/clk.c | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
index c9a7e602d8a4..50ecb16d0a1f 100644
--- a/arch/m68k/Kconfig.cpu
+++ b/arch/m68k/Kconfig.cpu
@@ -30,7 +30,7 @@ config COLDFIRE
 	select CPU_HAS_NO_MULDIV64
 	select GENERIC_CSUM
 	select GPIOLIB
-	select HAVE_LEGACY_CLK
+	select COMMON_CLK
 	select HAVE_PAGE_SIZE_8KB if !MMU
 
 config SUN3
diff --git a/arch/m68k/coldfire/clk.c b/arch/m68k/coldfire/clk.c
index d03b6c4aa86b..bb4c0a2a8a61 100644
--- a/arch/m68k/coldfire/clk.c
+++ b/arch/m68k/coldfire/clk.c
@@ -20,8 +20,6 @@
 #include <asm/mcfsim.h>
 #include <asm/mcfclk.h>
 
-static DEFINE_SPINLOCK(clk_lock);
-
 #ifdef MCFPM_PPMCR0
 /*
  *	For more advanced ColdFire parts that have clocks that can be enabled
@@ -73,6 +71,10 @@ struct clk_ops clk_ops1 = {
 #endif /* MCFPM_PPMCR1 */
 #endif /* MCFPM_PPMCR0 */
 
+#ifndef CONFIG_COMMON_CLK
+
+static DEFINE_SPINLOCK(clk_lock);
+
 int clk_enable(struct clk *clk)
 {
 	unsigned long flags;
@@ -141,4 +143,6 @@ struct clk *clk_get_parent(struct clk *clk)
 }
 EXPORT_SYMBOL(clk_get_parent);
 
+#endif /* !CONFIG_COMMON_CLK */
+
 /***************************************************************************/
-- 
2.43.0


  parent reply	other threads:[~2025-02-18 12:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 12:46 [PATCH 00/13] m68k: coldfire: proof-of-concept devicetree Greg Ungerer
2025-02-18 12:46 ` [PATCH 01/13] serial: mcf: convert to use proper platform resources Greg Ungerer
2025-02-18 12:46 ` [PATCH 02/13] serial: mcf: add devicetree support Greg Ungerer
2025-02-18 12:46 ` [PATCH 03/13] net: fec: add device tree support for ColdFire FEC Greg Ungerer
2025-02-19  7:05   ` Krzysztof Kozlowski
2025-02-19 13:25     ` Greg Ungerer
2025-02-18 12:46 ` Greg Ungerer [this message]
2025-02-18 12:46 ` [PATCH 05/13] m68k: coldfire: support devicetree binding for intc-simr Greg Ungerer
2025-02-18 12:46 ` [PATCH 06/13] m68k: coldfire: support devicetree binding for intc controller Greg Ungerer
2025-02-18 12:46 ` [PATCH 07/13] m68k: coldfire: support devicetree binding for intc-2 controller Greg Ungerer
2025-02-18 12:46 ` [PATCH 08/13] m68k: coldfire: add devicetree for mcf5208-evb platform Greg Ungerer
2025-02-18 12:46 ` [PATCH 09/13] m68k: coldfire: add devicetree for mcf5475-evb platform Greg Ungerer
2025-02-19  7:06   ` Krzysztof Kozlowski
2025-02-19  8:23     ` Greg Ungerer
2025-02-19  8:26       ` Krzysztof Kozlowski
2025-02-19 21:58         ` Greg Ungerer
2025-02-18 12:46 ` [PATCH 10/13] m68k: implement an embedded devicetree for nonmmu Greg Ungerer
2025-02-20 14:06   ` Geert Uytterhoeven
2025-02-23 14:25     ` Greg Ungerer
2025-02-18 12:46 ` [PATCH 11/13] m68k: implement an embedded devicetree for mm targets Greg Ungerer
2025-02-18 12:46 ` [PATCH 12/13] m68k: coldfire: disable platform device tree entries Greg Ungerer
2025-02-18 12:46 ` [PATCH 13/13] m68k: coldfire: enable devicetree use Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250218125124.2692982-5-gerg@linux-m68k.org \
    --to=gerg@linux-m68k.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox