Re: [PATCH 03/13] net: fec: add device tree support for ColdFire FEC

[Greg Ungerer <gerg@linux-m68k.org>]

On 19/2/25 17:05, Krzysztof Kozlowski wrote:
> On 18/02/2025 13:46, Greg Ungerer wrote:
>> The FEC hardware module used in most Freescale ColdFire SoC parts is a
>> simpler version of that used on the iMX family of parts. Add a devicetree
>> compatible entry they can use.
>>
>> Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
>> ---
>>   Documentation/devicetree/bindings/net/fsl,fec.yaml | 1 +
> 
> Please run scripts/checkpatch.pl and fix reported warnings. After that,
> run also `scripts/checkpatch.pl --strict` and (probably) fix more

I did. I chose to ignore the documentation and frivolous formatting
warnings for now. See cover letter for reasoning.

Regards
Greg


> warnings. Some warnings can be ignored, especially from --strict run,
> but the code here looks like it needs a fix. Feel free to get in touch
> if the warning is not clear.
> 
> 
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> 
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
> 
> Please kindly resend and include all necessary To/Cc entries.
> </form letter>
> 
> Best regards,
> Krzysztof