From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Joshua Thompson <funaho@jurai.org>,
linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH 04/33] m68k: remove unneeded tty includes
Date: Wed, 11 Jun 2025 14:22:34 +0300 (EEST) [thread overview]
Message-ID: <2e994f05-8aa9-82c0-e8e3-927730dccadf@linux.intel.com> (raw)
In-Reply-To: <20250611100319.186924-5-jirislaby@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 3256 bytes --]
On Wed, 11 Jun 2025, Jiri Slaby (SUSE) wrote:
> All these includes must have been cut & pasted. The code does not use
> any tty or vt functionality at all.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Joshua Thompson <funaho@jurai.org>
> Cc: linux-m68k@lists.linux-m68k.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
> ---
> arch/m68k/amiga/config.c | 2 --
> arch/m68k/apollo/config.c | 2 --
> arch/m68k/atari/config.c | 1 -
> arch/m68k/mac/config.c | 2 --
> arch/m68k/q40/config.c | 2 --
> 5 files changed, 9 deletions(-)
>
> diff --git a/arch/m68k/amiga/config.c b/arch/m68k/amiga/config.c
> index 0147130dc34e..242d18e750b0 100644
> --- a/arch/m68k/amiga/config.c
> +++ b/arch/m68k/amiga/config.c
> @@ -16,12 +16,10 @@
> #include <linux/kernel.h>
> #include <linux/mm.h>
> #include <linux/seq_file.h>
> -#include <linux/tty.h>
> #include <linux/clocksource.h>
> #include <linux/console.h>
> #include <linux/rtc.h>
> #include <linux/init.h>
> -#include <linux/vt_kern.h>
> #include <linux/delay.h>
> #include <linux/interrupt.h>
> #include <linux/zorro.h>
> diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c
> index e161ecd76035..e324c5f671de 100644
> --- a/arch/m68k/apollo/config.c
> +++ b/arch/m68k/apollo/config.c
> @@ -3,9 +3,7 @@
> #include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/mm.h>
> -#include <linux/tty.h>
> #include <linux/rtc.h>
> -#include <linux/vt_kern.h>
> #include <linux/interrupt.h>
>
> #include <asm/setup.h>
> diff --git a/arch/m68k/atari/config.c b/arch/m68k/atari/config.c
> index b48a0606a000..ee2d061efb2a 100644
> --- a/arch/m68k/atari/config.c
> +++ b/arch/m68k/atari/config.c
> @@ -33,7 +33,6 @@
> #include <linux/ioport.h>
> #include <linux/platform_device.h>
> #include <linux/usb/isp116x.h>
> -#include <linux/vt_kern.h>
> #include <linux/module.h>
>
> #include <asm/bootinfo.h>
> diff --git a/arch/m68k/mac/config.c b/arch/m68k/mac/config.c
> index d26c7f4f8c36..c0033f885ed4 100644
> --- a/arch/m68k/mac/config.c
> +++ b/arch/m68k/mac/config.c
> @@ -15,7 +15,6 @@
> #include <linux/reboot.h>
> #include <linux/types.h>
> #include <linux/mm.h>
> -#include <linux/tty.h>
> #include <linux/console.h>
> #include <linux/interrupt.h>
> /* keyb */
> @@ -23,7 +22,6 @@
> #include <linux/delay.h>
> /* keyb */
> #include <linux/init.h>
> -#include <linux/vt_kern.h>
> #include <linux/platform_device.h>
> #include <linux/ata_platform.h>
> #include <linux/adb.h>
> diff --git a/arch/m68k/q40/config.c b/arch/m68k/q40/config.c
> index de7870ad2a30..5a4258697622 100644
> --- a/arch/m68k/q40/config.c
> +++ b/arch/m68k/q40/config.c
> @@ -13,14 +13,12 @@
> #include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/mm.h>
> -#include <linux/tty.h>
> #include <linux/console.h>
> #include <linux/linkage.h>
> #include <linux/init.h>
> #include <linux/major.h>
> #include <linux/serial_reg.h>
> #include <linux/rtc.h>
> -#include <linux/vt_kern.h>
> #include <linux/bcd.h>
> #include <linux/platform_device.h>
>
>
next prev parent reply other threads:[~2025-06-11 11:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250611100319.186924-1-jirislaby@kernel.org>
2025-06-11 10:02 ` [PATCH 04/33] m68k: remove unneeded tty includes Jiri Slaby (SUSE)
2025-06-11 11:22 ` Ilpo Järvinen [this message]
2025-06-17 12:29 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e994f05-8aa9-82c0-e8e3-927730dccadf@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=funaho@jurai.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox