* Re: [PATCH 04/33] m68k: remove unneeded tty includes
2025-06-11 10:02 ` [PATCH 04/33] m68k: remove unneeded tty includes Jiri Slaby (SUSE)
@ 2025-06-11 11:22 ` Ilpo Järvinen
2025-06-17 12:29 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2025-06-11 11:22 UTC (permalink / raw)
To: Jiri Slaby (SUSE)
Cc: Greg Kroah-Hartman, linux-serial, LKML, Geert Uytterhoeven,
Joshua Thompson, linux-m68k
[-- Attachment #1: Type: text/plain, Size: 3256 bytes --]
On Wed, 11 Jun 2025, Jiri Slaby (SUSE) wrote:
> All these includes must have been cut & pasted. The code does not use
> any tty or vt functionality at all.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Joshua Thompson <funaho@jurai.org>
> Cc: linux-m68k@lists.linux-m68k.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
> ---
> arch/m68k/amiga/config.c | 2 --
> arch/m68k/apollo/config.c | 2 --
> arch/m68k/atari/config.c | 1 -
> arch/m68k/mac/config.c | 2 --
> arch/m68k/q40/config.c | 2 --
> 5 files changed, 9 deletions(-)
>
> diff --git a/arch/m68k/amiga/config.c b/arch/m68k/amiga/config.c
> index 0147130dc34e..242d18e750b0 100644
> --- a/arch/m68k/amiga/config.c
> +++ b/arch/m68k/amiga/config.c
> @@ -16,12 +16,10 @@
> #include <linux/kernel.h>
> #include <linux/mm.h>
> #include <linux/seq_file.h>
> -#include <linux/tty.h>
> #include <linux/clocksource.h>
> #include <linux/console.h>
> #include <linux/rtc.h>
> #include <linux/init.h>
> -#include <linux/vt_kern.h>
> #include <linux/delay.h>
> #include <linux/interrupt.h>
> #include <linux/zorro.h>
> diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c
> index e161ecd76035..e324c5f671de 100644
> --- a/arch/m68k/apollo/config.c
> +++ b/arch/m68k/apollo/config.c
> @@ -3,9 +3,7 @@
> #include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/mm.h>
> -#include <linux/tty.h>
> #include <linux/rtc.h>
> -#include <linux/vt_kern.h>
> #include <linux/interrupt.h>
>
> #include <asm/setup.h>
> diff --git a/arch/m68k/atari/config.c b/arch/m68k/atari/config.c
> index b48a0606a000..ee2d061efb2a 100644
> --- a/arch/m68k/atari/config.c
> +++ b/arch/m68k/atari/config.c
> @@ -33,7 +33,6 @@
> #include <linux/ioport.h>
> #include <linux/platform_device.h>
> #include <linux/usb/isp116x.h>
> -#include <linux/vt_kern.h>
> #include <linux/module.h>
>
> #include <asm/bootinfo.h>
> diff --git a/arch/m68k/mac/config.c b/arch/m68k/mac/config.c
> index d26c7f4f8c36..c0033f885ed4 100644
> --- a/arch/m68k/mac/config.c
> +++ b/arch/m68k/mac/config.c
> @@ -15,7 +15,6 @@
> #include <linux/reboot.h>
> #include <linux/types.h>
> #include <linux/mm.h>
> -#include <linux/tty.h>
> #include <linux/console.h>
> #include <linux/interrupt.h>
> /* keyb */
> @@ -23,7 +22,6 @@
> #include <linux/delay.h>
> /* keyb */
> #include <linux/init.h>
> -#include <linux/vt_kern.h>
> #include <linux/platform_device.h>
> #include <linux/ata_platform.h>
> #include <linux/adb.h>
> diff --git a/arch/m68k/q40/config.c b/arch/m68k/q40/config.c
> index de7870ad2a30..5a4258697622 100644
> --- a/arch/m68k/q40/config.c
> +++ b/arch/m68k/q40/config.c
> @@ -13,14 +13,12 @@
> #include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/mm.h>
> -#include <linux/tty.h>
> #include <linux/console.h>
> #include <linux/linkage.h>
> #include <linux/init.h>
> #include <linux/major.h>
> #include <linux/serial_reg.h>
> #include <linux/rtc.h>
> -#include <linux/vt_kern.h>
> #include <linux/bcd.h>
> #include <linux/platform_device.h>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 04/33] m68k: remove unneeded tty includes
2025-06-11 10:02 ` [PATCH 04/33] m68k: remove unneeded tty includes Jiri Slaby (SUSE)
2025-06-11 11:22 ` Ilpo Järvinen
@ 2025-06-17 12:29 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2025-06-17 12:29 UTC (permalink / raw)
To: Jiri Slaby (SUSE)
Cc: gregkh, linux-serial, linux-kernel, Joshua Thompson, linux-m68k
On Wed, 11 Jun 2025 at 12:03, Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote:
> All these includes must have been cut & pasted. The code does not use
> any tty or vt functionality at all.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Since GregKH seems to be eager to pick up this series:
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread