Linux M68K Architecture development
 help / color / mirror / Atom feed
From: Finn Thain <fthain@linux-m68k.org>
To: Jens Axboe <axboe@kernel.dk>, Laurent Vivier <laurent@vivier.eu>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	linux-block@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 08/33] swim: Enable clock divider only where appropriate
Date: Fri, 04 Sep 2026 19:26:36 +1000	[thread overview]
Message-ID: <483efa2f8ac6beb2a2d4fa2d8b431cb1a8b560c7.1788513997.git.fthain@linux-m68k.org> (raw)
In-Reply-To: <cover.1788513996.git.fthain@linux-m68k.org>

Some models have a 16 MHz FCLK oscillator and others 32 MHz. Put this
information into the swim device platform_data so that the driver can
correctly enable the clock divider. When this is enabled incorrectly,
nothing can be read and failures from the Error Correction Machine are
flagged in the error register.

Cc: Joshua Thompson <funaho@jurai.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Fixes: 8852ecd97488 ("m68k: mac - Add SWIM floppy support")
Signed-off-by: Finn Thain <fthain@linux-m68k.org>
---
Changed since v2:
 - Code motion was split off into a separate patch.
 - Use 'bool fast_fclk' instead of 'unsigned int data'.
---
 arch/m68k/mac/config.c | 31 ++++++++++++++++++++++++++++++-
 drivers/block/swim.c   |  9 ++++++---
 2 files changed, 36 insertions(+), 4 deletions(-)

diff --git a/arch/m68k/mac/config.c b/arch/m68k/mac/config.c
index c0033f885ed4..b745cf20a71f 100644
--- a/arch/m68k/mac/config.c
+++ b/arch/m68k/mac/config.c
@@ -984,8 +984,37 @@ static int __init mac_platform_init(void)
 			.start = swim_base,
 			.end   = swim_base + 0x1FFF,
 		};
+		bool fast_fclk = false;
+
+		/* Models in this list are supposed to run FCLK at 32 MHz */
+		switch (macintosh_config->ident) {
+		case MAC_MODEL_CCL:
+		case MAC_MODEL_CCLII:
+		case MAC_MODEL_LCIII:
+		case MAC_MODEL_Q605:
+		case MAC_MODEL_Q605_ACC:
+		case MAC_MODEL_Q610:
+		case MAC_MODEL_Q630:
+		case MAC_MODEL_Q650:
+		case MAC_MODEL_Q800:
+		case MAC_MODEL_P460:
+		case MAC_MODEL_P475:
+		case MAC_MODEL_P475F:
+		case MAC_MODEL_P520:
+		case MAC_MODEL_P550:
+		case MAC_MODEL_P575:
+		case MAC_MODEL_P588:
+		case MAC_MODEL_TV:
+		case MAC_MODEL_C610:
+		case MAC_MODEL_C650:
+		case MAC_MODEL_PB190:
+		case MAC_MODEL_PB520:
+			fast_fclk = true;
+			break;
+		}
 
-		platform_device_register_simple("swim", -1, &swim_rsrc, 1);
+		platform_device_register_resndata(NULL, "swim", -1, &swim_rsrc, 1,
+						  &fast_fclk, sizeof(fast_fclk));
 	}
 
 	/*
diff --git a/drivers/block/swim.c b/drivers/block/swim.c
index b8384525fc9a..1ade5c497e10 100644
--- a/drivers/block/swim.c
+++ b/drivers/block/swim.c
@@ -806,8 +806,11 @@ static void swim_set_parameters(struct swim __iomem *base)
 		swim_write(base, parameter, mem[i]);
 }
 
-static int swim_floppy_init(struct swim_priv *swd)
+static int swim_floppy_init(struct platform_device *pdev)
 {
+	struct swim_priv *swd = platform_get_drvdata(pdev);
+	bool *data = pdev->dev.platform_data;
+	bool fast_fclk = data && *data;
 	struct queue_limits lim = {
 		.features		= BLK_FEAT_ROTATIONAL,
 	};
@@ -815,7 +818,7 @@ static int swim_floppy_init(struct swim_priv *swd)
 	int drive;
 	struct swim __iomem *base = swd->base;
 
-	swim_write(base, setup, S_IBM_DRIVE | S_FCLK_DIV2);
+	swim_write(base, setup, S_IBM_DRIVE | (fast_fclk ? S_FCLK_DIV2 : 0));
 
 	swim_set_parameters(base);
 
@@ -931,7 +934,7 @@ static int swim_probe(struct platform_device *dev)
 
 	swd->base = swim_base;
 
-	ret = swim_floppy_init(swd);
+	ret = swim_floppy_init(dev);
 	if (ret)
 		goto out_kfree;
 
-- 
2.52.0


  parent reply	other threads:[~2026-09-04  9:32 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  9:26 [PATCH v3 00/33] block/swim: Fixes and improvements Finn Thain
2026-09-04  9:26 ` [PATCH v3 06/33] swim: Configure parameter memory Finn Thain
2026-09-04  9:26 ` [PATCH v3 03/33] swim: Enable the drive when probing Finn Thain
2026-09-04  9:26 ` [PATCH v3 20/33] swim: Deduplicate polling loops Finn Thain
2026-09-04  9:26 ` [PATCH v3 04/33] swim: Don't disable drive after every sector Finn Thain
2026-09-04  9:26 ` [PATCH v3 24/33] swim: Don't needlessly re-read sectors Finn Thain
2026-09-04  9:26 ` [PATCH v3 11/33] swim: Add track zero recalibration delay Finn Thain
2026-09-04  9:26 ` [PATCH v3 02/33] swim: Select appropriate drive once only Finn Thain
2026-09-04  9:26 ` [PATCH v3 05/33] swim: Perform ISM/IWM mode switching according to specs Finn Thain
2026-09-04  9:26 ` [PATCH v3 18/33] swim: Convert to blocking queue Finn Thain
2026-09-04  9:26 ` [PATCH v3 27/33] swim: Move swd initialization Finn Thain
2026-09-04  9:26 ` [PATCH v3 12/33] swim: Handle FIFO timeout error Finn Thain
2026-09-04  9:26 ` [PATCH v3 10/33] swim: Recalibrate when drive is probed Finn Thain
2026-09-04  9:26 ` [PATCH v3 19/33] swim: Remove redundant RELAX actions Finn Thain
2026-09-04  9:26 ` [PATCH v3 25/33] swim: Don't search beyond the first data mark Finn Thain
2026-09-04  9:26 ` [PATCH v3 09/33] swim: Don't start motor until medium is present Finn Thain
2026-09-04  9:26 ` Finn Thain [this message]
2026-09-04  9:26 ` [PATCH v3 17/33] swim: Fix buffer overflow Finn Thain
2026-09-04  9:26 ` [PATCH v3 29/33] swim: Remove unused macro definitions Finn Thain
2026-09-04  9:26 ` [PATCH v3 22/33] swim: Revisit delays Finn Thain
2026-09-04  9:26 ` [PATCH v3 32/33] swim: Define symbols for constants Finn Thain
2026-09-04  9:26 ` [PATCH v3 13/33] swim: Simplify return value initialization Finn Thain
2026-09-04  9:26 ` [PATCH v3 31/33] swim: Define macros for constants Finn Thain
2026-09-04  9:26 ` [PATCH v3 26/33] swim: Remove pointless specifiers Finn Thain
2026-09-04  9:26 ` [PATCH v3 21/33] swim: Check drive ready bit Finn Thain
2026-09-04  9:26 ` [PATCH v3 28/33] swim: Add some helpful references Finn Thain
2026-09-04  9:26 ` [PATCH v3 15/33] swim: Check error register during sector read Finn Thain
2026-09-04  9:26 ` [PATCH v3 07/33] swim: Refactor SWIM setup Finn Thain
2026-09-04  9:26 ` [PATCH v3 33/33] swim: Unexport global symbols Finn Thain
2026-09-04  9:26 ` [PATCH v3 30/33] swim: Clean up whitespace Finn Thain
2026-09-04  9:26 ` [PATCH v3 01/33] swim: Assert strobe with stable outputs Finn Thain
2026-09-04  9:26 ` [PATCH v3 23/33] swim: Remove pointless mode0 register write Finn Thain
2026-09-04  9:26 ` [PATCH v3 14/33] swim: Check for CRC errors Finn Thain
2026-09-04  9:26 ` [PATCH v3 16/33] swim: Don't use the mark register to read data Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483efa2f8ac6beb2a2d4fa2d8b431cb1a8b560c7.1788513997.git.fthain@linux-m68k.org \
    --to=fthain@linux-m68k.org \
    --cc=axboe@kernel.dk \
    --cc=funaho@jurai.org \
    --cc=geert@linux-m68k.org \
    --cc=laurent@vivier.eu \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox