From: Greg Ungerer <gerg@snapgear.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, gerg@uclinux.org
Subject: Re: [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h
Date: Tue, 7 Sep 2010 19:53:21 +1000 [thread overview]
Message-ID: <4C860B91.30009@snapgear.com> (raw)
In-Reply-To: <m3eid6uhz5.fsf@hase.home>
On 07/09/10 17:32, Andreas Schwab wrote:
> Greg Ungerer<gerg@snapgear.com> writes:
>
>> +/*
>> + * The ColdFire parts cannot do some immediate to memory operations,
>> + * so for them we do not specify the "i" asm constraint.
>> + */
>> +#ifdef CONFIG_COLDFIRE
>> +#define DI "d"
>> +#else
>> +#define DI "di"
>> +#endif
>
> I'd suggest to rename the macro, since DI could easily conflict with a
> definition in a driver.
Yeah, I agree. I'll make it a little more descriptive and longer.
Thanks
Greg
next prev parent reply other threads:[~2010-09-07 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 5:49 [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h Greg Ungerer
2010-09-07 7:32 ` Andreas Schwab
2010-09-07 9:53 ` Greg Ungerer [this message]
2010-09-07 20:42 ` Geert Uytterhoeven
2010-09-08 0:25 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C860B91.30009@snapgear.com \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox