From: Andreas Schwab <schwab@linux-m68k.org>
To: Greg Ungerer <gerg@snapgear.com>
Cc: linux-m68k@vger.kernel.org, gerg@uclinux.org
Subject: Re: [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h
Date: Tue, 07 Sep 2010 09:32:14 +0200 [thread overview]
Message-ID: <m3eid6uhz5.fsf@hase.home> (raw)
In-Reply-To: <201009070549.o875nKHX008042@goober.internal.moreton.com.au> (Greg Ungerer's message of "Tue, 7 Sep 2010 15:49:20 +1000")
Greg Ungerer <gerg@snapgear.com> writes:
> +/*
> + * The ColdFire parts cannot do some immediate to memory operations,
> + * so for them we do not specify the "i" asm constraint.
> + */
> +#ifdef CONFIG_COLDFIRE
> +#define DI "d"
> +#else
> +#define DI "di"
> +#endif
I'd suggest to rename the macro, since DI could easily conflict with a
definition in a driver.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2010-09-07 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 5:49 [PATCH] m68k/m68knommu: merge MMU and non-MMU atomic.h Greg Ungerer
2010-09-07 7:32 ` Andreas Schwab [this message]
2010-09-07 9:53 ` Greg Ungerer
2010-09-07 20:42 ` Geert Uytterhoeven
2010-09-08 0:25 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3eid6uhz5.fsf@hase.home \
--to=schwab@linux-m68k.org \
--cc=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox