[PATCH] m68k: selection of GENERIC_IRQ_SHOW is not MMU specific

[PATCH] m68k: selection of GENERIC_IRQ_SHOW is not MMU specific

[gerg]

From: Greg Ungerer <gerg@uclinux.org>

The selection of the CONFIG_GENERIC_IRQ_SHOW option is not specific
to the MMU being present and enabled. It is dependant on what CPU we are
compiling for. The non-MMU 68000 and ColdFire family CPUs use generic
interrupts, and can use the generic irq show code.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/Kconfig     |    1 -
 arch/m68k/Kconfig.cpu |    3 +++
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
index 9829235..663d1f4 100644
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -3,7 +3,6 @@ config M68K
 	default y
 	select HAVE_IDE
 	select HAVE_AOUT if MMU
-	select GENERIC_IRQ_SHOW if !MMU
 	select ARCH_HAVE_NMI_SAFE_CMPXCHG if RMW_INSNS
 
 config RWSEM_GENERIC_SPINLOCK
diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
index 383c508..5b67ae9 100644
--- a/arch/m68k/Kconfig.cpu
+++ b/arch/m68k/Kconfig.cpu
@@ -4,6 +4,7 @@ config M68000
 	bool
 	select CPU_HAS_NO_BITFIELDS
 	select HAVE_GENERIC_HARDIRQS
+	select GENERIC_IRQ_SHOW
 	help
 	  The Freescale (was Motorola) 68000 CPU is the first generation of
 	  the well known M68K family of processors. The CPU core as well as
@@ -15,6 +16,7 @@ config MCPU32
 	bool
 	select CPU_HAS_NO_BITFIELDS
 	select HAVE_GENERIC_HARDIRQS
+	select GENERIC_IRQ_SHOW
 	help
 	  The Freescale (was then Motorola) CPU32 is a CPU core that is
 	  based on the 68020 processor. For the most part it is used in
@@ -26,6 +28,7 @@ config COLDFIRE
 	select ARCH_REQUIRE_GPIOLIB
 	select CPU_HAS_NO_BITFIELDS
 	select HAVE_GENERIC_HARDIRQS
+	select GENERIC_IRQ_SHOW
 	help
 	  The Freescale ColdFire family of processors is a modern derivitive
 	  of the 68000 processor family. They are mainly targeted at embedded
-- 
1.7.0.4

Re: [PATCH] m68k: selection of GENERIC_IRQ_SHOW is not MMU specific

[Geert Uytterhoeven]

On Fri, Oct 21, 2011 at 09:04,  <gerg@snapgear.com> wrote:
> The selection of the CONFIG_GENERIC_IRQ_SHOW option is not specific
> to the MMU being present and enabled. It is dependant on what CPU we are
> compiling for. The non-MMU 68000 and ColdFire family CPUs use generic
> interrupts, and can use the generic irq show code.
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
> ---
>  arch/m68k/Kconfig     |    1 -
>  arch/m68k/Kconfig.cpu |    3 +++
>  2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
> index 9829235..663d1f4 100644
> --- a/arch/m68k/Kconfig
> +++ b/arch/m68k/Kconfig
> @@ -3,7 +3,6 @@ config M68K
>        default y
>        select HAVE_IDE
>        select HAVE_AOUT if MMU
> -       select GENERIC_IRQ_SHOW if !MMU
>        select ARCH_HAVE_NMI_SAFE_CMPXCHG if RMW_INSNS

This will be fixed Really Soon Now (TM).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] m68k: selection of GENERIC_IRQ_SHOW is not MMU specific

[Greg Ungerer]

Hi Geert,

On 10/22/2011 01:01 AM, Geert Uytterhoeven wrote:
> On Fri, Oct 21, 2011 at 09:04,<gerg@snapgear.com>  wrote:
>> The selection of the CONFIG_GENERIC_IRQ_SHOW option is not specific
>> to the MMU being present and enabled. It is dependant on what CPU we are
>> compiling for. The non-MMU 68000 and ColdFire family CPUs use generic
>> interrupts, and can use the generic irq show code.
>>
>> Signed-off-by: Greg Ungerer<gerg@uclinux.org>
>> ---
>> áarch/m68k/Kconfig á á | á á1 -
>> áarch/m68k/Kconfig.cpu | á á3 +++
>> á2 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
>> index 9829235..663d1f4 100644
>> --- a/arch/m68k/Kconfig
>> +++ b/arch/m68k/Kconfig
>> @@ -3,7 +3,6 @@ config M68K
>> á á á ádefault y
>> á á á áselect HAVE_IDE
>> á á á áselect HAVE_AOUT if MMU
>> - á á á select GENERIC_IRQ_SHOW if !MMU
>> á á á áselect ARCH_HAVE_NMI_SAFE_CMPXCHG if RMW_INSNS
>
> This will be fixed Really Soon Now (TM).

Yep, I expected I would be able to drop this very soon :-)

It is really from completeness. I will be posting a patch set
next week that codes support for running MMU enabled ColdFire.
And I needed these few little cleanups to make that work.

Thanks
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close,                            FAX:         +61 7 3891 3630
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com