[PATCH] m68k: fix compiler warning by properly inlining flat_set_persistent()

[PATCH] m68k: fix compiler warning by properly inlining flat_set_persistent()

[Ezequiel Garcia]

This patch removes the following warning:
fs/binfmt_flat.c:752: warning: unused variable 'persistent'.
There is neither functionality change, nor extra code generated.

Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
---
 arch/m68k/include/asm/flat.h |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/m68k/include/asm/flat.h b/arch/m68k/include/asm/flat.h
index a0e2907..f9454b8 100644
--- a/arch/m68k/include/asm/flat.h
+++ b/arch/m68k/include/asm/flat.h
@@ -11,6 +11,11 @@
 #define	flat_get_addr_from_rp(rp, relval, flags, p)	get_unaligned(rp)
 #define	flat_put_addr_at_rp(rp, val, relval)	put_unaligned(val,rp)
 #define	flat_get_relocate_addr(rel)		(rel)
-#define	flat_set_persistent(relval, p)		0
+
+static inline int flat_set_persistent(unsigned long relval,
+				      unsigned long *persistent)
+{
+	return 0;
+}
 
 #endif /* __M68KNOMMU_FLAT_H__ */
-- 
1.7.3.4

Re: [PATCH] m68k: fix compiler warning by properly inlining flat_set_persistent()

[Greg Ungerer]

Hi Ezequiel,

On 29/04/12 00:13, Ezequiel Garcia wrote:
> This patch removes the following warning:
> fs/binfmt_flat.c:752: warning: unused variable 'persistent'.
> There is neither functionality change, nor extra code generated.
>
> Signed-off-by: Ezequiel Garcia<elezegarcia@gmail.com>

Looks good, thanks.  I'll push that into the for-next branch
of the m68knommu git tree.

Regards
Greg


>   arch/m68k/include/asm/flat.h |    7 ++++++-
>   1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/include/asm/flat.h b/arch/m68k/include/asm/flat.h
> index a0e2907..f9454b8 100644
> --- a/arch/m68k/include/asm/flat.h
> +++ b/arch/m68k/include/asm/flat.h
> @@ -11,6 +11,11 @@
>   #define	flat_get_addr_from_rp(rp, relval, flags, p)	get_unaligned(rp)
>   #define	flat_put_addr_at_rp(rp, val, relval)	put_unaligned(val,rp)
>   #define	flat_get_relocate_addr(rel)		(rel)
> -#define	flat_set_persistent(relval, p)		0
> +
> +static inline int flat_set_persistent(unsigned long relval,
> +				      unsigned long *persistent)
> +{
> +	return 0;
> +}
>
>   #endif /* __M68KNOMMU_FLAT_H__ */


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com