From: Michael Schmitz <schmitzmic@gmail.com>
To: Thorsten Glaser <tg@debian.org>
Cc: linux-m68k@vger.kernel.org
Subject: Re: I/O macros redefined, inconsistent across m68k machdep headers
Date: Sun, 12 May 2013 13:15:59 +1200 [thread overview]
Message-ID: <518EED4F.7080702@gmail.com> (raw)
In-Reply-To: <loom.20130511T171757-995@post.gmane.org>
Thorsten,
> I *really* dislike seeing messages like this while compiling,
> that’s why I’m sending them there. I had a look at both files,
> but there’s a lot of ifdeffery going on, and I don’t know
> which of the macro resolutions, if any, is supposedly correct.
>
I'm responsible for part of the ifdef'ery in io_mm.h - as far as I can
see, Q40 only needs this hack for the parport, all other ISA accesses
should be mapped to isa_insl()/isa_outsl() with address translation
applied correctly in all cases regarding of whether or not this is a
multiarch kernel.
I'm certain there is a reason for turning the word macros into byte ones
(Q40 needs delays between accesses, maybe that's it. Or the parport chip
is 8 bit only). So this most likely needs to stay.
A cleaner way to do this would be to prefix the #defines with
#ifdef isa_insl
#undef isa_insl
#undef isa_outsl
#endif
(untested)
or just #undef anyway, since we can be fairly certain the previous
#defines have been made.
> CC [M] drivers/parport/parport_pc.o
> In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
> parport_pc.c:67:0:
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning:
> "insl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is
> the location of the previous definition
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning:
> "outsl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0: note: this is
> the location of the previous definition
> In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
> parport_pc.c:67:0:
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning:
> "insl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is
> the location of the previous definition
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning:
> "outsl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the
> location of the previous definition
>
>
> This is from building the amiga flavour (first of six!) of the Debian
> unstable Linux kernel source package. We’ll have the new kernels in
> roughly 1½-2 weeks, if everything works ☺
>
What kernel versions are these?
Cheers,
Michael
> bye,
> //mirabilos
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-05-12 1:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 15:19 I/O macros redefined, inconsistent across m68k machdep headers Thorsten Glaser
2013-05-12 1:15 ` Michael Schmitz [this message]
2013-05-12 16:17 ` Thorsten Glaser
2013-05-14 22:03 ` Michael Schmitz
2013-05-14 22:17 ` Thorsten Glaser
2013-05-14 23:31 ` Michael Schmitz
2013-06-09 12:44 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518EED4F.7080702@gmail.com \
--to=schmitzmic@gmail.com \
--cc=linux-m68k@vger.kernel.org \
--cc=tg@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox