I/O macros redefined, inconsistent across m68k machdep headers

I/O macros redefined, inconsistent across m68k machdep headers

[Thorsten Glaser]

Hi!

I *really* dislike seeing messages like this while compiling,
that’s why I’m sending them there. I had a look at both files,
but there’s a lot of ifdeffery going on, and I don’t know
which of the macro resolutions, if any, is supposedly correct.

  CC [M]  drivers/parport/parport_pc.o
In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
parport_pc.c:67:0:
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning: 
"insl" redefined [enabled by default]
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is 
the location of the previous definition
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning: 
"outsl" redefined [enabled by default]
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0: note: this is 
the location of the previous definition
In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
parport_pc.c:67:0:
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning: 
"insl" redefined [enabled by default]
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is 
the location of the previous definition
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning: 
"outsl" redefined [enabled by default]
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the 
location of the previous definition


This is from building the amiga flavour (first of six!) of the Debian
unstable Linux kernel source package. We’ll have the new kernels in
roughly 1½-2 weeks, if everything works ☺

bye,
//mirabilos

Re: I/O macros redefined, inconsistent across m68k machdep headers

[Michael Schmitz]

Thorsten,
> I *really* dislike seeing messages like this while compiling,
> that’s why I’m sending them there. I had a look at both files,
> but there’s a lot of ifdeffery going on, and I don’t know
> which of the macro resolutions, if any, is supposedly correct.
>   
I'm responsible for part of the ifdef'ery in io_mm.h - as far as I can 
see, Q40 only needs this hack for the parport, all other ISA accesses 
should be mapped to isa_insl()/isa_outsl() with address translation 
applied correctly in all cases regarding of whether or not this is a 
multiarch kernel.

I'm certain there is a reason for turning the word macros into byte ones 
(Q40 needs delays between accesses, maybe that's it. Or the parport chip 
is 8 bit only). So this most likely needs to stay.

A cleaner way to do this would be to prefix the #defines with

#ifdef isa_insl
#undef isa_insl
#undef isa_outsl
#endif

(untested)

or just #undef anyway, since we can be fairly certain the previous 
#defines have been made.
>   CC [M]  drivers/parport/parport_pc.o
> In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
> parport_pc.c:67:0:
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning: 
> "insl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is 
> the location of the previous definition
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning: 
> "outsl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0: note: this is 
> the location of the previous definition
> In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
> parport_pc.c:67:0:
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning: 
> "insl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is 
> the location of the previous definition
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning: 
> "outsl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the 
> location of the previous definition
>
>
> This is from building the amiga flavour (first of six!) of the Debian
> unstable Linux kernel source package. We’ll have the new kernels in
> roughly 1½-2 weeks, if everything works ☺
>   
What kernel versions are these?

Cheers,

    Michael

> bye,
> //mirabilos
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   

Re: I/O macros redefined, inconsistent across m68k machdep headers

[Thorsten Glaser]

Michael Schmitz dixit:

> or just #undef anyway, since we can be fairly certain the previous #defines

An #undef is always safe even if none has been made.

> What kernel versions are these?

>> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the
                     ^^^^^^

As usual, when building Debian packages, I’m using whatever the
Debian Linux kernel team has uploaded to unstable.

(As a side note: will your Atari NIC drivers be in 3.8.10 vanilla?)

bye,
//mirabilos
-- 
Sorry,  I’m annoyed today and you came by as an Arch user. These are the
perfect victims for any crime against humanity, like  systemd,  feminism
or social democracy.
		-- Christoph Lohmann on dev@suckless.org

Re: I/O macros redefined, inconsistent across m68k machdep headers

[Michael Schmitz]

Hi Thorsten,

>> or just #undef anyway, since we can be fairly certain the previous #defines
>
> An #undef is always safe even if none has been made.

Right - it's just for readability really.

>> What kernel versions are these?
>
>>> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the
>                      ^^^^^^

Missed that, obviously.

> As usual, when building Debian packages, I’m using whatever the
> Debian Linux kernel team has uploaded to unstable.
>
> (As a side note: will your Atari NIC drivers be in 3.8.10 vanilla?)

They are in m68k-queue on 3.9 so might to into 3.10. No idea whether
they are automatically backported to 3.8.10.

Cheers,

  Michael

> bye,
> //mirabilos
> --
> Sorry,  I’m annoyed today and you came by as an Arch user. These are the
> perfect victims for any crime against humanity, like  systemd,  feminism
> or social democracy.
>                 -- Christoph Lohmann on dev@suckless.org


On Mon, May 13, 2013 at 4:17 AM, Thorsten Glaser <tg@mirbsd.de> wrote:
> Michael Schmitz dixit:
>
>> or just #undef anyway, since we can be fairly certain the previous #defines
>
> An #undef is always safe even if none has been made.
>
>> What kernel versions are these?
>
>>> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the
>                      ^^^^^^
>
> As usual, when building Debian packages, I’m using whatever the
> Debian Linux kernel team has uploaded to unstable.
>
> (As a side note: will your Atari NIC drivers be in 3.8.10 vanilla?)
>
> bye,
> //mirabilos
> --
> Sorry,  I’m annoyed today and you came by as an Arch user. These are the
> perfect victims for any crime against humanity, like  systemd,  feminism
> or social democracy.
>                 -- Christoph Lohmann on dev@suckless.org

Re: I/O macros redefined, inconsistent across m68k machdep headers

[Thorsten Glaser]

Michael Schmitz dixit:

>> (As a side note: will your Atari NIC drivers be in 3.8.10 vanilla?)
>
>They are in m68k-queue on 3.9 so might to into 3.10. No idea whether

Ah okay. ISTR Geert saying you had to submit them?

>they are automatically backported to 3.8.10.

Oh sorry, that was a typo, I meant 3.10 of course. Nothing is
backported automatically.

bye,
//mirabilos
-- 
Sorry,  I’m annoyed today and you came by as an Arch user. These are the
perfect victims for any crime against humanity, like  systemd,  feminism
or social democracy.
		-- Christoph Lohmann on dev@suckless.org

Re: I/O macros redefined, inconsistent across m68k machdep headers

[Michael Schmitz]

Hi Thorsten,

>>They are in m68k-queue on 3.9 so might to into 3.10. No idea whether
>
> Ah okay. ISTR Geert saying you had to submit them?

Correct - will do when I find a free moment. I need to tread a wee bit
carefully after being shot down in flames last time.

>>they are automatically backported to 3.8.10.
>
> Oh sorry, that was a typo, I meant 3.10 of course. Nothing is
> backported automatically.

Should be going into 3.10 vanilla if no objections are raised. The
rest has already been merged (except for the interrupt stuff, which
people may have shrugged off a a joke).

Cheers,

    Michael



On Wed, May 15, 2013 at 10:17 AM, Thorsten Glaser <tg@mirbsd.de> wrote:
> Michael Schmitz dixit:
>
>>> (As a side note: will your Atari NIC drivers be in 3.8.10 vanilla?)
>>
>>They are in m68k-queue on 3.9 so might to into 3.10. No idea whether
>
> Ah okay. ISTR Geert saying you had to submit them?
>
>>they are automatically backported to 3.8.10.
>
> Oh sorry, that was a typo, I meant 3.10 of course. Nothing is
> backported automatically.
>
> bye,
> //mirabilos
> --
> Sorry,  I’m annoyed today and you came by as an Arch user. These are the
> perfect victims for any crime against humanity, like  systemd,  feminism
> or social democracy.
>                 -- Christoph Lohmann on dev@suckless.org

Re: I/O macros redefined, inconsistent across m68k machdep headers

[Geert Uytterhoeven]

On Sat, May 11, 2013 at 5:19 PM, Thorsten Glaser <tg@debian.org> wrote:
>   CC [M]  drivers/parport/parport_pc.o
> In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
> parport_pc.c:67:0:
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning:
> "insl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is
> the location of the previous definition
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning:
> "outsl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0: note: this is
> the location of the previous definition
> In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
> parport_pc.c:67:0:
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning:
> "insl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is
> the location of the previous definition
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning:
> "outsl" redefined [enabled by default]
> /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the
> location of the previous definition
>
>
> This is from building the amiga flavour (first of six!) of the Debian
> unstable Linux kernel source package. We’ll have the new kernels in

I only have this warning in builds that enable as much as possible (e.g.
allmodconfig).

PARPORT_PC depends on (!M68K || ISA).
ISA depends on Q40 || AMIGA_PCMCIA.

However, I have CONFIG_PARPORT_PC=n in amiga_defconfig and
multi_defconfig, and CONFIG_PARPORT=n in q40_defconfig.
Hence I don't see it elsewhere.

As we don't have support for bridgeboards on Amiga, we probably don't
need CONFIG_PARPORT_PC on Amiga. Unless someone is using it
with a PCMCIA parallel port adapter?

Probably CONFIG_PARPORT and CONFIG_PARPORT_PC should be
enabled in q40_defconfig (and thus multi_defconfig) though, to accommodate
ISA multi-I/O boards.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds