public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
* atakbd_keycode
@ 2015-10-24 13:35 Andreas Schwab
  2015-10-27  7:40 ` atakbd_keycode Michael Schmitz
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2015-10-24 13:35 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Michael Schmitz, linux-m68k

In drivers/input/keyboard/atakbd.c, the array atakbd_keycode is
initialized like this:

	[41]	 = KEY_BACKSLASH,	/* FIXME, '#' */
	[43]	 = KEY_GRAVE,		/* FIXME: '~' */

Shouldn't that be the other way round?  According to the Profibuch, on a
US Atari keyboard the key which sends scancode 41 is the '`' key and the
scancode 43 is sent by the '\' key.  On a German keyboard, these are the
'#' and '~' keys, resp.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: atakbd_keycode
  2015-10-24 13:35 atakbd_keycode Andreas Schwab
@ 2015-10-27  7:40 ` Michael Schmitz
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Schmitz @ 2015-10-27  7:40 UTC (permalink / raw)
  To: Andreas Schwab, Geert Uytterhoeven; +Cc: linux-m68k

Andreas,

you're certainly right there - I used the German keyboard to figure out
the mapping (that's where the FIXMEs are from) and must have looked at a
PC keyboard for some of the DE-US translation.

Thanks for spotting this. I'll better double check the entire keymap
before preparing a patch ...

Cheers,

    Michael


Am 25.10.15 um 02:35 schrieb Andreas Schwab:
> In drivers/input/keyboard/atakbd.c, the array atakbd_keycode is
> initialized like this:
>
> 	[41]	 = KEY_BACKSLASH,	/* FIXME, '#' */
> 	[43]	 = KEY_GRAVE,		/* FIXME: '~' */
>
> Shouldn't that be the other way round?  According to the Profibuch, on a
> US Atari keyboard the key which sends scancode 41 is the '`' key and the
> scancode 43 is sent by the '\' key.  On a German keyboard, these are the
> '#' and '~' keys, resp.
>
> Andreas.
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-27  7:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-24 13:35 atakbd_keycode Andreas Schwab
2015-10-27  7:40 ` atakbd_keycode Michael Schmitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox