From: Michael Schmitz <schmitzmic@gmail.com>
To: Finn Thain <fthain@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH RFC] m68k: skip kernel premption if interrupts were disabled
Date: Wed, 27 Mar 2024 11:35:57 +1300 [thread overview]
Message-ID: <570d4e69-e73c-4d35-8538-b5530c714c55@gmail.com> (raw)
In-Reply-To: <fb93b00e-6cfd-f2a8-7937-1266d7bbfc23@linux-m68k.org>
Hi Finn,
yes, that would be the end goal, but it might be easier for Geert to
merge the two patches (or a single one) on top of his preempt branch if
they come in the usual git format.
Cheers,
Michael
On 27/03/24 11:03, Finn Thain wrote:
> On Wed, 27 Mar 2024, Michael Schmitz wrote:
>
>> thanks - I'm pretty sure tried that early on but botched it by excessive
>> locking (i.e., keeping preemption disabled when calling
>> get_zeroed_page()!).
>>
>> So I don't think you do use too much locking here.
>>
>> I'm running stress tests for a while now, without any trouble so far.
>> Need to add a few other stressors back in, and repeat all that on a
>> slower ARAnyM instance but I'm quite confident you found the solution.
>>
>> Geert: with this data race fixed, it does appear my RFC patch is no
>> longer needed. Finn or I probably ought to prepare a new RFC patch to go
>> on top of your preemption patch. There is no commit ID to use in a
>> Fixes: tag for that one, correct?
>>
> I don't think we need a formal fix. I'd be content for Geert to simply
> roll your free_pointer_table() changes and my get_pointer_table() changes
> into his own commit. That way, bisection won't produce an unstable build.
next prev parent reply other threads:[~2024-03-26 22:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 1:48 [PATCH RFC] m68k: skip kernel premption if interrupts were disabled Michael Schmitz
[not found] ` <fcabda73-4b16-ee2c-e993-2bfcf392a26a@linux-m68k.org>
[not found] ` <e89bf618-2fa8-7cbd-16ed-d021a9a7f740@gmail.com>
[not found] ` <948c12e4-e85f-a86c-ae95-a1eb03ca026d@gmail.com>
[not found] ` <40928e38-0de7-75a6-d5f7-8c913155da03@linux-m68k.org>
2024-03-23 6:32 ` Michael Schmitz
2024-03-25 6:41 ` Michael Schmitz
2024-03-25 22:28 ` Finn Thain
2024-03-25 22:31 ` Michael Schmitz
2024-03-26 0:41 ` Finn Thain
2024-03-26 9:58 ` Finn Thain
2024-03-26 19:59 ` Michael Schmitz
2024-03-26 22:03 ` Finn Thain
2024-03-26 22:35 ` Michael Schmitz [this message]
2024-03-27 3:50 ` Finn Thain
2024-03-27 6:56 ` Michael Schmitz
2024-03-27 23:29 ` Spinlock debug, was " Finn Thain
[not found] ` <7aee9fd9-1c0e-4874-bb86-e512a7c0caa6@gmail.com>
2024-03-28 2:48 ` Finn Thain
2024-03-28 19:54 ` Michael Schmitz
2024-03-30 2:46 ` Michael Schmitz
2024-03-30 6:23 ` Finn Thain
2024-03-31 6:14 ` Michael Schmitz
2024-03-27 8:38 ` Finn Thain
2024-03-27 22:59 ` Michael Schmitz
2024-03-27 8:22 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570d4e69-e73c-4d35-8538-b5530c714c55@gmail.com \
--to=schmitzmic@gmail.com \
--cc=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox