From: Michael Schmitz <schmitzmic@gmail.com>
To: Finn Thain <fthain@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org
Subject: Re: Spinlock debug, was Re: [PATCH RFC] m68k: skip kernel premption if interrupts were disabled
Date: Sat, 30 Mar 2024 15:46:11 +1300 [thread overview]
Message-ID: <fc5ba67e-3d6a-2fef-ca85-6d5039da1af7@gmail.com> (raw)
In-Reply-To: <63db5f0b-2a7d-a057-2cfb-fefddc15bc3f@gmail.com>
Hi Finn,
Am 29.03.2024 um 08:54 schrieb Michael Schmitz:
> Hi Finn,
>
> Am 28.03.2024 um 15:48 schrieb Finn Thain:
>>> Spinlock recursion in scheduler_tick() doesn't look possible from
>>> reentering scheduler_tick() through code in its call path, so the
>>> mechanism there would be different.
>>>
>>> We did rule out the VIA timer interrupt (or MFP timer A interrupt)
>>> getting reentered, right?
>>>
>>
>> I never added an assertion to prove that because I don't have a way to
>> reproduce the "spinlock recursion" BUG reported by Guenter.
>
> Right. I can reproduce the bug in ARAnyM, so I'll check that the timer
> interrupt isn't reentered there. Doesn't quite amount to the same thing
> though.
The MFP timer C is not reentered in 66 boots even though I've seen it
appear in the stack trace of 8 recursion warnings.
This was with full preempt - no different from earlier when I got a
similar fraction of warnings at boot.
Cheers,
Michael
next prev parent reply other threads:[~2024-03-30 2:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 1:48 [PATCH RFC] m68k: skip kernel premption if interrupts were disabled Michael Schmitz
[not found] ` <fcabda73-4b16-ee2c-e993-2bfcf392a26a@linux-m68k.org>
[not found] ` <e89bf618-2fa8-7cbd-16ed-d021a9a7f740@gmail.com>
[not found] ` <948c12e4-e85f-a86c-ae95-a1eb03ca026d@gmail.com>
[not found] ` <40928e38-0de7-75a6-d5f7-8c913155da03@linux-m68k.org>
2024-03-23 6:32 ` Michael Schmitz
2024-03-25 6:41 ` Michael Schmitz
2024-03-25 22:28 ` Finn Thain
2024-03-25 22:31 ` Michael Schmitz
2024-03-26 0:41 ` Finn Thain
2024-03-26 9:58 ` Finn Thain
2024-03-26 19:59 ` Michael Schmitz
2024-03-26 22:03 ` Finn Thain
2024-03-26 22:35 ` Michael Schmitz
2024-03-27 3:50 ` Finn Thain
2024-03-27 6:56 ` Michael Schmitz
2024-03-27 23:29 ` Spinlock debug, was " Finn Thain
[not found] ` <7aee9fd9-1c0e-4874-bb86-e512a7c0caa6@gmail.com>
2024-03-28 2:48 ` Finn Thain
2024-03-28 19:54 ` Michael Schmitz
2024-03-30 2:46 ` Michael Schmitz [this message]
2024-03-30 6:23 ` Finn Thain
2024-03-31 6:14 ` Michael Schmitz
2024-03-27 8:38 ` Finn Thain
2024-03-27 22:59 ` Michael Schmitz
2024-03-27 8:22 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc5ba67e-3d6a-2fef-ca85-6d5039da1af7@gmail.com \
--to=schmitzmic@gmail.com \
--cc=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox