* [PATCH] m64k/kernel: replace strncpy() with strscpy()
@ 2025-04-03 0:16 Mohammad Mahdi Anbaraki
2025-04-03 16:22 ` Andreas Schwab
0 siblings, 1 reply; 2+ messages in thread
From: Mohammad Mahdi Anbaraki @ 2025-04-03 0:16 UTC (permalink / raw)
To: geert; +Cc: linux-m68k, linux-kernel, Mohammad Mahdi Anbaraki
Swapped out strncpy() for strscpy() in parse_uboot_commandline() while
copying to commandp. strscpy() makes sure the string is properly null-
terminated and gives a more useful return value so it's just a safer
choice overall.
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Mohammad Mahdi Anbaraki <m.mahdianbaraki@gmail.com>
---
arch/m68k/kernel/uboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/m68k/kernel/uboot.c b/arch/m68k/kernel/uboot.c
index 5e52ea150..fa7c279ea 100644
--- a/arch/m68k/kernel/uboot.c
+++ b/arch/m68k/kernel/uboot.c
@@ -73,7 +73,7 @@ static void __init parse_uboot_commandline(char *commandp, int size)
uboot_cmd_end = sp[5];
if (uboot_cmd_start && uboot_cmd_end)
- strncpy(commandp, (const char *)uboot_cmd_start, size);
+ strscpy(commandp, (const char *)uboot_cmd_start, size);
#if defined(CONFIG_BLK_DEV_INITRD)
uboot_initrd_start = sp[2];
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] m64k/kernel: replace strncpy() with strscpy()
2025-04-03 0:16 [PATCH] m64k/kernel: replace strncpy() with strscpy() Mohammad Mahdi Anbaraki
@ 2025-04-03 16:22 ` Andreas Schwab
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Schwab @ 2025-04-03 16:22 UTC (permalink / raw)
To: Mohammad Mahdi Anbaraki; +Cc: geert, linux-m68k, linux-kernel
s/m64k/m68k/
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-03 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-03 0:16 [PATCH] m64k/kernel: replace strncpy() with strscpy() Mohammad Mahdi Anbaraki
2025-04-03 16:22 ` Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox