Re: [patch 3/2] m68k: Atari EtherNAT - add writew_be for data push

Re: [patch 3/2] m68k: Atari EtherNAT - add writew_be for data push

[Geert Uytterhoeven]

	Hi Michael,

On Thu, 4 Sep 2008, Michael Schmitz wrote:
> as you've probably noticed, my previous EtherNAT patch does not compile
> without this one being applied as well.
> 
> Comments welcome (is there anyone on this list with access to an EtherNAT
> card,
> besides cts and myself?).
> 
> Regarding performance afforded by having a 100 Mbit PHY instead of a 10 Mbit
> one:
> 
> EtherNAT: 210 KB/s out, 140 KB/s in (scp of a 35 MB vmlinux file)
> EtherNEC: 175 KB/s out, 128 KB/s in (same file)
> 
> Hardly worth it, eh?

That's slower than my Ariadne?

BTW, do you have a patch for this?

| drivers/net/atari_91C111.c:2317: error: 'struct smc91x_platdata' has no member named 'irq_flags'
| drivers/net/atari_91C111.c:2361: error: 'struct smc91x_platdata' has no member named 'irq_flags'
| drivers/net/atari_91C111.c:2371: error: 'struct smc91x_platdata' has no member named 'irq_flags'
| drivers/net/atari_91C111.c:2411: error: 'struct smc91x_platdata' has no member named 'irq_flags'

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [patch 3/2] m68k: Atari EtherNAT - add writew_be for data push

[Michael Schmitz]

Hi Geert,

>> Regarding performance afforded by having a 100 Mbit PHY instead of a 10 Mbit
>> one:
>>
>> EtherNAT: 210 KB/s out, 140 KB/s in (scp of a 35 MB vmlinux file)
>> EtherNEC: 175 KB/s out, 128 KB/s in (same file)
>>
>> Hardly worth it, eh?
>
> That's slower than my Ariadne?

Still no interrupts.

> BTW, do you have a patch for this?
>
> | drivers/net/atari_91C111.c:2317: error: 'struct smc91x_platdata' has no member named 'irq_flags'
> | drivers/net/atari_91C111.c:2361: error: 'struct smc91x_platdata' has no member named 'irq_flags'
> | drivers/net/atari_91C111.c:2371: error: 'struct smc91x_platdata' has no member named 'irq_flags'
> | drivers/net/atari_91C111.c:2411: error: 'struct smc91x_platdata' has no member named 'irq_flags'

Not yet - I was working on that when I went into headless-chicken mode at work a 
few weeks back. I'll resync my kernel tree and restart.

There's been extensive changes to the parent driver that make me feel it's 
better to start from scratch anyway. I'll think about that (the need to set up 
the timer D and the interrupt wrapper thing is about the only thing I can 
imagine that would be problematic there).

Don't hold your breath just yet :')

 	Michael

Re: [patch 3/2] m68k: Atari EtherNAT - add writew_be for data push

[Geert Uytterhoeven]

On Fri, 31 Oct 2008, Michael Schmitz wrote:
> > > > Looking at the SCSI driver in 2.6.26, it's no surprise - the error handling 
> > > > update that I did for 2.6.18 is not included in Geert's current 2.6 patch 
> > > > series. Looks like I botched the patch submission way back when. 
> > > 
> > > It's a pity. You put so much work in it but none of your patches
> > > (EtherNEC, EtherNAT or SCSI) got it into a current kernel.
> > > 
> > > Is there a reason why?
> > 
> > When Michael thinks they're ready, he can submit them to netdev or linux-scsi
> > ;-)
> 
> I'm happy for them to live in linux-m68k :-)
> 
> EtherNEC and EtherNAT are 'ready' in the sense they are working reliably. They 
> are by no means 'ready in the sense that mainline kernel maintainers would be 
> happy to take my patches. 

Or should we get them into linux-staging?

http://kerneltrap.org/Linux/Introducing_the_Linux_Staging_Tree

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [patch 3/2] m68k: Atari EtherNAT - add writew_be for data push

[Michael Schmitz]

Hi Geert,

> > > When Michael thinks they're ready, he can submit them to netdev or linux-scsi
> > > ;-)
> > 
> > I'm happy for them to live in linux-m68k :-)
> > 
> > EtherNEC and EtherNAT are 'ready' in the sense they are working reliably. They 
> > are by no means 'ready in the sense that mainline kernel maintainers would be 
> > happy to take my patches. 
> 
> Or should we get them into linux-staging?
> 
> http://kerneltrap.org/Linux/Introducing_the_Linux_Staging_Tree

That would be an option - I'd first like to rewrite EtherNEC to use a platform 
device for init, though. 

SCSI will be a different matter though. Not a new driver :-)

	Michael