From: Al Viro <viro@zeniv.linux.org.uk>
To: Greg Ungerer <gerg@linux-m68k.org>
Cc: Xin Gao <gaoxin@cdjrlc.com>,
geert@linux-m68k.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: Complete variable type
Date: Tue, 16 Aug 2022 07:24:17 +0100 [thread overview]
Message-ID: <Yvs4EUfVUdOgEW4f@ZenIV> (raw)
In-Reply-To: <4ae72d0b-b197-f9d8-5cbe-ce7cfaf3affc@linux-m68k.org>
On Tue, Aug 16, 2022 at 09:37:19AM +1000, Greg Ungerer wrote:
> On 16/8/22 05:48, Xin Gao wrote:
> > @@ -169,7 +169,7 @@ void q40_sched_init (void)
> > *
> > */
> > -struct IRQ_TABLE{ unsigned int mask; int irq ;};
> > +struct IRQ_TABLE{ unsigned int mask; int irq };
> > #if 0
> > static struct IRQ_TABLE iirqs[]={
> > {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
>
> This last change doesn't match the commit message.
> It should be a separate patch.
The last change is not a valid C. Never had been.
In C semicolon is *NOT* a separator - it's a part of declaration.
--
improve the kernel quality - git rm scripts/checkpatch.pl
prev parent reply other threads:[~2022-08-16 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 19:48 [PATCH] m68k: Complete variable type Xin Gao
2022-08-15 23:37 ` Greg Ungerer
2022-08-16 6:24 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvs4EUfVUdOgEW4f@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=gaoxin@cdjrlc.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox