* [PATCH] m68k: Complete variable type
@ 2022-08-15 19:48 Xin Gao
2022-08-15 23:37 ` Greg Ungerer
0 siblings, 1 reply; 3+ messages in thread
From: Xin Gao @ 2022-08-15 19:48 UTC (permalink / raw)
To: gerg, geert; +Cc: linux-m68k, linux-kernel, Xin Gao
Complete the variable type of line 109.
Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
arch/m68k/coldfire/m520x.c | 2 +-
arch/m68k/q40/q40ints.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/m68k/coldfire/m520x.c b/arch/m68k/coldfire/m520x.c
index d2f96b40aee1..dca89214bbc6 100644
--- a/arch/m68k/coldfire/m520x.c
+++ b/arch/m68k/coldfire/m520x.c
@@ -106,7 +106,7 @@ static struct clk * const disable_clks[] __initconst = {
static void __init m520x_clk_init(void)
{
- unsigned i;
+ unsigned int i;
/* make sure these clocks are enabled */
for (i = 0; i < ARRAY_SIZE(enable_clks); ++i)
diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
index 100c05544c6a..fdac8a0cb75f 100644
--- a/arch/m68k/q40/q40ints.c
+++ b/arch/m68k/q40/q40ints.c
@@ -169,7 +169,7 @@ void q40_sched_init (void)
*
*/
-struct IRQ_TABLE{ unsigned int mask; int irq ;};
+struct IRQ_TABLE{ unsigned int mask; int irq };
#if 0
static struct IRQ_TABLE iirqs[]={
{Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] m68k: Complete variable type
2022-08-15 19:48 [PATCH] m68k: Complete variable type Xin Gao
@ 2022-08-15 23:37 ` Greg Ungerer
2022-08-16 6:24 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: Greg Ungerer @ 2022-08-15 23:37 UTC (permalink / raw)
To: Xin Gao, geert; +Cc: linux-m68k, linux-kernel
On 16/8/22 05:48, Xin Gao wrote:
> Complete the variable type of line 109.
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> arch/m68k/coldfire/m520x.c | 2 +-
> arch/m68k/q40/q40ints.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/m68k/coldfire/m520x.c b/arch/m68k/coldfire/m520x.c
> index d2f96b40aee1..dca89214bbc6 100644
> --- a/arch/m68k/coldfire/m520x.c
> +++ b/arch/m68k/coldfire/m520x.c
> @@ -106,7 +106,7 @@ static struct clk * const disable_clks[] __initconst = {
>
> static void __init m520x_clk_init(void)
> {
> - unsigned i;
> + unsigned int i;
>
> /* make sure these clocks are enabled */
> for (i = 0; i < ARRAY_SIZE(enable_clks); ++i)
> diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
> index 100c05544c6a..fdac8a0cb75f 100644
> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -169,7 +169,7 @@ void q40_sched_init (void)
> *
> */
>
> -struct IRQ_TABLE{ unsigned int mask; int irq ;};
> +struct IRQ_TABLE{ unsigned int mask; int irq };
> #if 0
> static struct IRQ_TABLE iirqs[]={
> {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
This last change doesn't match the commit message.
It should be a separate patch.
Regards
Greg
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] m68k: Complete variable type
2022-08-15 23:37 ` Greg Ungerer
@ 2022-08-16 6:24 ` Al Viro
0 siblings, 0 replies; 3+ messages in thread
From: Al Viro @ 2022-08-16 6:24 UTC (permalink / raw)
To: Greg Ungerer; +Cc: Xin Gao, geert, linux-m68k, linux-kernel
On Tue, Aug 16, 2022 at 09:37:19AM +1000, Greg Ungerer wrote:
> On 16/8/22 05:48, Xin Gao wrote:
> > @@ -169,7 +169,7 @@ void q40_sched_init (void)
> > *
> > */
> > -struct IRQ_TABLE{ unsigned int mask; int irq ;};
> > +struct IRQ_TABLE{ unsigned int mask; int irq };
> > #if 0
> > static struct IRQ_TABLE iirqs[]={
> > {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
>
> This last change doesn't match the commit message.
> It should be a separate patch.
The last change is not a valid C. Never had been.
In C semicolon is *NOT* a separator - it's a part of declaration.
--
improve the kernel quality - git rm scripts/checkpatch.pl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-16 8:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-15 19:48 [PATCH] m68k: Complete variable type Xin Gao
2022-08-15 23:37 ` Greg Ungerer
2022-08-16 6:24 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox