Linux M68K Architecture development
 help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: gerg@snapgear.com
Cc: linux-m68k@vger.kernel.org, uclinux-dev@uclinux.org,
	Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH] m68k: merge arch free memory functions into a single function
Date: Sat, 1 Dec 2012 14:49:56 +1100 (EST)	[thread overview]
Message-ID: <alpine.LNX.2.00.1212011441010.9740@nippy.intranet> (raw)
In-Reply-To: <1354249670-4376-1-git-send-email-gerg@snapgear.com>


On Fri, 30 Nov 2012, gerg@snapgear.com wrote:

> -	pr_notice("Freeing unused kernel memory: %luk freed (0x%x - 0x%x)\n",
> -		(addr - (unsigned long) __init_begin) >> 10,
> -		(unsigned int) __init_begin, (unsigned int) __init_end);
> +	pr_notice("Freeing %s memory: %dk freed (0x%lx-0x%lx)\n", name, 
> +		pages << (PAGE_SHIFT - 10), start, end);

Perhaps "Freed %d KiB %s memory: 0x%lx - 0x%lx\n" is better (a tad shorter 
and has the correct unit).

Finn
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

  reply	other threads:[~2012-12-01  3:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-30  4:27 [PATCH] m68k: merge arch free memory functions into a single function gerg
2012-12-01  3:49 ` Finn Thain [this message]
2012-12-03  6:29   ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1212011441010.9740@nippy.intranet \
    --to=fthain@telegraphics.com.au \
    --cc=gerg@snapgear.com \
    --cc=gerg@uclinux.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=uclinux-dev@uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox