public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: linux-m68k@vger.kernel.org, uclinux-dev@uclinux.org,
	Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH] m68k: merge arch free memory functions into a single function
Date: Mon, 3 Dec 2012 16:29:33 +1000	[thread overview]
Message-ID: <50BC46CD.3050507@snapgear.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1212011441010.9740@nippy.intranet>

Hi Finn,

On 01/12/12 13:49, Finn Thain wrote:
> On Fri, 30 Nov 2012, gerg@snapgear.com wrote:
>
>> -	pr_notice("Freeing unused kernel memory: %luk freed (0x%x - 0x%x)\n",
>> -		(addr - (unsigned long) __init_begin) >> 10,
>> -		(unsigned int) __init_begin, (unsigned int) __init_end);
>> +	pr_notice("Freeing %s memory: %dk freed (0x%lx-0x%lx)\n", name,
>> +		pages << (PAGE_SHIFT - 10), start, end);
>
> Perhaps "Freed %d KiB %s memory: 0x%lx - 0x%lx\n" is better (a tad shorter
> and has the correct unit).

Sure. New patch coming up.

Thanks
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

      reply	other threads:[~2012-12-03  6:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-30  4:27 [PATCH] m68k: merge arch free memory functions into a single function gerg
2012-12-01  3:49 ` Finn Thain
2012-12-03  6:29   ` Greg Ungerer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50BC46CD.3050507@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=fthain@telegraphics.com.au \
    --cc=gerg@uclinux.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=uclinux-dev@uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox