From: Finn Thain <fthain@telegraphics.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH 2/3] m68k: Switch to asm-generic/barrier.h
Date: Wed, 5 Feb 2014 12:03:05 +1100 (EST) [thread overview]
Message-ID: <alpine.LNX.2.00.1402051145390.2188@nippy.intranet> (raw)
In-Reply-To: <1391544954-7422-2-git-send-email-geert@linux-m68k.org>
On Tue, 4 Feb 2014, Geert Uytterhoeven wrote:
> The generic nop() implementation is fine for m68k.
>
If the barrier in the old nop() implementation isn't needed anymore,
perhaps we should also remove the nop() instances in macfb.c? One comment
from this file says, "the nop's are there to order writes". (I don't know
whether there is any timing issue here. Seeing the way nop() was sprinkled
through macfb.c, I doubt that there is.) Is the volatile casting in
nubus_writeb() aka raw_outb() aka out_8() equivalent to the old barrier?
Finn
next prev parent reply other threads:[~2014-02-05 1:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1391544954-7422-1-git-send-email-geert@linux-m68k.org>
2014-02-04 20:15 ` [PATCH 2/3] m68k: Switch to asm-generic/barrier.h Geert Uytterhoeven
2014-02-04 20:15 ` [PATCH 3/3] m68k: Wire up sched_setattr and sched_getattr Geert Uytterhoeven
2014-02-05 0:59 ` [PATCH 1/3] m68k: Sort arch/m68k/include/asm/Kbuild Greg Ungerer
[not found] ` <1391544954-7422-2-git-send-email-geert@linux-m68k.org>
2014-02-05 0:59 ` [PATCH 2/3] m68k: Switch to asm-generic/barrier.h Greg Ungerer
2014-02-05 1:03 ` Finn Thain [this message]
2014-02-05 7:47 ` Geert Uytterhoeven
2014-02-06 7:05 ` Finn Thain
[not found] ` <1391544954-7422-3-git-send-email-geert@linux-m68k.org>
2014-02-05 1:00 ` [PATCH 3/3] m68k: Wire up sched_setattr and sched_getattr Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1402051145390.2188@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox