From: Finn Thain <fthain@telegraphics.com.au>
To: linux-m68k@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH] mac68k: fix mac_irq_pending() for PSC MACE and SCC
Date: Mon, 18 Jul 2011 19:44:17 +1000 (EST) [thread overview]
Message-ID: <alpine.OSX.2.00.1107181939190.145@ibook.local> (raw)
Add missing return statement. The docs say that the level 4 PSC IRQs
relate to MACE DMA and SCC. Since those drivers don't call
mac_irq_pending() this patch has no affect. But it should be fixed all the
same, since it can be useful for MACE debugging.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
arch/m68k/mac/macints.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.39/arch/m68k/mac/macints.c
===================================================================
--- linux-2.6.39.orig/arch/m68k/mac/macints.c 2011-07-18 19:22:54.000000000 +1000
+++ linux-2.6.39/arch/m68k/mac/macints.c 2011-07-18 19:29:37.000000000 +1000
@@ -370,7 +370,7 @@ int mac_irq_pending(unsigned int irq)
break;
case 4:
if (psc_present)
- psc_irq_pending(irq);
+ return psc_irq_pending(irq);
break;
}
return 0;
next reply other threads:[~2011-07-18 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 9:44 Finn Thain [this message]
2011-08-13 17:57 ` [PATCH] mac68k: fix mac_irq_pending() for PSC MACE and SCC Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.00.1107181939190.145@ibook.local \
--to=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox