public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
* [PATCH] mac68k: fix mac_irq_pending() for PSC MACE and SCC
@ 2011-07-18  9:44 Finn Thain
  2011-08-13 17:57 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Finn Thain @ 2011-07-18  9:44 UTC (permalink / raw)
  To: linux-m68k; +Cc: Geert Uytterhoeven


Add missing return statement. The docs say that the level 4 PSC IRQs 
relate to MACE DMA and SCC. Since those drivers don't call 
mac_irq_pending() this patch has no affect. But it should be fixed all the 
same, since it can be useful for MACE debugging.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

---
 arch/m68k/mac/macints.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.39/arch/m68k/mac/macints.c
===================================================================
--- linux-2.6.39.orig/arch/m68k/mac/macints.c	2011-07-18 19:22:54.000000000 +1000
+++ linux-2.6.39/arch/m68k/mac/macints.c	2011-07-18 19:29:37.000000000 +1000
@@ -370,7 +370,7 @@ int mac_irq_pending(unsigned int irq)
 		break;
 	case 4:
 		if (psc_present)
-			psc_irq_pending(irq);
+			return psc_irq_pending(irq);
 		break;
 	}
 	return 0;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mac68k: fix mac_irq_pending() for PSC MACE and SCC
  2011-07-18  9:44 [PATCH] mac68k: fix mac_irq_pending() for PSC MACE and SCC Finn Thain
@ 2011-08-13 17:57 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2011-08-13 17:57 UTC (permalink / raw)
  To: Finn Thain; +Cc: linux-m68k

On Mon, Jul 18, 2011 at 11:44, Finn Thain <fthain@telegraphics.com.au> wrote:
> Add missing return statement. The docs say that the level 4 PSC IRQs
> relate to MACE DMA and SCC. Since those drivers don't call
> mac_irq_pending() this patch has no affect. But it should be fixed all the
> same, since it can be useful for MACE debugging.

Thanks, applied. Will queue for 3.2.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-13 17:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-18  9:44 [PATCH] mac68k: fix mac_irq_pending() for PSC MACE and SCC Finn Thain
2011-08-13 17:57 ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox