* [PATCH] m68k: don't comment out syscalls used by glibc
@ 2011-11-01 20:34 Andreas Schwab
2011-11-10 20:28 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2011-11-01 20:34 UTC (permalink / raw)
To: linux-m68k
Define again the syscalls that are used by glibc so that it is possible to
compile a feature-complete glibc with the newest kernel headers.
Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
arch/m68k/include/asm/unistd.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/m68k/include/asm/unistd.h b/arch/m68k/include/asm/unistd.h
index 43f984e..d97234b 100644
--- a/arch/m68k/include/asm/unistd.h
+++ b/arch/m68k/include/asm/unistd.h
@@ -132,10 +132,10 @@
#define __NR_adjtimex 124
#define __NR_mprotect 125
#define __NR_sigprocmask 126
-/*#define __NR_create_module 127*/
+#define __NR_create_module 127
#define __NR_init_module 128
#define __NR_delete_module 129
-/*#define __NR_get_kernel_syms 130*/
+#define __NR_get_kernel_syms 130
#define __NR_quotactl 131
#define __NR_getpgid 132
#define __NR_fchdir 133
@@ -172,7 +172,7 @@
#define __NR_setresuid 164
#define __NR_getresuid 165
#define __NR_getpagesize 166
-/*#define __NR_query_module 167*/
+#define __NR_query_module 167
#define __NR_poll 168
#define __NR_nfsservctl 169
#define __NR_setresgid 170
@@ -193,8 +193,8 @@
#define __NR_capset 185
#define __NR_sigaltstack 186
#define __NR_sendfile 187
-/*#define __NR_getpmsg 188*/ /* some people actually want streams */
-/*#define __NR_putpmsg 189*/ /* some people actually want streams */
+#define __NR_getpmsg 188 /* some people actually want streams */
+#define __NR_putpmsg 189 /* some people actually want streams */
#define __NR_vfork 190
#define __NR_ugetrlimit 191
#define __NR_mmap2 192
--
1.7.7.1
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] m68k: don't comment out syscalls used by glibc
2011-11-01 20:34 [PATCH] m68k: don't comment out syscalls used by glibc Andreas Schwab
@ 2011-11-10 20:28 ` Geert Uytterhoeven
2011-11-11 8:45 ` Andreas Schwab
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2011-11-10 20:28 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linux-m68k, Arnd Bergmann
Hi Andreas,
On Tue, Nov 1, 2011 at 21:34, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Define again the syscalls that are used by glibc so that it is possible to
> compile a feature-complete glibc with the newest kernel headers.
I'm a bit puzzled by this. What exactly is your objective? To build a glibc that
runs on any possible kernel version ever released?
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> ---
> arch/m68k/include/asm/unistd.h | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/m68k/include/asm/unistd.h b/arch/m68k/include/asm/unistd.h
> index 43f984e..d97234b 100644
> --- a/arch/m68k/include/asm/unistd.h
> +++ b/arch/m68k/include/asm/unistd.h
> @@ -132,10 +132,10 @@
> #define __NR_adjtimex 124
> #define __NR_mprotect 125
> #define __NR_sigprocmask 126
> -/*#define __NR_create_module 127*/
> +#define __NR_create_module 127
> #define __NR_init_module 128
> #define __NR_delete_module 129
> -/*#define __NR_get_kernel_syms 130*/
> +#define __NR_get_kernel_syms 130
> #define __NR_quotactl 131
> #define __NR_getpgid 132
> #define __NR_fchdir 133
> @@ -172,7 +172,7 @@
> #define __NR_setresuid 164
> #define __NR_getresuid 165
> #define __NR_getpagesize 166
> -/*#define __NR_query_module 167*/
> +#define __NR_query_module 167
Support for the three syscalls above got removed day to day 10 years
ago, when adding support for Rusty's "In-kernel Module Loader" for
2.5.48. So I guess you need them for 2.4? I can understand that.
> #define __NR_poll 168
> #define __NR_nfsservctl 169
> #define __NR_setresgid 170
> @@ -193,8 +193,8 @@
> #define __NR_capset 185
> #define __NR_sigaltstack 186
> #define __NR_sendfile 187
> -/*#define __NR_getpmsg 188*/ /* some people actually want streams */
> -/*#define __NR_putpmsg 189*/ /* some people actually want streams */
> +#define __NR_getpmsg 188 /* some people actually want streams */
> +#define __NR_putpmsg 189 /* some people actually want streams */
> #define __NR_vfork 190
> #define __NR_ugetrlimit 191
> #define __NR_mmap2 192
AFAIK, the upstream kernel never had an implementation for sys_{get,put}msg().
I did find "[Linux-streams] [PATCH] Linux-streams registration 2.5.46"
(http://www.mail-archive.com/linux-streams@gsyc.escet.urjc.es/msg00639.html)
2.1.115pre1 added placeholders on i386, and we just followed suit.
Why do you need these?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] m68k: don't comment out syscalls used by glibc
2011-11-10 20:28 ` Geert Uytterhoeven
@ 2011-11-11 8:45 ` Andreas Schwab
2011-11-11 8:53 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2011-11-11 8:45 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-m68k, Arnd Bergmann
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> Hi Andreas,
>
> On Tue, Nov 1, 2011 at 21:34, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Define again the syscalls that are used by glibc so that it is possible to
>> compile a feature-complete glibc with the newest kernel headers.
>
> I'm a bit puzzled by this. What exactly is your objective? To build a glibc that
> runs on any possible kernel version ever released?
When building glibc it needs to know these numbers. Otherwise only
stubs are generated that never try to use them.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] m68k: don't comment out syscalls used by glibc
2011-11-11 8:45 ` Andreas Schwab
@ 2011-11-11 8:53 ` Geert Uytterhoeven
2011-11-11 9:03 ` Andreas Schwab
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2011-11-11 8:53 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linux-m68k, Arnd Bergmann
Hi Andreas,
On Fri, Nov 11, 2011 at 09:45, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>> On Tue, Nov 1, 2011 at 21:34, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>> Define again the syscalls that are used by glibc so that it is possible to
>>> compile a feature-complete glibc with the newest kernel headers.
>>
>> I'm a bit puzzled by this. What exactly is your objective? To build a glibc that
>> runs on any possible kernel version ever released?
>
> When building glibc it needs to know these numbers. Otherwise only
> stubs are generated that never try to use them.
Yes, I know that.
What's the user experience advantage of glibc knowing about the syscall
numbers for (never implemented) streams?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] m68k: don't comment out syscalls used by glibc
2011-11-11 8:53 ` Geert Uytterhoeven
@ 2011-11-11 9:03 ` Andreas Schwab
2011-11-20 9:47 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2011-11-11 9:03 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-m68k, Arnd Bergmann
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> What's the user experience advantage of glibc knowing about the syscall
> numbers for (never implemented) streams?
It will try to use them, instead of denying their existence.
There is no advantage in removing these definitions.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] m68k: don't comment out syscalls used by glibc
2011-11-11 9:03 ` Andreas Schwab
@ 2011-11-20 9:47 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2011-11-20 9:47 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linux-m68k, Arnd Bergmann
Hi Andreas,
On Fri, Nov 11, 2011 at 10:03, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>
>> What's the user experience advantage of glibc knowing about the syscall
>> numbers for (never implemented) streams?
>
> It will try to use them, instead of denying their existence.
>
> There is no advantage in removing these definitions.
You convinced me. Queued for 3.3.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-20 9:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-01 20:34 [PATCH] m68k: don't comment out syscalls used by glibc Andreas Schwab
2011-11-10 20:28 ` Geert Uytterhoeven
2011-11-11 8:45 ` Andreas Schwab
2011-11-11 8:53 ` Geert Uytterhoeven
2011-11-11 9:03 ` Andreas Schwab
2011-11-20 9:47 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox