public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
* [PATCH] m68knommu: remove extern definitions of memory_start/memory_end from mm/init
@ 2011-08-23  6:05 gerg
  2011-08-23 15:45 ` Andreas Schwab
  0 siblings, 1 reply; 3+ messages in thread
From: gerg @ 2011-08-23  6:05 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

We do not need to have local extern definitions of memory_start and
memory_end in mm/init_no.c. There are definitions already in asm/page_no.h.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/mm/init_no.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/m68k/mm/init_no.c b/arch/m68k/mm/init_no.c
index 66512da..3cf5a50 100644
--- a/arch/m68k/mm/init_no.c
+++ b/arch/m68k/mm/init_no.c
@@ -45,9 +45,6 @@
  */
 void *empty_zero_page;
 
-extern unsigned long memory_start;
-extern unsigned long memory_end;
-
 /*
  * paging_init() continues the virtual memory environment setup which
  * was begun by the code in arch/head.S.
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] m68knommu: remove extern definitions of memory_start/memory_end from mm/init
  2011-08-23  6:05 [PATCH] m68knommu: remove extern definitions of memory_start/memory_end from mm/init gerg
@ 2011-08-23 15:45 ` Andreas Schwab
  2011-08-24  1:23   ` Greg Ungerer
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2011-08-23 15:45 UTC (permalink / raw)
  To: gerg; +Cc: linux-m68k, uclinux-dev, Greg Ungerer

<gerg@snapgear.com> writes:

> From: Greg Ungerer <gerg@uclinux.org>
>
> We do not need to have local extern definitions of memory_start and
> memory_end in mm/init_no.c. There are definitions already in asm/page_no.h.

s/definitions/declarations/

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] m68knommu: remove extern definitions of memory_start/memory_end from mm/init
  2011-08-23 15:45 ` Andreas Schwab
@ 2011-08-24  1:23   ` Greg Ungerer
  0 siblings, 0 replies; 3+ messages in thread
From: Greg Ungerer @ 2011-08-24  1:23 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: linux-m68k, uclinux-dev

Hi Andreas,

On 24/08/11 01:45, Andreas Schwab wrote:
> <gerg@snapgear.com>  writes:
>
>> From: Greg Ungerer<gerg@uclinux.org>
>>
>> We do not need to have local extern definitions of memory_start and
>> memory_end in mm/init_no.c. There are definitions already in asm/page_no.h.
>
> s/definitions/declarations/

Yep, I'll change that. Thanks.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-24  1:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-23  6:05 [PATCH] m68knommu: remove extern definitions of memory_start/memory_end from mm/init gerg
2011-08-23 15:45 ` Andreas Schwab
2011-08-24  1:23   ` Greg Ungerer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox