[PATCH 159/199] arch/m68k/hp300/hp300map.map: Checkpatch cleanup

[PATCH 159/199] arch/m68k/hp300/hp300map.map: Checkpatch cleanup

[Andrea Gelmini]

arch/m68k/hp300/hp300map.map:185: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:186: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:187: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:188: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:189: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:190: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:191: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:192: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:193: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:194: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:195: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:196: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:197: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:198: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:199: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:200: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:201: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:202: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:203: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:204: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:205: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:206: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:207: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:208: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:209: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:210: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:211: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:212: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:213: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:214: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:215: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:216: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:217: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:218: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:219: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:220: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:221: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:222: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:223: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:224: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:225: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:226: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:227: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:228: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:229: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:230: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:231: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:232: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:233: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:234: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:235: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:236: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:237: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:238: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:239: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:240: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:241: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:242: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:243: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:244: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:245: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:246: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:247: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:248: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:249: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:250: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:251: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
arch/m68k/hp300/hp300map.map:252: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 arch/m68k/hp300/hp300map.map |  136 +++++++++++++++++++++---------------------
 1 files changed, 68 insertions(+), 68 deletions(-)

diff --git a/arch/m68k/hp300/hp300map.map b/arch/m68k/hp300/hp300map.map
index 6b45f0a..621c076 100644
--- a/arch/m68k/hp300/hp300map.map
+++ b/arch/m68k/hp300/hp300map.map
@@ -182,71 +182,71 @@ string Prior = "\033[5~"
 string Next = "\033[6~"
 string Macro = "\033[M"
 string Pause = "\033[P"
-compose '`' 'A' to 'À'
-compose '`' 'a' to 'à'
-compose '\'' 'A' to 'Á'
-compose '\'' 'a' to 'á'
-compose '^' 'A' to 'Â'
-compose '^' 'a' to 'â'
-compose '~' 'A' to 'Ã'
-compose '~' 'a' to 'ã'
-compose '"' 'A' to 'Ä'
-compose '"' 'a' to 'ä'
-compose 'O' 'A' to 'Å'
-compose 'o' 'a' to 'å'
-compose '0' 'A' to 'Å'
-compose '0' 'a' to 'å'
-compose 'A' 'A' to 'Å'
-compose 'a' 'a' to 'å'
-compose 'A' 'E' to 'Æ'
-compose 'a' 'e' to 'æ'
-compose ',' 'C' to 'Ç'
-compose ',' 'c' to 'ç'
-compose '`' 'E' to 'È'
-compose '`' 'e' to 'è'
-compose '\'' 'E' to 'É'
-compose '\'' 'e' to 'é'
-compose '^' 'E' to 'Ê'
-compose '^' 'e' to 'ê'
-compose '"' 'E' to 'Ë'
-compose '"' 'e' to 'ë'
-compose '`' 'I' to 'Ì'
-compose '`' 'i' to 'ì'
-compose '\'' 'I' to 'Í'
-compose '\'' 'i' to 'í'
-compose '^' 'I' to 'Î'
-compose '^' 'i' to 'î'
-compose '"' 'I' to 'Ï'
-compose '"' 'i' to 'ï'
-compose '-' 'D' to 'Ð'
-compose '-' 'd' to 'ð'
-compose '~' 'N' to 'Ñ'
-compose '~' 'n' to 'ñ'
-compose '`' 'O' to 'Ò'
-compose '`' 'o' to 'ò'
-compose '\'' 'O' to 'Ó'
-compose '\'' 'o' to 'ó'
-compose '^' 'O' to 'Ô'
-compose '^' 'o' to 'ô'
-compose '~' 'O' to 'Õ'
-compose '~' 'o' to 'õ'
-compose '"' 'O' to 'Ö'
-compose '"' 'o' to 'ö'
-compose '/' 'O' to 'Ø'
-compose '/' 'o' to 'ø'
-compose '`' 'U' to 'Ù'
-compose '`' 'u' to 'ù'
-compose '\'' 'U' to 'Ú'
-compose '\'' 'u' to 'ú'
-compose '^' 'U' to 'Û'
-compose '^' 'u' to 'û'
-compose '"' 'U' to 'Ü'
-compose '"' 'u' to 'ü'
-compose '\'' 'Y' to 'Ý'
-compose '\'' 'y' to 'ý'
-compose 'T' 'H' to 'Þ'
-compose 't' 'h' to 'þ'
-compose 's' 's' to 'ß'
-compose '"' 'y' to 'ÿ'
-compose 's' 'z' to 'ß'
-compose 'i' 'j' to 'ÿ'
+compose '`' 'A' to 'À'
+compose '`' 'a' to 'à'
+compose '\'' 'A' to 'Á'
+compose '\'' 'a' to 'á'
+compose '^' 'A' to 'Â'
+compose '^' 'a' to 'â'
+compose '~' 'A' to 'Ã'
+compose '~' 'a' to 'ã'
+compose '"' 'A' to 'Ä'
+compose '"' 'a' to 'ä'
+compose 'O' 'A' to 'Ã…'
+compose 'o' 'a' to 'Ã¥'
+compose '0' 'A' to 'Ã…'
+compose '0' 'a' to 'Ã¥'
+compose 'A' 'A' to 'Ã…'
+compose 'a' 'a' to 'Ã¥'
+compose 'A' 'E' to 'Æ'
+compose 'a' 'e' to 'æ'
+compose ',' 'C' to 'Ç'
+compose ',' 'c' to 'ç'
+compose '`' 'E' to 'È'
+compose '`' 'e' to 'è'
+compose '\'' 'E' to 'É'
+compose '\'' 'e' to 'é'
+compose '^' 'E' to 'Ê'
+compose '^' 'e' to 'ê'
+compose '"' 'E' to 'Ë'
+compose '"' 'e' to 'ë'
+compose '`' 'I' to 'Ì'
+compose '`' 'i' to 'ì'
+compose '\'' 'I' to 'Í'
+compose '\'' 'i' to 'í'
+compose '^' 'I' to 'ÃŽ'
+compose '^' 'i' to 'î'
+compose '"' 'I' to 'Ï'
+compose '"' 'i' to 'ï'
+compose '-' 'D' to 'Äž'
+compose '-' 'd' to 'ÄŸ'
+compose '~' 'N' to 'Ñ'
+compose '~' 'n' to 'ñ'
+compose '`' 'O' to 'Ã’'
+compose '`' 'o' to 'ò'
+compose '\'' 'O' to 'Ó'
+compose '\'' 'o' to 'ó'
+compose '^' 'O' to 'Ô'
+compose '^' 'o' to 'ô'
+compose '~' 'O' to 'Õ'
+compose '~' 'o' to 'õ'
+compose '"' 'O' to 'Ö'
+compose '"' 'o' to 'ö'
+compose '/' 'O' to 'Ø'
+compose '/' 'o' to 'ø'
+compose '`' 'U' to 'Ù'
+compose '`' 'u' to 'ù'
+compose '\'' 'U' to 'Ú'
+compose '\'' 'u' to 'ú'
+compose '^' 'U' to 'Û'
+compose '^' 'u' to 'û'
+compose '"' 'U' to 'Ü'
+compose '"' 'u' to 'ü'
+compose '\'' 'Y' to 'Ä°'
+compose '\'' 'y' to 'ı'
+compose 'T' 'H' to 'Åž'
+compose 't' 'h' to 'ÅŸ'
+compose 's' 's' to 'ß'
+compose '"' 'y' to 'ÿ'
+compose 's' 'z' to 'ß'
+compose 'i' 'j' to 'ÿ'
-- 
1.7.1.251.gf80a2

[PATCH 160/199] arch/m68k/sun3/leds.c: Checkpatch cleanup

[Andrea Gelmini]

arch/m68k/sun3/leds.c:10: ERROR: code indent should use tabs where possible
arch/m68k/sun3/leds.c:11: ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 arch/m68k/sun3/leds.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/m68k/sun3/leds.c b/arch/m68k/sun3/leds.c
index a3e9484..aad2e0a 100644
--- a/arch/m68k/sun3/leds.c
+++ b/arch/m68k/sun3/leds.c
@@ -7,7 +7,7 @@ void sun3_leds(unsigned char byte)
 	unsigned char dfc;
 
 	GET_DFC(dfc);
-        SET_DFC(FC_CONTROL);
-	SET_CONTROL_BYTE(AC_LEDS,byte);
+	SET_DFC(FC_CONTROL);
+	SET_CONTROL_BYTE(AC_LEDS, byte);
 	SET_DFC(dfc);
 }
-- 
1.7.1.251.gf80a2

Re: [PATCH 159/199] arch/m68k/hp300/hp300map.map: Checkpatch cleanup

[Geert Uytterhoeven]

On Sun, May 23, 2010 at 22:01, Andrea Gelmini <andrea.gelmini@gelma.net> wrote:
> arch/m68k/hp300/hp300map.map:185: ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8

Thx, applied!

Redone using recode "ISO-8859-15..UTF-8" as git am fails to apply such patches.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH 159/199] arch/m68k/hp300/hp300map.map: Checkpatch cleanup

[Andreas Schwab]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 808 bytes --]

Andrea Gelmini <andrea.gelmini@gelma.net> writes:

> diff --git a/arch/m68k/hp300/hp300map.map b/arch/m68k/hp300/hp300map.map
> index 6b45f0a..621c076 100644
> --- a/arch/m68k/hp300/hp300map.map
> +++ b/arch/m68k/hp300/hp300map.map
> @@ -182,71 +182,71 @@ string Prior = "\033[5~"
>  string Next = "\033[6~"
>  string Macro = "\033[M"
>  string Pause = "\033[P"
> -compose '`' 'A' to 'À'
[...]
> +compose '`' 'A' to 'À'

This is obviously wrong.  The composed character is supposed to be a
single latin-1 character (namely '\300').

A patch subject containing "checkpatch" should always ring the alarm
bells.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [PATCH 159/199] arch/m68k/hp300/hp300map.map: Checkpatch cleanup

[Geert Uytterhoeven]

On Sun, Jun 6, 2010 at 13:30, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Andrea Gelmini <andrea.gelmini@gelma.net> writes:
>
>> diff --git a/arch/m68k/hp300/hp300map.map b/arch/m68k/hp300/hp300map.map
>> index 6b45f0a..621c076 100644
>> --- a/arch/m68k/hp300/hp300map.map
>> +++ b/arch/m68k/hp300/hp300map.map
>> @@ -182,71 +182,71 @@ string Prior = "\033[5~"
>>  string Next = "\033[6~"
>>  string Macro = "\033[M"
>>  string Pause = "\033[P"
>> -compose '`' 'A' to 'À'
> [...]
>> +compose '`' 'A' to 'À'
>
> This is obviously wrong.  The composed character is supposed to be a
> single latin-1 character (namely '\300').

Sorry, you're right. Loadkeys is indeed not yet aware of UTF-8.

> A patch subject containing "checkpatch" should always ring the alarm
> bells.

;-)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds