public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
* [PATCH] m68knommu: fix fec setup warning for ColdFire 5271 builds
@ 2015-03-26  3:22 gerg
  2015-03-26  8:27 ` Andreas Schwab
  0 siblings, 1 reply; 3+ messages in thread
From: gerg @ 2015-03-26  3:22 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

Building for the ColdFire 5271 produces the following warning:

arch/m68k/coldfire/m527x.c: In function ‘m527x_fec_init’:
arch/m68k/coldfire/m527x.c:95:6: warning: unused variable ‘par’

Fix it my moving the definition of par inside the 5271 conditional code.

Reported-by: ertheb <3rth3bnospam@ethe.fr>
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/coldfire/m527x.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/m68k/coldfire/m527x.c b/arch/m68k/coldfire/m527x.c
index 2ba4707..c0b3e28 100644
--- a/arch/m68k/coldfire/m527x.c
+++ b/arch/m68k/coldfire/m527x.c
@@ -92,7 +92,6 @@ static void __init m527x_uarts_init(void)
 
 static void __init m527x_fec_init(void)
 {
-	u16 par;
 	u8 v;
 
 	/* Set multi-function pins to ethernet mode for fec0 */
@@ -100,6 +99,8 @@ static void __init m527x_fec_init(void)
 	v = readb(MCFGPIO_PAR_FECI2C);
 	writeb(v | 0xf0, MCFGPIO_PAR_FECI2C);
 #else
+	u16 par;
+
 	par = readw(MCFGPIO_PAR_FECI2C);
 	writew(par | 0xf00, MCFGPIO_PAR_FECI2C);
 	v = readb(MCFGPIO_PAR_FEC0HL);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] m68knommu: fix fec setup warning for ColdFire 5271 builds
  2015-03-26  3:22 [PATCH] m68knommu: fix fec setup warning for ColdFire 5271 builds gerg
@ 2015-03-26  8:27 ` Andreas Schwab
  2015-03-26  8:50   ` Greg Ungerer
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2015-03-26  8:27 UTC (permalink / raw)
  To: gerg; +Cc: linux-m68k, uclinux-dev

gerg@uclinux.org writes:

> Fix it my moving the definition of par inside the 5271 conditional code.

s/my/by/

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] m68knommu: fix fec setup warning for ColdFire 5271 builds
  2015-03-26  8:27 ` Andreas Schwab
@ 2015-03-26  8:50   ` Greg Ungerer
  0 siblings, 0 replies; 3+ messages in thread
From: Greg Ungerer @ 2015-03-26  8:50 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: linux-m68k, uclinux-dev


On 26/03/15 18:27, Andreas Schwab wrote:
> gerg@uclinux.org writes:
>
>> Fix it my moving the definition of par inside the 5271 conditional code.
> s/my/by/

Thanks Andreas, I'll fix that up.

Regards
Greg


_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-26  8:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-26  3:22 [PATCH] m68knommu: fix fec setup warning for ColdFire 5271 builds gerg
2015-03-26  8:27 ` Andreas Schwab
2015-03-26  8:50   ` Greg Ungerer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox